René's URL Explorer Experiment


Title: CLS store gets reset on the first callback in http scenario · Issue #32060 · nodejs/node · GitHub

Open Graph Title: CLS store gets reset on the first callback in http scenario · Issue #32060 · nodejs/node

X Title: CLS store gets reset on the first callback in http scenario · Issue #32060 · nodejs/node

Description: Version: master Platform: Linux Subsystem: async_hooks What steps will reproduce the bug? I have been trying to write some new scenarios for AsyncLocalStorage class, as mentioned in #31978, and came across this issue: const { AsyncLocalS...

Open Graph Description: Version: master Platform: Linux Subsystem: async_hooks What steps will reproduce the bug? I have been trying to write some new scenarios for AsyncLocalStorage class, as mentioned in #31978, and cam...

X Description: Version: master Platform: Linux Subsystem: async_hooks What steps will reproduce the bug? I have been trying to write some new scenarios for AsyncLocalStorage class, as mentioned in #31978, and cam...

Opengraph URL: https://github.com/nodejs/node/issues/32060

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CLS store gets reset on the first callback in http scenario","articleBody":"\u003c!--\r\nThank you for reporting an issue.\r\n\r\nThis issue tracker is for bugs and issues found within Node.js core.\r\nIf you require more general support please file an issue on our help\r\nrepo. https://github.com/nodejs/help\r\n\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify affected core module name\r\n--\u003e\r\n\r\n* **Version**: master\r\n* **Platform**: Linux\r\n* **Subsystem**: async_hooks\r\n\r\n### What steps will reproduce the bug?\r\n\r\nI have been trying to write some new scenarios for AsyncLocalStorage class, as mentioned in https://github.com/nodejs/node/issues/31978, and came across this issue:\r\n\r\n\r\n```js\r\nconst { AsyncLocalStorage } = require('async_hooks');\r\nconst http = require('http')\r\nconst cls = new AsyncLocalStorage();\r\n\r\nconst server = http.createServer((req, res) =\u003e {\r\n  res.write('hello')\r\n  setTimeout(() =\u003e {\r\n    res.end(' world!')\r\n  }, 1000)\r\n})\r\n\r\nserver.listen(12000, () =\u003e {\r\n  cls.run(() =\u003e {\r\n    const req = http.get('http://localhost:12000', (res) =\u003e {\r\n      const store = cls.getStore()\r\n      store.set('foo', '')\r\n      res.on('data', (d) =\u003e { console.log(cls.getStore()) });\r\n    })\r\n    req.end()\r\n  })\r\n})\r\n```\r\n\r\nIn this simple client-server program, the server is sending two chunks of data, forcing the `ondata` handler to be invoked twice.\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nevery time\r\n\r\n### What is the expected behavior?\r\n\r\nI get an empty Map every time in the ondata callback\r\n\r\n\u003c!--\r\nIf possible please provide textual output instead of screenshots.\r\n--\u003e\r\n\r\n### What do you see instead?\r\n\r\nUnfortunately, the store is `undefined` after the first invocation:\r\n\r\n```trace\r\n$ node foo.js\r\nMap(1) { 'foo' =\u003e '' }\r\nundefined\r\n^C\r\n$\r\n```\r\n\r\n\u003c!--\r\nIf possible please provide textual output instead of screenshots.\r\n--\u003e\r\n\r\n### Additional information\r\n\r\nIf I replace this with a simple timer code, this logic works fine:\r\n\r\n```js\r\nconst { AsyncLocalStorage } = require('async_hooks');\r\nconst cls = new AsyncLocalStorage();\r\n\r\ncls.run(() =\u003e {\r\n  const store = cls.getStore()\r\n  store.set('foo', 'bar')\r\n  setInterval(() =\u003e {\r\n    console.log(cls.getStore().get('foo'))\r\n  }, 1000)\r\n}) \r\n```\r\n\r\n$ node timer.js\r\n```trace\r\nbar\r\nbar\r\nbar\r\nbar\r\n^C\r\n```\r\n\r\n\r\nAm I missing something?\r\n\r\nPing @vdeturckheim \r\n\u003c!--\r\nTell us anything else you think we should know.\r\n--\u003e\r\n","author":{"url":"https://github.com/HarshithaKP","@type":"Person","name":"HarshithaKP"},"datePublished":"2020-03-03T07:23:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/32060/node/issues/32060"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:63d5400d-1ede-0d54-a978-e28bff709876
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE46E:3F60C6:A0574E:D8365D:6A4ECF63
html-safe-noncec7d7832dd6d7ed8f0ca875806d6ac28e906307b79aa276637be337769d035a24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDZFOjNGNjBDNjpBMDU3NEU6RDgzNjVEOjZBNEVDRjYzIiwidmlzaXRvcl9pZCI6Ijg0NDE0MTAyOTEwNjU4NjgxMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7eaa6f6be0b443539651527b0640165c8e87a34c493ee523495eeee121066429
hovercard-subject-tagissue:574467544
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/32060/issue_layout
twitter:imagehttps://opengraph.githubassets.com/228e6d38530abbb72863b47ac096920960c4317ef64ff411e1130c4808501e79/nodejs/node/issues/32060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/228e6d38530abbb72863b47ac096920960c4317ef64ff411e1130c4808501e79/nodejs/node/issues/32060
og:image:altVersion: master Platform: Linux Subsystem: async_hooks What steps will reproduce the bug? I have been trying to write some new scenarios for AsyncLocalStorage class, as mentioned in #31978, and cam...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHarshithaKP
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/32060#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F32060
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F32060
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/32060
Reloadhttps://github.com/nodejs/node/issues/32060
Reloadhttps://github.com/nodejs/node/issues/32060
Please reload this pagehttps://github.com/nodejs/node/issues/32060
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/32060
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
CLS store gets reset on the first callback in http scenariohttps://github.com/nodejs/node/issues/32060#top
async_hooksIssues and PRs related to the async hooks subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_hooks%22
confirmed-bugIssues with confirmed bugs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22confirmed-bug%22
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
on Mar 3, 2020https://github.com/nodejs/node/issues/32060#issue-574467544
#31978https://github.com/nodejs/node/issues/31978
@vdeturckheimhttps://github.com/vdeturckheim
async_hooksIssues and PRs related to the async hooks subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_hooks%22
confirmed-bugIssues with confirmed bugs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22confirmed-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.