René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`finished(stream, cb)` invokes callback too early","articleBody":"The semantics of `finished` is to invoke the callback on `'end'` and `'finish'`. The problem with this is that this does not mean that the stream is actually \"finished\", i.e. it might still emit `'error'` and has probably not yet freed all resources since `'close'` is not yet emitted.\r\n\r\nThe reason we invoke it early in this way is because not all stream actually emit `'close'`. I'm a little unsure how to resolve this and whether this is worth resolving.\r\n\r\nOne way could be to use `setImmediate` or `setTimeout` before invoking the callback in `'end'`/`'finish'` in order to give a chance for `'error'` or `'close'` to be emitted. However, that is very much imperfect.\r\n\r\nWe might want to at least clarify this in the docs.\r\n\r\nThoughts? @nodejs/streams   ","author":{"url":"https://github.com/ronag","@type":"Person","name":"ronag"},"datePublished":"2020-03-01T18:25:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":19},"url":"https://github.com/32032/node/issues/32032"}