René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"node does not abort at the right time when using --abort-on-uncaught-exception","articleBody":"nodejs/master's head does not abort at the right time when using `--abort-on-uncaught-exception`. Here's a reproduction of the problem on SmartOS:\n\n```\n$ git rev-parse --short HEAD\n02448c6\n[root@dev ~/node-1]# make\nmake -C out BUILDTYPE=Release V=1\nmake[1]: Entering directory '/root/node-1/out'\nmake[1]: Nothing to be done for 'all'.\nmake[1]: Leaving directory '/root/node-1/out'\nln -fs out/Release/node node\n$ ln -sf `pwd`/out/Release/node /opt/local/bin/node\n[root@dev ~/node-1]# node --version\nv5.0.0-pre\n$ node --abort-on-uncaught-exception -e 'setTimeout(function () { function boom() { throw new Error(\"foo\") } boom(); }, 10);'\n[eval]:1\nsetTimeout(function () { function boom() { throw new Error(\"foo\") } boom(); }, 10);\n                                           ^\n\nError: foo\n    at boom ([eval]:1:50)\n    at null._onTimeout ([eval]:1:69)\n    at Timer.listOnTimeout (timers.js:89:15)\nAbort (core dumped)\n$ mdb /var/cores/core.node.8212 \nLoading modules: [ libumem.so.1 libc.so.1 ld.so.1 ]\n\u003e ::load /root/mdb_v8/build/amd64/mdb_v8.so\nmdb_v8 version: 1.0.0 (dev)\nV8 version: 4.5.103.33\nAutoconfigured V8 support from target\nC++ symbol demangling enabled\n\u003e ::jsstack\nnative: libc.so.1`_lwp_kill+0xa\nnative: libc.so.1`raise+0x20\nnative: libc.so.1`abort+0x98\nnative: node::FatalException+0xd7\nnative: v8::internal::MessageHandler::ReportMessage+0x1ee\nnative: v8::internal::Isolate::ReportPendingMessages+0x234\nnative: v8::internal::Execution::Call+0x4a3\nnative: v8::Function::Call+0xff\nnative: v8::Function::Call+0x41\nnative: node::AsyncWrap::MakeCallback+0x23a\nnative: node::TimerWrap::OnTimeout+0x96\nnative: uv__run_timers+0x7d\nnative: uv_run+0x35a\nnative: node::Start+0x538\nnative: _start+0x6c\n\u003e\n```\n\nNote that the call stack doesn't contain any JavaScript frame, and indicates that node aborted in `node::FatalException`, not when the error was thrown.\n\nThis is a problem because users of post-mortem debuggers and `--abort-on-uncaught-exception` need to have core dumps that are generated when the exception is thrown, and the core dumps need to have the frame that throws the error in the call stack. Otherwise, it becomes much more difficult, if not impossible to determine the root cause of the problem.\n\nIn the example above, there's no way to know that the error was thrown by the function named `foo`, we just know that one timer's callback threw.\n\nThis regression was introduced by https://github.com/nodejs/node/pull/922, which made V8 ignore `--abort-on-uncaught-exception`. An attempt at fixing that regression was made with https://github.com/nodejs/node/pull/2776, but instead of letting V8 abort in `Isolate::Throw` (when it actually throws the error and when all the relevant frames are active on the stack), it throws in `node::FatalException` as shown above.\n\nI will submit two different PRs that fix this issue in two different ways so that we can discuss the pros and cons of the two different approaches I came up with.\n\n/cc @nodejs/post-mortem\n","author":{"url":"https://github.com/misterdjules","@type":"Person","name":"misterdjules"},"datePublished":"2015-09-24T01:21:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/3035/node/issues/3035"}