René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Loading OpenSSL config files twice","articleBody":"### Problem\r\nWhen `OPENSSL_CONF` environment variable is set, config files are loaded twice.\r\n\r\n### Reason\r\n\r\n`InitCryptoOnce` function in [node_crypto.cc](https://github.com/nodejs/node/blob/master/src/node_crypto.cc#L6917) first calls `SSL_load_error_strings()` which is a macro for `OPENSSL_init_ssl()` which in turn will at some point will call `CONF_modules_load_file()` for the file pointed to by `OPENSSL_CONF` environment variable. Then in the same function (`InitCryptoOnce()`) `CONF_modules_load_file()` will be called again for the file pointed to by `openssl_config` command line option.\r\n\r\nBut upon nodejs initialization, if `openssl_config` is not given, and if `OPENSSL_CONF` is set, `openssl_config` is set to the value in `OPENSSL_CONF`. As a result `CONF_modules_load_file()` will be called twice.\r\n\r\n### Impact\r\nNormally none, except for cases when the config is not idempotent, as is the case e.g. when dynamic engines need to be loaded. In which case it is also not a huge deal, but the user will see a scary error message:\r\n\r\n```\r\nopenssl config failed: error:26078067:engine routines:engine_list_add:conflicting engine id\r\n```\r\n\r\nNot sure what would be the best fix, probably it's also not too urgent. ","author":{"url":"https://github.com/OYTIS","@type":"Person","name":"OYTIS"},"datePublished":"2019-09-25T14:30:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/29702/node/issues/29702"}