Title: http2 compat missing writableFinished · Issue #29230 · nodejs/node · GitHub
Open Graph Title: http2 compat missing writableFinished · Issue #29230 · nodejs/node
X Title: http2 compat missing writableFinished · Issue #29230 · nodejs/node
Description: http2 compat is missing writableFinished for OutgoingMessage. I tried fixing this myself but the whole finished flow for http2 compat confuses me. finished seems to be looking at a lot of different stuff (e.g. what does abort have to do ...
Open Graph Description: http2 compat is missing writableFinished for OutgoingMessage. I tried fixing this myself but the whole finished flow for http2 compat confuses me. finished seems to be looking at a lot of different...
X Description: http2 compat is missing writableFinished for OutgoingMessage. I tried fixing this myself but the whole finished flow for http2 compat confuses me. finished seems to be looking at a lot of different...
Opengraph URL: https://github.com/nodejs/node/issues/29230
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"http2 compat missing writableFinished","articleBody":"http2 compat is missing `writableFinished` for `OutgoingMessage`.\r\n\r\nI tried fixing this myself but the whole finished flow for http2 compat confuses me.\r\n\r\n- `finished` seems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).\r\n- `'finish'` is emitted on `stream.on('close', ...)`.\r\n- Sometimes we listen to `this.on('finish', ...)` and sometimes `stream.on('finish', ...)`.\r\n\r\nI think someone with a clearer understanding needs to look at this.","author":{"url":"https://github.com/ronag","@type":"Person","name":"ronag"},"datePublished":"2019-08-20T19:38:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/29230/node/issues/29230"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5907a2e4-b09b-acc9-5386-5a25082fcd7c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9464:6474B:368D7C:4AE309:6A4DC3CE |
| html-safe-nonce | ba765219e4ebcc559f9b221eb952971dbf65cd6fc53270936b814ab37035c043 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDY0OjY0NzRCOjM2OEQ3Qzo0QUUzMDk6NkE0REMzQ0UiLCJ2aXNpdG9yX2lkIjoiNDY5NjE4ODIxNzU2NDQ0NzY5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9aba2583f3d581e21982b05ee7749fd385fcad2fa55bfeba5ea13131ea2e0def |
| hovercard-subject-tag | issue:483044684 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/29230/issue_layout |
| twitter:image | https://opengraph.githubassets.com/907e1236d507d4b6221b83589da945cf4e95a937ae1f89e3b00189c301d739d5/nodejs/node/issues/29230 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/907e1236d507d4b6221b83589da945cf4e95a937ae1f89e3b00189c301d739d5/nodejs/node/issues/29230 |
| og:image:alt | http2 compat is missing writableFinished for OutgoingMessage. I tried fixing this myself but the whole finished flow for http2 compat confuses me. finished seems to be looking at a lot of different... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width