Title: stream: event contract · Issue #29005 · nodejs/node · GitHub
Open Graph Title: stream: event contract · Issue #29005 · nodejs/node
X Title: stream: event contract · Issue #29005 · nodejs/node
Description: Try to follow the assumed "contract"/"api" in terms of stream events: events (only close after error, nothing after close, only error or close after destroy) don't emit finish on error (#28979) document when destroy emits events (#28970)...
Open Graph Description: Try to follow the assumed "contract"/"api" in terms of stream events: events (only close after error, nothing after close, only error or close after destroy) don't emit finish on error (#28979) doc...
X Description: Try to follow the assumed "contract"/"api" in terms of stream events: events (only close after error, nothing after close, only error or close after destroy) don't emit fini...
Opengraph URL: https://github.com/nodejs/node/issues/29005
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"stream: event contract","articleBody":"Try to follow the assumed \"contract\"/\"api\" in terms of stream events:\r\n\r\nevents (only `close` after `error`, nothing after `close`, only `error` or `close` after destroy)\r\n\r\n- [ ] don't emit finish on error (https://github.com/nodejs/node/pull/28979)\r\n- [ ] document when destroy emits events (https://github.com/nodejs/node/pull/28970)\r\n- [ ] don't emit open after destroy (https://github.com/nodejs/node/pull/28765)\r\n- [ ] don't emit after 'error' (https://github.com/nodejs/node/pull/28708)\r\n- [ ] don't emit finish on error (https://github.com/nodejs/node/pull/28979)\r\n- [ ] eos premature close (https://github.com/nodejs/node/pull/28720)","author":{"url":"https://github.com/ronag","@type":"Person","name":"ronag"},"datePublished":"2019-08-06T10:35:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/29005/node/issues/29005"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5d286191-253b-304f-5f42-6dc4a456c4f0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EBA0:273DA9:12FEDCE:193B84E:6A51B344 |
| html-safe-nonce | 8aed1f32b6318e22896d6f8761eb667c94db5602c3cfa0a8fa140437ff1f1164 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkEwOjI3M0RBOToxMkZFRENFOjE5M0I4NEU6NkE1MUIzNDQiLCJ2aXNpdG9yX2lkIjoiODY0MDIzNDEyODMxMzI2NzAxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 31ab1bc39c0c5231879a51aa8b762d33e309af07a7c0a43518f9bddd1f7fcbd6 |
| hovercard-subject-tag | issue:477302157 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/29005/issue_layout |
| twitter:image | https://opengraph.githubassets.com/89544d53232d8cfd86fb8ce4e4f09c6537f400bd4243e0d971797a4ea27267a7/nodejs/node/issues/29005 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/89544d53232d8cfd86fb8ce4e4f09c6537f400bd4243e0d971797a4ea27267a7/nodejs/node/issues/29005 |
| og:image:alt | Try to follow the assumed "contract"/"api" in terms of stream events: events (only close after error, nothing after close, only error or close after destroy) don't emit finish on error (#28979) doc... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width