René's URL Explorer Experiment


Title: Some `http2` errors are not captured · Issue #28895 · nodejs/node · GitHub

Open Graph Title: Some `http2` errors are not captured · Issue #28895 · nodejs/node

X Title: Some `http2` errors are not captured · Issue #28895 · nodejs/node

Description: Version: v12.6.0 Platform: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux Subsystem: http2 const http2 = require('http2'); try { const session = http2.connect('https://example.com', { settings...

Open Graph Description: Version: v12.6.0 Platform: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux Subsystem: http2 const http2 = require('http2'); try { const session = http2.c...

X Description: Version: v12.6.0 Platform: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux Subsystem: http2 const http2 = require('http2'); try { const session =...

Opengraph URL: https://github.com/nodejs/node/issues/28895

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Some `http2` errors are not captured","articleBody":"* **Version**: v12.6.0\r\n* **Platform**: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux\r\n* **Subsystem**: http2\r\n\r\n```js\r\nconst http2 = require('http2');\r\n\r\ntry {\r\n    const session = http2.connect('https://example.com', {\r\n        settings: {\r\n            maxFrameSize: 1\r\n        }\r\n    });\r\n    \r\n    session.on('error', error =\u003e {\r\n        console.log('Captured an error.');\r\n    });\r\n} catch (error) {\r\n    console.log('Captured an error.');\r\n}\r\n```\r\n\r\n[See it on RunKit.](https://runkit.com/szmarczak/5d3f399f2f4891001ab1616a)\r\n\r\n### Actual behavior\r\n\r\n```\r\ninternal/http2/util.js:521\r\n      throw new ERR_HTTP2_INVALID_SETTING_VALUE.RangeError(\r\n      ^\r\n\r\nRangeError [ERR_HTTP2_INVALID_SETTING_VALUE]: Invalid value for setting \"maxFrameSize\": 1\r\n    at ClientHttp2Session.settings (internal/http2/core.js:1156:5)\r\n    at ClientHttp2Session.setupHandle (internal/http2/core.js:861:8)\r\n    at Object.onceWrapper (events.js:291:20)\r\n    at TLSSocket.emit (events.js:203:13)\r\n    at TLSSocket.onConnectSecure (_tls_wrap.js:1346:10)\r\n    at TLSSocket.emit (events.js:203:13)\r\n    at TLSSocket._finishInit (_tls_wrap.js:792:8)\r\n    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:606:12) {\r\n  actual: 1,\r\n  min: 16384,\r\n  max: 16777215\r\n}\r\n```\r\n\r\n### Expected behavior\r\n\r\n```\r\nCaptured an error.\r\n```\r\n\r\n### Possible solution\r\n\r\nIt's thrown from here:\r\n\r\nhttps://github.com/nodejs/node/blob/98d8ed64ff850a2a76685112886c22faa30e156d/lib/internal/http2/core.js#L975\r\n\r\nI think it needs to be like:\r\n\r\n```js\r\n      socket.once(connectEvent, () =\u003e {\r\n        try {\r\n          setupFn();\r\n        } catch (error) {\r\n          socket.destroy(error);\r\n        }\r\n      });\r\n```","author":{"url":"https://github.com/szmarczak","@type":"Person","name":"szmarczak"},"datePublished":"2019-07-29T18:39:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/28895/node/issues/28895"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:361dff8e-b3a1-f5d0-b9b3-4f3b9044d26d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA7FC:3C7A3:1C4163A:26CE05E:6A4F27FD
html-safe-nonce7f572ca01ec8404b782572282f89ae590065be6352db9670d45545c17d6edf3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0ZDOjNDN0EzOjFDNDE2M0E6MjZDRTA1RTo2QTRGMjdGRCIsInZpc2l0b3JfaWQiOiIxMTE2OTU2MjQwNTI3Njk3OTE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac789d2b95799c0b004a43dd22b921cc235cce439a627e29d7d5cebe6099dc5595
hovercard-subject-tagissue:474197493
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/28895/issue_layout
twitter:imagehttps://opengraph.githubassets.com/882bbaed1d3ceccef200f39e04c1a130e03a1c4346cddfb0a32a1e77a2f97869/nodejs/node/issues/28895
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/882bbaed1d3ceccef200f39e04c1a130e03a1c4346cddfb0a32a1e77a2f97869/nodejs/node/issues/28895
og:image:altVersion: v12.6.0 Platform: Linux solus 5.1.14-121.current #1 SMP PREEMPT Sun Jun 23 13:57:07 UTC 2019 x86_64 GNU/Linux Subsystem: http2 const http2 = require('http2'); try { const session = http2.c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameszmarczak
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/28895#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F28895
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F28895
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/28895
Reloadhttps://github.com/nodejs/node/issues/28895
Reloadhttps://github.com/nodejs/node/issues/28895
Please reload this pagehttps://github.com/nodejs/node/issues/28895
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/28895
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Some http2 errors are not capturedhttps://github.com/nodejs/node/issues/28895#top
http2Issues or PRs related to the http2 subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22http2%22
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
on Jul 29, 2019https://github.com/nodejs/node/issues/28895#issue-474197493
deps: update openssl to 1.0.1j #1https://github.com/nodejs/node/pull/1
See it on RunKit.https://runkit.com/szmarczak/5d3f399f2f4891001ab1616a
node/lib/internal/http2/core.jshttps://github.com/nodejs/node/blob/98d8ed64ff850a2a76685112886c22faa30e156d/lib/internal/http2/core.js#L975
98d8ed6https://github.com/nodejs/node/commit/98d8ed64ff850a2a76685112886c22faa30e156d
http2Issues or PRs related to the http2 subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22http2%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.