René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Piping streams into SHA3 without end: false crashes","articleBody":"\u003c!--\r\nThank you for reporting a possible bug in Node.js.\r\n\r\nPlease fill in as much of the template below as you can.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify the affected core module name\r\n\r\nIf possible, please provide code that demonstrates the problem, keeping it as\r\nsimple and free of external dependencies as you can.\r\n-->\r\n\r\n* **Version**: 12.4.0\r\n* **Platform**: Windows 10 x64 and Linux 4.4.0-042stab138.1\r\n* **Subsystem**: crypto or deps\r\n\r\n\u003c!-- Please provide more details below this comment. -->\r\n\r\nThis code causes a segmentation fault in 12.4.0:\r\n\r\n```javascript\r\nconst crypto = require('crypto');\r\nconst fs = require('fs');\r\n\r\nconst myOwnCode = fs.createReadStream(__filename);\r\nconst copy = fs.createWriteStream(`${__filename}.copy`);\r\nconst hash = crypto.createHash('sha3-512');\r\nmyOwnCode.pipe(hash);\r\nmyOwnCode.pipe(copy).on('finish', () => {\r\n  hash.digest();\r\n});\r\n```\r\n\r\nThis seems to be caused by `pipe` calling `hash._flush` when `end` is not set to `false`. This code also causes a segmentation fault:\r\n\r\n```javascript\r\nconst crypto = require('crypto');\r\n\r\nconst hash = crypto.createHash('sha3-512');\r\nhash._flush(() => console.log('Flushed'));\r\nhash.digest();\r\n```\r\n\r\nThis seems to be at least partially caused by the implementation of `_flush`:\r\n\r\nhttps://github.com/nodejs/node/blob/908292cf1f551c614a733d858528ffb13fb3a524/lib/internal/crypto/hash.js#L54-L57\r\n\r\nIt bypasses the `this[kState][kFinalized]` safeguard:\r\n\r\nhttps://github.com/nodejs/node/blob/908292cf1f551c614a733d858528ffb13fb3a524/lib/internal/crypto/hash.js#L79-L91\r\n\r\nNote that this bug only happens when using SHA3, `sha256` seems to be working just fine, so there might also be some weirdness in OpenSSL.\r\n\r\ncc @mcollina @nodejs/crypto @nodejs/streams","author":{"url":"https://github.com/tniessen","@type":"Person","name":"tniessen"},"datePublished":"2019-06-15T13:03:21Z","url":"https://github.com/nodejs/node/issues/28245"}