René's URL Explorer Experiment


Title: tests: review and fix ineffective error tests · Issue #26385 · nodejs/node · GitHub

Open Graph Title: tests: review and fix ineffective error tests · Issue #26385 · nodejs/node

X Title: tests: review and fix ineffective error tests · Issue #26385 · nodejs/node

Description: See #26078 (review) for context. After that, I looked up if we already have similar ineffective tests in our codebase, and I think that I found at least one. E.g. using grep -r ' catch' test/ -A 2 | grep strictEqual, this one popped up h...

Open Graph Description: See #26078 (review) for context. After that, I looked up if we already have similar ineffective tests in our codebase, and I think that I found at least one. E.g. using grep -r ' catch' test/ -A 2 ...

X Description: See #26078 (review) for context. After that, I looked up if we already have similar ineffective tests in our codebase, and I think that I found at least one. E.g. using grep -r ' catch' tes...

Opengraph URL: https://github.com/nodejs/node/issues/26385

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tests: review and fix ineffective error tests","articleBody":"See https://github.com/nodejs/node/pull/26078#pullrequestreview-209542148 for context.\r\n\r\nAfter that, I looked up if we already have similar ineffective tests in our codebase, and I think that I found at least one.\r\n\r\nE.g. using `grep -r ' catch' test/ -A 2 | grep strictEqual`,  this one popped up half through the list: \r\n\r\nhttps://github.com/nodejs/node/blob/453ed053432e0c1ae34457e5c364b7091af2615e/test/parallel/test-stream-readable-async-iterators.js#L355-L361\r\n\r\nThe code above doesn't test that the error is thrown (as it likely should), instead it tests that _another_ error _doesn't_ get thrown.\r\n\r\nNote that there are a lot of false positives in the said grep (actually most matches are false positives), because e.g. this is perfectly fine:\r\nhttps://github.com/nodejs/node/blob/453ed053432e0c1ae34457e5c364b7091af2615e/test/parallel/test-vm-module-errors.js#L266-L272","author":{"url":"https://github.com/ChALkeR","@type":"Person","name":"ChALkeR"},"datePublished":"2019-03-01T23:48:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/26385/node/issues/26385"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7dfb1164-22e2-3abf-eb61-ee4e14634f86
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDC86:316DD0:42EC0E:606ED6:6A4E06B9
html-safe-nonce4e7846960863596317aa07c1540afd12b81315bc652d64d90abe6f96af247329
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzg2OjMxNkREMDo0MkVDMEU6NjA2RUQ2OjZBNEUwNkI5IiwidmlzaXRvcl9pZCI6IjQwMjg5MTA1MTkyMjYwNzQ4MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac29840d04eaf3b98902b6089a79390039bc62668efae74e6c6dcc1b3e9184ee29
hovercard-subject-tagissue:416323630
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/26385/issue_layout
twitter:imagehttps://opengraph.githubassets.com/921fb8d5d4fd5ce7204aead78dab84a0eca293b9ee493bab8419709597c38366/nodejs/node/issues/26385
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/921fb8d5d4fd5ce7204aead78dab84a0eca293b9ee493bab8419709597c38366/nodejs/node/issues/26385
og:image:altSee #26078 (review) for context. After that, I looked up if we already have similar ineffective tests in our codebase, and I think that I found at least one. E.g. using grep -r ' catch' test/ -A 2 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameChALkeR
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/26385#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F26385
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F26385
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/26385
Reloadhttps://github.com/nodejs/node/issues/26385
Reloadhttps://github.com/nodejs/node/issues/26385
Please reload this pagehttps://github.com/nodejs/node/issues/26385
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/26385
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tests: review and fix ineffective error testshttps://github.com/nodejs/node/issues/26385#top
good first issueIssues that are suitable for first-time contributors.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22
testIssues and PRs related to the tests.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test%22
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
on Mar 1, 2019https://github.com/nodejs/node/issues/26385#issue-416323630
#26078 (review)https://github.com/nodejs/node/pull/26078#pullrequestreview-209542148
node/test/parallel/test-stream-readable-async-iterators.jshttps://github.com/nodejs/node/blob/453ed053432e0c1ae34457e5c364b7091af2615e/test/parallel/test-stream-readable-async-iterators.js#L355-L361
453ed05https://github.com/nodejs/node/commit/453ed053432e0c1ae34457e5c364b7091af2615e
node/test/parallel/test-vm-module-errors.jshttps://github.com/nodejs/node/blob/453ed053432e0c1ae34457e5c364b7091af2615e/test/parallel/test-vm-module-errors.js#L266-L272
453ed05https://github.com/nodejs/node/commit/453ed053432e0c1ae34457e5c364b7091af2615e
good first issueIssues that are suitable for first-time contributors.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22
testIssues and PRs related to the tests.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.