René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Node 10.14.x Regression in parsing of binary upgrade response body","articleBody":"\u003c!--\r\nThank you for reporting a possible bug in Node.js.\r\n\r\nPlease fill in as much of the template below as you can.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify the affected core module name\r\n\r\nIf possible, please provide code that demonstrates the problem, keeping it as\r\nsimple and free of external dependencies as you can.\r\n--\u003e\r\n\r\n* **Version**: 10.14.1\r\n* **Platform**: MacOS 10.13.2\r\n* **Subsystem**: _(Docker \u003e ubuntu:xenial)_\r\n\r\nIt appears that the v10.14.x version range introduces a regression which was resolved by #17806. This gist can consistently reproduce the error: https://gist.github.com/shellscape/2020916f92be5d61f4d411fb6d2bce61\r\n\r\nNote that stepping back down to any 10.x version lower than 10.14.0 does not reproduce the error. We've spun up brand new containers to verify the issue was isolated to 10.14.x. The same containers (config) from scratch with 10.13.x are completely fine. And have verified this on three different machines (both Windows and Mac OS), in different geographic locations (U.S., Brazil, New Zealand).\r\n\r\nThis was noticed with use of the [websockets/ws](/websockets/ws) module. The immediate error stack produced:\r\n\r\n```\r\n  RangeError: Invalid WebSocket frame: RSV1 must be clear\r\n\r\n  Receiver.getInfo (node_modules/ws/lib/receiver.js:168:14)\r\n  Receiver.startLoop (node_modules/ws/lib/receiver.js:121:22)\r\n  Receiver._write (node_modules/ws/lib/receiver.js:69:10)\r\n  Socket.socketOnData (node_modules/ws/lib/websocket.js:816:35)\r\n```\r\n\r\nAnd the subsequent stack produced is:\r\n\r\n```\r\nError [ERR_STREAM_WRITE_AFTER_END]: write after end\r\n      at writeAfterEnd (_stream_writable.js:243:12)\r\n      at Socket.Writable.write (_stream_writable.js:291:5)\r\n      at Sender.sendFrame (/node_modules/ws/lib/sender.js:404:20)\r\n      at Sender.doClose (/node_modules/ws/lib/sender.js:141:10)\r\n      at Sender.close (/node_modules/ws/lib/sender.js:128:12)\r\n      at WebSocket.close (/node_modules/ws/lib/websocket.js:215:18)\r\n      at Receiver.receiverOnConclude (/node_modules/ws/lib/websocket.js:695:32)\r\n      at Receiver.emit (events.js:182:13)\r\n      at Receiver.controlMessage (/node_modules/ws/lib/receiver.js:436:14)\r\n      at Receiver.getData (/node_modules/ws/lib/receiver.js:330:42)\r\n```\r\n\r\nBoth, when traced to the best of my ability, point back to the same problem as described in #17806.","author":{"url":"https://github.com/shellscape","@type":"Person","name":"shellscape"},"datePublished":"2018-12-11T14:52:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":14},"url":"https://github.com/24958/node/issues/24958"}