Title: Misleading error message · Issue #24917 · nodejs/node · GitHub
Open Graph Title: Misleading error message · Issue #24917 · nodejs/node
X Title: Misleading error message · Issue #24917 · nodejs/node
Description: Version: v11.4.0 Platform: macOS Subsystem: assert $ cat t.js const assert = require('assert'); function StorageObject() {} StorageObject.prototype = Object.create(null); assert.deepStrictEqual(new StorageObject(), {}); $ node t.js asser...
Open Graph Description: Version: v11.4.0 Platform: macOS Subsystem: assert $ cat t.js const assert = require('assert'); function StorageObject() {} StorageObject.prototype = Object.create(null); assert.deepStrictEqual(new...
X Description: Version: v11.4.0 Platform: macOS Subsystem: assert $ cat t.js const assert = require('assert'); function StorageObject() {} StorageObject.prototype = Object.create(null); assert.deepStrictE...
Opengraph URL: https://github.com/nodejs/node/issues/24917
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Misleading error message","articleBody":"\u003c!--\r\nThank you for reporting a possible bug in Node.js.\r\n\r\nPlease fill in as much of the template below as you can.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify the affected core module name\r\n\r\nIf possible, please provide code that demonstrates the problem, keeping it as\r\nsimple and free of external dependencies as you can.\r\n--\u003e\r\n\r\n* **Version**: v11.4.0\r\n* **Platform**: macOS\r\n* **Subsystem**: assert\r\n\r\n\u003c!-- Please provide more details below this comment. --\u003e\r\n\r\n```\r\n$ cat t.js \r\nconst assert = require('assert');\r\n\r\nfunction StorageObject() {}\r\nStorageObject.prototype = Object.create(null);\r\n\r\nassert.deepStrictEqual(new StorageObject(), {});\r\n```\r\n\r\n```\r\n$ node t.js \r\nassert.js:86\r\n throw new AssertionError(obj);\r\n ^\r\n\r\nAssertionError [ERR_ASSERTION]: Values identical but not reference-equal:\r\n\r\n{}\r\n\r\n at Object.\u003canonymous\u003e (/Users/luigi/t.js:6:8)\r\n at Module._compile (internal/modules/cjs/loader.js:723:30)\r\n at Object.Module._extensions..js (internal/modules/cjs/loader.js:734:10)\r\n at Module.load (internal/modules/cjs/loader.js:620:32)\r\n at tryModuleLoad (internal/modules/cjs/loader.js:560:12)\r\n at Function.Module._load (internal/modules/cjs/loader.js:552:3)\r\n at Function.Module.runMain (internal/modules/cjs/loader.js:776:12)\r\n at executeUserCode (internal/bootstrap/node.js:342:17)\r\n at startExecution (internal/bootstrap/node.js:276:5)\r\n at startup (internal/bootstrap/node.js:227:5)\r\n```\r\n\r\nThe assertion fails because the objects have a different prototype. The same assertion produces a different message in other cases, for example:\r\n\r\n```\r\n$ cat t.js \r\nconst assert = require('assert');\r\n\r\nassert.deepStrictEqual(Object.create(null), {});\r\n```\r\n\r\n```\r\n$ node t.js \r\nassert.js:86\r\n throw new AssertionError(obj);\r\n ^\r\n\r\nAssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:\r\n+ actual - expected\r\n\r\n+ [Object: null prototype] {}\r\n- {}\r\n at Object.\u003canonymous\u003e (/Users/luigi/t.js:3:8)\r\n at Module._compile (internal/modules/cjs/loader.js:723:30)\r\n at Object.Module._extensions..js (internal/modules/cjs/loader.js:734:10)\r\n at Module.load (internal/modules/cjs/loader.js:620:32)\r\n at tryModuleLoad (internal/modules/cjs/loader.js:560:12)\r\n at Function.Module._load (internal/modules/cjs/loader.js:552:3)\r\n at Function.Module.runMain (internal/modules/cjs/loader.js:776:12)\r\n at executeUserCode (internal/bootstrap/node.js:342:17)\r\n at startExecution (internal/bootstrap/node.js:276:5)\r\n at startup (internal/bootstrap/node.js:227:5)\r\n```\r\n\r\ncc: @BridgeAR ","author":{"url":"https://github.com/lpinca","@type":"Person","name":"lpinca"},"datePublished":"2018-12-09T09:14:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/24917/node/issues/24917"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:82edb1f9-6a27-827f-cc4a-1635cb4ec1ae |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9C52:37AFAD:D11773:1191796:6A4D7EBB |
| html-safe-nonce | b5b77fb67fa1cd8bb4b7263543ca2323dd4084e6f4c4589d56bc7d2d88951691 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzUyOjM3QUZBRDpEMTE3NzM6MTE5MTc5Njo2QTREN0VCQiIsInZpc2l0b3JfaWQiOiI1MDM4OTMxOTg1MDg0Mjg0NjAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9b8c9c6f39a5ac15b974c4a467c8b2c934b526260c98745f2dc81771d4e4c402 |
| hovercard-subject-tag | issue:389002354 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/24917/issue_layout |
| twitter:image | https://opengraph.githubassets.com/deef68049132af58c6ef4800b4821ba43dfcd6d409b631a65c85d00e3dc3c551/nodejs/node/issues/24917 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/deef68049132af58c6ef4800b4821ba43dfcd6d409b631a65c85d00e3dc3c551/nodejs/node/issues/24917 |
| og:image:alt | Version: v11.4.0 Platform: macOS Subsystem: assert $ cat t.js const assert = require('assert'); function StorageObject() {} StorageObject.prototype = Object.create(null); assert.deepStrictEqual(new... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6702a58b419a792226bd21ef0fb1bcb318bbcaa3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width