René's URL Explorer Experiment


Title: Redirecting from socket hangs with large data · Issue #2323 · nodejs/node · GitHub

Open Graph Title: Redirecting from socket hangs with large data · Issue #2323 · nodejs/node

X Title: Redirecting from socket hangs with large data · Issue #2323 · nodejs/node

Description: I also posted this to nodejs bug tracker (nodejs/node-v0.x-archive#25823), but the issue is also present in iojs 3.0.0 so it felt appropriate to report it here as well I've been spending lots of time tracking this down for multer, and fo...

Open Graph Description: I also posted this to nodejs bug tracker (nodejs/node-v0.x-archive#25823), but the issue is also present in iojs 3.0.0 so it felt appropriate to report it here as well I've been spending lots of ti...

X Description: I also posted this to nodejs bug tracker (nodejs/node-v0.x-archive#25823), but the issue is also present in iojs 3.0.0 so it felt appropriate to report it here as well I've been spending lots o...

Opengraph URL: https://github.com/nodejs/node/issues/2323

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Redirecting from socket hangs with large data","articleBody":"_I also posted this to nodejs bug tracker (joyent/node#25823), but the issue is also present in iojs 3.0.0 so it felt appropriate to report it here as well_\n\nI've been spending lots of time tracking this down for [multer](https://github.com/expressjs/multer), and form-data/multipart file uploader for express. Basically what we want to do is; whenever there is an error 1) `unpipe` the request 2) `.resume()` the request so that the browser will consider the request done.\n\nThis is implemented something like the code below. `req` is an http request from a browser.\n\n``` javascript\nfunction abort (err) {\n  req.unpipe(parser)\n  req.resume()\n  next(err)\n}\n```\n\nIt has been working great, most of the times. It seems like there is a problem when the stream contains too much data. For some reason it just doesn't emit any more `data` events, and the browser is stuck on `uploading (xx%)`.\n\nI've managed to track this down and have a small test-case that is easily replicated. The problem goes all the way down to `net.Socket`.\n\nCalling `req.resume` after `socket.pipe(out2)` doesn't help.\n\nIf the size of each buffer (`560000`) is lowered it starts working. The break point on my machine is at 16 KiB, a.k.a `1024 * 16` doesn't work, but `1024 * 16 - 1` works.\n### The test case\n\n``` javascript\nvar net = require('net')\nvar stream = require('stream')\n\nvar port = 5433\nvar app = net.createServer()\n\nfunction logStream (name) {\n  var out = new stream.Writable()\n\n  out._write = function (chunk, encoding, cb) {\n    console.log('[server][' + name + '] received chunk of data')\n    this.emit('chunk-received')\n    cb(null)\n  }\n\n  return out\n}\n\napp.on('connection', function (socket) {\n  var out1 = logStream('out 1')\n  var out2 = logStream('out 2')\n\n  out1.once('chunk-received', function redirect () {\n    console.log('[server] redirecting to `out 2`')\n    socket.unpipe(out1)\n    socket.pipe(out2)\n  })\n\n  socket.pipe(out1)\n})\n\napp.listen(port, function () {\n  var socket = new net.Socket({ allowHalfOpen: true })\n\n  socket.connect(port, function () {\n    setInterval(function () {\n      socket.write(new Buffer(560000))\n    }, 100)\n  })\n})\n```\n### Actual output\n\n``` text\n[server][out 1] received chunk of data\n[server] redirecting to `out 2`\n```\n### Expected output\n\n``` text\n[server][out 1] received chunk of data\n[server] redirecting to `out 2`\n[server][out 2] received chunk of data\n[server][out 2] received chunk of data\n[server][out 2] received chunk of data\n[server][out 2] received chunk of data\n[server][out 2] received chunk of data\n[server][out 2] received chunk of data\n...\n```\n","author":{"url":"https://github.com/LinusU","@type":"Person","name":"LinusU"},"datePublished":"2015-08-07T12:01:22.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/2323/node/issues/2323"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8dd07e7e-588f-89af-b1b0-2c56736581c1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id933C:3092B8:E596E1:EAA525:6A4DC238
html-safe-noncebbad58a572a7c14764b9d35906506e969ab10d53a131bce2c6200a3bc933a53f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzNDOjMwOTJCODpFNTk2RTE6RUFBNTI1OjZBNERDMjM4IiwidmlzaXRvcl9pZCI6IjQ0MDkxMzMxODA2ODgxMjI0MjUiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmac13212e889fe11f19f60aca145764b19fb2beda1b6ed1d0bdd17828bbc69897f1
hovercard-subject-tagissue:99635368
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/2323/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dc1e11282bc30dfa3ed8c543b18a68b271b549b425306448df496b9a8f19c26c/nodejs/node/issues/2323
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc1e11282bc30dfa3ed8c543b18a68b271b549b425306448df496b9a8f19c26c/nodejs/node/issues/2323
og:image:altI also posted this to nodejs bug tracker (nodejs/node-v0.x-archive#25823), but the issue is also present in iojs 3.0.0 so it felt appropriate to report it here as well I've been spending lots of ti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLinusU
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/2323#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F2323
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F2323
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/2323
Reloadhttps://github.com/nodejs/node/issues/2323
Reloadhttps://github.com/nodejs/node/issues/2323
Please reload this pagehttps://github.com/nodejs/node/issues/2323
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/2323
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Redirecting from socket hangs with large datahttps://github.com/nodejs/node/issues/2323#top
netIssues and PRs related to the net subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22net%22
streamIssues and PRs related to the stream subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stream%22
https://github.com/LinusU
LinusUhttps://github.com/LinusU
on Aug 7, 2015https://github.com/nodejs/node/issues/2323#issue-99635368
nodejs/node-v0.x-archive#25823https://github.com/nodejs/node-v0.x-archive/issues/25823
multerhttps://github.com/expressjs/multer
netIssues and PRs related to the net subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22net%22
streamIssues and PRs related to the stream subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stream%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.