Title: Breaking change in V8 for Error.prepareStackTrace · Issue #21574 · nodejs/node · GitHub
Open Graph Title: Breaking change in V8 for Error.prepareStackTrace · Issue #21574 · nodejs/node
X Title: Breaking change in V8 for Error.prepareStackTrace · Issue #21574 · nodejs/node
Description: The proposed change (not yet landed): https://crrev.com/c/1113438 And the original related node issue: #21270 This changes formatting behavior for stack traces to use the Error.prepareStackTrace function set in the original creation cont...
Open Graph Description: The proposed change (not yet landed): https://crrev.com/c/1113438 And the original related node issue: #21270 This changes formatting behavior for stack traces to use the Error.prepareStackTrace fu...
X Description: The proposed change (not yet landed): https://crrev.com/c/1113438 And the original related node issue: #21270 This changes formatting behavior for stack traces to use the Error.prepareStackTrace fu...
Opengraph URL: https://github.com/nodejs/node/issues/21574
X: @github
Domain: github.com
IPv4 address: 140.82.114.3
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Breaking change in V8 for Error.prepareStackTrace","articleBody":"The proposed change (not yet landed): https://crrev.com/c/1113438\r\nAnd the original related node issue: https://github.com/nodejs/node/issues/21270\r\n\r\nThis changes formatting behavior for stack traces to use the `Error.prepareStackTrace` function set in the original creation context of the error object, instead of the current context.\r\n\r\nThe following node tests start failing:\r\n\r\nparallel/test-repl-pretty-custom-stack\r\nparallel/test-repl-pretty-stack\r\nparallel/test-repl-underscore\r\n\r\nFailures look similar to:\r\n\r\n```\r\n AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:\r\n + expected - actual\r\n \r\n - ' at repl:1:18'\r\n + 'Error: foo'\r\n at Immediate.setImmediate (/b/swarming/w/ir/cache/builder/v8_node_linux64_rel/node.js/test/parallel/test-repl-underscore.js:200:16)\r\n at runCallback (timers.js:695:18)\r\n at tryOnImmediate (timers.js:666:5)\r\n at processImmediate (timers.js:648:5)\r\n at process.topLevelDomainCallback (domain.js:121:23)\r\n```\r\n\r\nFull test run logs: https://logs.chromium.org/v/?s=v8%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942571998063714288%2F%2B%2Fsteps%2Frun_tests%2F0%2Fstdout\r\n\r\nPresumably this happens because custom stack formatting is set in one context but not another.\r\n\r\nCan this reasonably be fixed in node?","author":{"url":"https://github.com/schuay","@type":"Person","name":"schuay"},"datePublished":"2018-06-28T06:58:55Z","url":"https://github.com/nodejs/node/issues/21574"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:14e0e44c-5fa9-e223-ae62-e2c80e31413d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DC9A:122379:26C232:313B0C:6B033FFF |
| html-safe-nonce | d3f09845272b682283a1fb83899e3d338a381ddb76b5bd7bad0e58bc44546240 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzlBOjEyMjM3OToyNkMyMzI6MzEzQjBDOjZCMDMzRkZGIiwidmlzaXRvcl9pZCI6IjIwMzk2ODQ5ODcxODc1NzY4MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0f592aba0c519f6159dcdd6b724d0eb7a54e3ada644bb8c6bd5463dff71cd740 |
| hovercard-subject-tag | issue:336496649 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/21574/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2cc10d7a8ba9a11ca39ebe5ccf0fa24a60651484c3d616c5d30950d27704e29c/nodejs/node/issues/21574 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2cc10d7a8ba9a11ca39ebe5ccf0fa24a60651484c3d616c5d30950d27704e29c/nodejs/node/issues/21574 |
| og:image:alt | The proposed change (not yet landed): https://crrev.com/c/1113438 And the original related node issue: #21270 This changes formatting behavior for stack traces to use the Error.prepareStackTrace fu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | schuay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width