René's URL Explorer Experiment


Title: vm: Error.prepareStackTrace behaves inconsistently across versions · Issue #21270 · nodejs/node · GitHub

Open Graph Title: vm: Error.prepareStackTrace behaves inconsistently across versions · Issue #21270 · nodejs/node

X Title: vm: Error.prepareStackTrace behaves inconsistently across versions · Issue #21270 · nodejs/node

Description: Version: 8.11.2 Platform: Linux 4.16.4-1-ARCH Subsystem: vm In Node 6.x (tested on v6.14.2), the following results in the prepareStackTrace defined inside the context being used: const { runInNewContext } = require('vm'); console.log(run...

Open Graph Description: Version: 8.11.2 Platform: Linux 4.16.4-1-ARCH Subsystem: vm In Node 6.x (tested on v6.14.2), the following results in the prepareStackTrace defined inside the context being used: const { runInNewCo...

X Description: Version: 8.11.2 Platform: Linux 4.16.4-1-ARCH Subsystem: vm In Node 6.x (tested on v6.14.2), the following results in the prepareStackTrace defined inside the context being used: const { runInNewCo...

Opengraph URL: https://github.com/nodejs/node/issues/21270

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"vm: Error.prepareStackTrace behaves inconsistently across versions","articleBody":"* **Version**: 8.11.2\r\n* **Platform**: Linux 4.16.4-1-ARCH\r\n* **Subsystem**: vm\r\n\r\nIn Node 6.x (tested on v6.14.2), the following results in the `prepareStackTrace` defined inside the context being used:\r\n\r\n```js\r\nconst { runInNewContext } = require('vm');\r\nconsole.log(runInNewContext(`() => {\r\n  Error.prepareStackTrace = () => 'hello';\r\n  return new Error();\r\n}`)().stack);\r\n```\r\nThe stack is logged as `hello`.\r\n\r\nIn Node 8.x (tested with 8.11.2), it will just output a normal stack, ignoring the `prepareStackTrace` defined in the context.\r\n\r\nIt seems that in Node 8, the `prepareStackTrace` from the currently running context (i.e. the one where `.stack` is called) is used, whereas in Node 6, the one where the Error was instantiated is used.\r\n\r\nNote that this only happens when the Error is passed along, and *not* when it's a thrown exception. I suspect that's because when it's thrown, `DecorateErrorStack` is run, which gets the stack before it's passed to the main context:\r\n\r\nhttps://github.com/nodejs/node/blob/faf417ba12024a24906fbeb38edeec78256a1c09/src/node_contextify.cc#L735-L747\r\n\r\nNote also that when the stack is retrieved inside the new context, the in-context `prepareStackTrace` is always used, regardless of version.\r\n\r\n","author":{"url":"https://github.com/bengl","@type":"Person","name":"bengl"},"datePublished":"2018-06-11T21:14:00Z","url":"https://github.com/nodejs/node/issues/21270"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:aad7a61b-eb62-3768-486c-b667a3ec7a5d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8B1C:C397B:31F61C:3FC9B7:6B03436E
html-safe-nonced41ded3cb07a82e51e5eb55f1ec974dc6753f9d9b2f1a88056baea5decc910ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjFDOkMzOTdCOjMxRjYxQzozRkM5Qjc6NkIwMzQzNkUiLCJ2aXNpdG9yX2lkIjoiNzE4ODA5MTk3MTcxNjcyNzY2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca8756a5cd06bf0d576d94c4555f0de712b69c3524afff6e77a008cc998219f87
hovercard-subject-tagissue:331352697
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/21270/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f92b0ce951dba441b8441680e6d718b78c35dfd6664b11df698c519029e62e12/nodejs/node/issues/21270
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f92b0ce951dba441b8441680e6d718b78c35dfd6664b11df698c519029e62e12/nodejs/node/issues/21270
og:image:altVersion: 8.11.2 Platform: Linux 4.16.4-1-ARCH Subsystem: vm In Node 6.x (tested on v6.14.2), the following results in the prepareStackTrace defined inside the context being used: const { runInNewCo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebengl
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/21270#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F21270
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F21270
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/21270
Reloadhttps://github.com/nodejs/node/issues/21270
Reloadhttps://github.com/nodejs/node/issues/21270
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/21270
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/21270
vm: Error.prepareStackTrace behaves inconsistently across versionshttps://github.com/nodejs/node/issues/21270#top
vmIssues and PRs related to the vm subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22vm%22
https://github.com/bengl
benglhttps://github.com/bengl
on Jun 11, 2018https://github.com/nodejs/node/issues/21270#issue-331352697
node/src/node_contextify.cchttps://github.com/nodejs/node/blob/faf417ba12024a24906fbeb38edeec78256a1c09/src/node_contextify.cc#L735-L747
faf417bhttps://github.com/nodejs/node/commit/faf417ba12024a24906fbeb38edeec78256a1c09
https://github.com/targos
targoshttps://github.com/targos
on Jun 11, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396389940
https://github.com/devsnek
devsnekhttps://github.com/devsnek
on Jun 11, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396390347
https://github.com/bengl
benglhttps://github.com/bengl
on Jun 11, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396390551
@targoshttps://github.com/targos
https://github.com/hashseed
hashseedhttps://github.com/hashseed
on Jun 12, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396599293
@schuayhttps://github.com/schuay
https://github.com/devsnek
devsnekhttps://github.com/devsnek
on Jun 12, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396601134
@hashseedhttps://github.com/hashseed
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
on Jun 12, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396615050
https://github.com/devsnek
devsnekhttps://github.com/devsnek
on Jun 12, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396616147
@jdaltonhttps://github.com/jdalton
tc39/proposal-error-stacks#20 (comment)https://github.com/tc39/proposal-error-stacks/issues/20#issuecomment-379596718
https://github.com/hashseed
hashseedhttps://github.com/hashseed
on Jun 13, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396879744
https://github.com/schuay
schuayhttps://github.com/schuay
on Jun 13, 2018https://github.com/nodejs/node/issues/21270#issuecomment-396896043
codehttps://cs.chromium.org/chromium/src/v8/src/messages.cc?l=961&rcl=a0f868823ab0b4ac598bcb43a8858d79328ddb5a
https://crbug.com/v8/7848https://crbug.com/v8/7848
https://github.com/Trott
Trotthttps://github.com/Trott
on Oct 26, 2018https://github.com/nodejs/node/issues/21270#issuecomment-433274385
https://github.com/devsnek
devsnekhttps://github.com/devsnek
on Oct 26, 2018https://github.com/nodejs/node/issues/21270#issuecomment-433274724
https://github.com/Trott
Trotthttps://github.com/Trott
on Oct 26, 2018https://github.com/nodejs/node/issues/21270#issuecomment-433275151
Trotthttps://github.com/Trott
vmIssues and PRs related to the vm subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22vm%22
blockedPRs that are blocked by other issues or PRs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22blocked%22
blockedPRs that are blocked by other issues or PRs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22blocked%22
on Mar 30, 2019https://github.com/nodejs/node/issues/21270#event-2241266403
https://github.com/Trott
Trotthttps://github.com/Trott
on Oct 3, 2019https://github.com/nodejs/node/issues/21270#issuecomment-537757886
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
on Jan 4, 2020https://github.com/nodejs/node/issues/21270#issuecomment-570751112
BridgeARhttps://github.com/BridgeAR
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 4, 2020https://github.com/nodejs/node/issues/21270#event-2921623353
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/21270
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/21270
vmIssues and PRs related to the vm subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22vm%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.