René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Closing fs streams early could call close during or before I/O","articleBody":"Suppose you `fs.createWriteStream`, pipe something into it, and then need to close the stream early because of an error somewhere else.\n\n``` javascript\nvar writeStream = fs.createWriteStream(someFile);\nsource.pipe(writeStream);\n\n// ...time passes...\n\nsource.unpipe(writeStream);\nwriteStream.close();\n```\n\nCalling `close` on the write stream in this case could cause `close` to be called on the underlying file descriptor while a write operation is still pending. Or, if more than one worker thread is being used, it's possible for the `close` to happen before the write begins.\n\nSpecifically, `WriteStream.close` does not check whether a `fs.write` operation is pending before calling `fs.close`:\n\nhttps://github.com/nodejs/io.js/blob/41951d45b6df789d7e9cf134f0029b0e791706c4/lib/fs.js#L1770\n\nIt seems like this makes it impossible to safely close a write stream early. I've never seen bad behavior from this in practice though, so maybe I'm misunderstanding something.\n\nAre we instead supposed to call `Writable.end` and should never use `WriteStream.close`?\n","author":{"url":"https://github.com/briangreenery","@type":"Person","name":"briangreenery"},"datePublished":"2015-06-18T02:59:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":25},"url":"https://github.com/2006/node/issues/2006"}