Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node · GitHub
Open Graph Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node
X Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node
Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Hash, limited key-generation, SecureContex...
Open Graph Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Ha...
X Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verifica...
Opengraph URL: https://github.com/nodejs/node/issues/16524
X: @github
Domain: github.com
IPv4 address: 140.82.113.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proposal: Splitting up node_crypto.cc","articleBody":"The `src/node_crypto.cc` file is currently 6k+ lines of code that provides `process.binding('crypto')`. This one internal binding provides an array of crypto functions include Signing, Verification, Hash, limited key-generation, SecureContext for TLS connections, etc. As such, this one file has a LOT of code in it and it is quite difficult from a maintenance perspective.\r\n\r\nLooking it over, I'd like to refactor both the source files and the `process.binding()` for crypto such that each individual subcomponent of `node_crypto.cc` is moved to it's own `src/node_crypto_nnnn.cc` file with it's own distinct `process.binding('crypto-nnnn')`. This will make it easier for us to maintain and update individual pieces of the code.\r\n\r\nThis would be a fairly large and time consuming refactoring so I wanted to make sure that folks are on board with it before I started down that path.\r\n\r\nFWIW, there are two efforts prompting this:\r\n\r\n1. The migration to internal/errors and the pain involved with digging through this file to do so\r\n2. The investigation of promises support for the crypto module","author":{"url":"https://github.com/jasnell","@type":"Person","name":"jasnell"},"datePublished":"2017-10-26T18:21:48Z","url":"https://github.com/nodejs/node/issues/16524"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e12a5141-dba7-3ade-0940-50537905b9d2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CBC0:137FF:32F418:40BC73:6B034373 |
| html-safe-nonce | 2e42d28b20e57070f73d33ab9e6ac7005f6f3298bb32b6875d7fb491bfea1db6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkMwOjEzN0ZGOjMyRjQxODo0MEJDNzM6NkIwMzQzNzMiLCJ2aXNpdG9yX2lkIjoiODE1OTk0MDI0NDk4OTQ5NDEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e8c44d134aaf9d8afc6c3c86c7737644c13cedd8903b2b61119904ee82ee1ed5 |
| hovercard-subject-tag | issue:268861557 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/16524/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dd2cb7e80317b035266fb566bcb365dce04f68d40948506dad3b2109ec788000/nodejs/node/issues/16524 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dd2cb7e80317b035266fb566bcb365dce04f68d40948506dad3b2109ec788000/nodejs/node/issues/16524 |
| og:image:alt | The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Ha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width