René's URL Explorer Experiment


Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node · GitHub

Open Graph Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node

X Title: Proposal: Splitting up node_crypto.cc · Issue #16524 · nodejs/node

Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Hash, limited key-generation, SecureContex...

Open Graph Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Ha...

X Description: The src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verifica...

Opengraph URL: https://github.com/nodejs/node/issues/16524

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.4


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proposal: Splitting up node_crypto.cc","articleBody":"The `src/node_crypto.cc` file is currently 6k+ lines of code that provides `process.binding('crypto')`. This one internal binding provides an array of crypto functions include Signing, Verification, Hash, limited key-generation, SecureContext for TLS connections, etc. As such, this one file has a LOT of code in it and it is quite difficult from a maintenance perspective.\r\n\r\nLooking it over, I'd like to refactor both the source files and the `process.binding()` for crypto such that each individual subcomponent of `node_crypto.cc` is moved to it's own `src/node_crypto_nnnn.cc` file with it's own distinct `process.binding('crypto-nnnn')`. This will make it easier for us to maintain and update individual pieces of the code.\r\n\r\nThis would be a fairly large and time consuming refactoring so I wanted to make sure that folks are on board with it before I started down that path.\r\n\r\nFWIW, there are two efforts prompting this:\r\n\r\n1. The migration to internal/errors and the pain involved with digging through this file to do so\r\n2. The investigation of promises support for the crypto module","author":{"url":"https://github.com/jasnell","@type":"Person","name":"jasnell"},"datePublished":"2017-10-26T18:21:48Z","url":"https://github.com/nodejs/node/issues/16524"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e12a5141-dba7-3ade-0940-50537905b9d2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCBC0:137FF:32F418:40BC73:6B034373
html-safe-nonce2e42d28b20e57070f73d33ab9e6ac7005f6f3298bb32b6875d7fb491bfea1db6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkMwOjEzN0ZGOjMyRjQxODo0MEJDNzM6NkIwMzQzNzMiLCJ2aXNpdG9yX2lkIjoiODE1OTk0MDI0NDk4OTQ5NDEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace8c44d134aaf9d8afc6c3c86c7737644c13cedd8903b2b61119904ee82ee1ed5
hovercard-subject-tagissue:268861557
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/16524/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dd2cb7e80317b035266fb566bcb365dce04f68d40948506dad3b2109ec788000/nodejs/node/issues/16524
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd2cb7e80317b035266fb566bcb365dce04f68d40948506dad3b2109ec788000/nodejs/node/issues/16524
og:image:altThe src/node_crypto.cc file is currently 6k+ lines of code that provides process.binding('crypto'). This one internal binding provides an array of crypto functions include Signing, Verification, Ha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/16524#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F16524
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F16524
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/16524
Reloadhttps://github.com/nodejs/node/issues/16524
Reloadhttps://github.com/nodejs/node/issues/16524
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/16524
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/16524
Proposal: Splitting up node_crypto.cchttps://github.com/nodejs/node/issues/16524#top
cryptoIssues and PRs related to the crypto subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22crypto%22
https://github.com/jasnell
jasnellhttps://github.com/jasnell
on Oct 26, 2017https://github.com/nodejs/node/issues/16524#issue-268861557
jasnellhttps://github.com/jasnell
cryptoIssues and PRs related to the crypto subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22crypto%22
on Oct 26, 2017https://github.com/nodejs/node/issues/16524#event-1312552413
https://github.com/jasnell
jasnellhttps://github.com/jasnell
on Oct 26, 2017https://github.com/nodejs/node/issues/16524#issuecomment-339754904
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
on Oct 27, 2017https://github.com/nodejs/node/issues/16524#issuecomment-339886931
https://github.com/tniessen
tniessenhttps://github.com/tniessen
on Oct 27, 2017https://github.com/nodejs/node/issues/16524#issuecomment-339956654
jasnellhttps://github.com/jasnell
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 29, 2018https://github.com/nodejs/node/issues/16524#event-1709131814
https://github.com/tniessen
tniessenhttps://github.com/tniessen
on Jul 2, 2018https://github.com/nodejs/node/issues/16524#issuecomment-401722544
@jasnellhttps://github.com/jasnell
@ryzokukenhttps://github.com/ryzokuken
#21288 (review)https://github.com/nodejs/node/pull/21288#pullrequestreview-133461321
https://github.com/jasnell
jasnellhttps://github.com/jasnell
on Jul 2, 2018https://github.com/nodejs/node/issues/16524#issuecomment-401798338
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
on Jul 2, 2018https://github.com/nodejs/node/issues/16524#issuecomment-401859170
@jasnellhttps://github.com/jasnell
@tniessenhttps://github.com/tniessen
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/16524
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/16524
cryptoIssues and PRs related to the crypto subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22crypto%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.