René's URL Explorer Experiment


Title: stream: fix _final and 'prefinish' timing · nodejs/node@ea87809 · GitHub

Open Graph Title: stream: fix _final and 'prefinish' timing · nodejs/node@ea87809

X Title: stream: fix _final and 'prefinish' timing · nodejs/node@ea87809

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In on case the event is emitted synchronously with end() and otherwise asynchro...

X Description: This PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In on case the event is emitted synchronously with end() and otherwise ...

Opengraph URL: /nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/commit/:name(/*path)
route-controllercommit
route-actionshow
fetch-noncev2:a3c083f1-b852-d14a-cea9-b3dc0f86072c
current-catalog-service-hashf3abb0cc802f3d7b95fc8762b94bdcb13bf39634c40c357301c4aa1d67a256fb
request-idE01C:30E6E5:1E8F9DE:29B1520:696AC505
html-safe-noncef1167c727606aa0c95e692a76f7485fa6fb9317ba31880accda527817cbc42e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDFDOjMwRTZFNToxRThGOURFOjI5QjE1MjA6Njk2QUM1MDUiLCJ2aXNpdG9yX2lkIjoiMzMzMTIzNjE0MzMxODA5MTAxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbc1606a1749fac17349658b4599e6f8d9b6b1eaa3bd1f6a6ec98a11b976effb8
hovercard-subject-tagrepository:27193779
github-keyboard-shortcutsrepository,commits,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///commit/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/commit/ea87809bb6
twitter:imagehttps://opengraph.githubassets.com/237f50da8b1e22d60d8879620eb0eb84cb87f08e943d7c0894dfc1bfa361fde4/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/237f50da8b1e22d60d8879620eb0eb84cb87f08e943d7c0894dfc1bfa361fde4/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183
og:image:altThis PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In on case the event is emitted synchronously with end() and otherwise asynchro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:updated_time1587541203
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/commit/ea87809bb6#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fea87809bb6
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fea87809bb6
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fcommit%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/commit/ea87809bb6
Reloadhttps://github.com/nodejs/node/commit/ea87809bb6
Reloadhttps://github.com/nodejs/node/commit/ea87809bb6
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/commit/ea87809bb6
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/commit/ea87809bb6
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Browse fileshttps://github.com/nodejs/node/tree/ea87809bb6696e2c1ec5d470031f137e18641183
https://github.com/nodejs/node/tree/ea87809bb6696e2c1ec5d470031f137e18641183
https://github.com/ronag
ronaghttps://github.com/nodejs/node/commits?author=ronag
#31401https://github.com/nodejs/node/issues/31401
#32763 (comment)https://github.com/nodejs/node/pull/32763#discussion_r407041983
#32780https://github.com/nodejs/node/pull/32780
d08bd41https://github.com/nodejs/node/commit/d08bd412481de12a846a9ee8ad96bd2aefb602b5
_stream_transform.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367
_stream_writable.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
core.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
test-stream-transform-final-sync.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-ccb3ff94896f7e3c3fa354fbb0ff292d2aa7ce790cf04e3f00f8b54f550aabb9
test-stream-transform-final.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-3762b8b8ee068deefb1dcff15a42cdd720daca1074c4210e95f43d6c43cdeeea
test-stream-writable-finished.jshttps://github.com/nodejs/node/commit/ea87809bb6#diff-23df7c4aa05a9663db7bbdcae0084d1ad997063b33fda7969bcb6247265443b3
‎lib/_stream_transform.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367
‎lib/_stream_writable.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
‎lib/internal/http2/core.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
‎test/parallel/test-stream-transform-final-sync.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-ccb3ff94896f7e3c3fa354fbb0ff292d2aa7ce790cf04e3f00f8b54f550aabb9
‎test/parallel/test-stream-transform-final.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-3762b8b8ee068deefb1dcff15a42cdd720daca1074c4210e95f43d6c43cdeeea
‎test/parallel/test-stream-writable-finished.js‎https://github.com/nodejs/node/commit/ea87809bb6#diff-23df7c4aa05a9663db7bbdcae0084d1ad997063b33fda7969bcb6247265443b3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.