René's URL Explorer Experiment


Title: src: avoid OOB read in URL parser · nodejs/node@a8824ae · GitHub

Open Graph Title: src: avoid OOB read in URL parser · nodejs/node@a8824ae

X Title: src: avoid OOB read in URL parser · nodejs/node@a8824ae

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https:/...

X Description: This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL:...

Opengraph URL: /nodejs/node/commit/a8824ae0a50f470a3e9fea86e5bab2c831c05520

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/commit/:name(/*path)
route-controllercommit
route-actionshow
fetch-noncev2:914694af-aec1-f86a-9373-818f1cdb6ab1
current-catalog-service-hashf3abb0cc802f3d7b95fc8762b94bdcb13bf39634c40c357301c4aa1d67a256fb
request-idC1BC:2A6D10:C36A74:FB264B:696AFE59
html-safe-nonce79a849f9e9f09774e42227df3a70d9311f805cd38d7694cdbe1970a57fbd6328
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUJDOjJBNkQxMDpDMzZBNzQ6RkIyNjRCOjY5NkFGRTU5IiwidmlzaXRvcl9pZCI6Ijg5OTI0MTA2MDE3Nzc3MjUwMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac53e96fcb844021e59860dbdfbb1bacf7f4e4f857de2eab944694e807a72daf90
hovercard-subject-tagrepository:27193779
github-keyboard-shortcutsrepository,commits,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///commit/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/commit/a8824ae0a5
twitter:imagehttps://opengraph.githubassets.com/91d3884adcf0c7fe0501d630de54c13200b15fe8cb6d7d195e83dab65388dfb1/nodejs/node/commit/a8824ae0a50f470a3e9fea86e5bab2c831c05520
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/91d3884adcf0c7fe0501d630de54c13200b15fe8cb6d7d195e83dab65388dfb1/nodejs/node/commit/a8824ae0a50f470a3e9fea86e5bab2c831c05520
og:image:altThis is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https:/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:updated_time1592499263
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/commit/a8824ae0a5#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fa8824ae0a5
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fa8824ae0a5
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fcommit%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/commit/a8824ae0a5
Reloadhttps://github.com/nodejs/node/commit/a8824ae0a5
Reloadhttps://github.com/nodejs/node/commit/a8824ae0a5
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/commit/a8824ae0a5
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/commit/a8824ae0a5
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Browse fileshttps://github.com/nodejs/node/tree/a8824ae0a50f470a3e9fea86e5bab2c831c05520
https://github.com/nodejs/node/tree/a8824ae0a50f470a3e9fea86e5bab2c831c05520
addaleaxhttps://github.com/nodejs/node/commits?author=addaleax
codebyterehttps://github.com/nodejs/node/commits?author=codebytere
#33640https://github.com/nodejs/node/pull/33640
27c90efhttps://github.com/nodejs/node/commit/27c90efce06061c62919ba20227902331c0c4ac3
node_url.cchttps://github.com/nodejs/node/commit/a8824ae0a5#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
test_url.cchttps://github.com/nodejs/node/commit/a8824ae0a5#diff-af31e429f6c30982465941697814df205ef8450f8c0c7d0d7db64368a8b4978e
‎src/node_url.cc‎https://github.com/nodejs/node/commit/a8824ae0a5#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
‎test/cctest/test_url.cc‎https://github.com/nodejs/node/commit/a8824ae0a5#diff-af31e429f6c30982465941697814df205ef8450f8c0c7d0d7db64368a8b4978e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.