René's URL Explorer Experiment


Title: test: fix warnings in addon tests · nodejs/node@840a2ea · GitHub

Open Graph Title: test: fix warnings in addon tests · nodejs/node@840a2ea

X Title: test: fix warnings in addon tests · nodejs/node@840a2ea

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The legacy MakeCallback deprecation was resulting in compile time warnings in adddon tests. Fix them. Ref: https://github.com/nodejs/node/pull/18632 PR-URL: https://github.com/nodejs/node/pull/18...

X Description: The legacy MakeCallback deprecation was resulting in compile time warnings in adddon tests. Fix them. Ref: https://github.com/nodejs/node/pull/18632 PR-URL: https://github.com/nodejs/node/pull/18...

Opengraph URL: /nodejs/node/commit/840a2ea8e3b44b31443264935c1b83b8516f69ac

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/commit/:name(/*path)
route-controllercommit
route-actionshow
fetch-noncev2:fda90c1b-1bc5-536b-a3ce-183dc1dc0b29
current-catalog-service-hashf3abb0cc802f3d7b95fc8762b94bdcb13bf39634c40c357301c4aa1d67a256fb
request-id8348:320F8E:272D509:34DF82D:696ADE9C
html-safe-nonce1ba2229c60b816225e4183cecd4cd3f0ec12c02e3acac374e2a41ccbd8cd57fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzQ4OjMyMEY4RToyNzJENTA5OjM0REY4MkQ6Njk2QURFOUMiLCJ2aXNpdG9yX2lkIjoiMjQ1MjA3OTg2ODY5MDM0NjUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7b12cce0f29794c4340d75968cdb97cf6c8a54a21d9e368a8b4c9501741a01dc
hovercard-subject-tagrepository:27193779
github-keyboard-shortcutsrepository,commits,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///commit/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/commit/840a2ea8e3
twitter:imagehttps://opengraph.githubassets.com/78b9ec07712040f7b3382dba440de4ec1dccaf77fb6634165c104deb30349132/nodejs/node/commit/840a2ea8e3b44b31443264935c1b83b8516f69ac
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78b9ec07712040f7b3382dba440de4ec1dccaf77fb6634165c104deb30349132/nodejs/node/commit/840a2ea8e3b44b31443264935c1b83b8516f69ac
og:image:altThe legacy MakeCallback deprecation was resulting in compile time warnings in adddon tests. Fix them. Ref: https://github.com/nodejs/node/pull/18632 PR-URL: https://github.com/nodejs/node/pull/18...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:updated_time1519240835
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/commit/840a2ea8e3#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2F840a2ea8e3
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2F840a2ea8e3
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fcommit%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/commit/840a2ea8e3
Reloadhttps://github.com/nodejs/node/commit/840a2ea8e3
Reloadhttps://github.com/nodejs/node/commit/840a2ea8e3
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/commit/840a2ea8e3
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/commit/840a2ea8e3
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Browse fileshttps://github.com/nodejs/node/tree/840a2ea8e3b44b31443264935c1b83b8516f69ac
https://github.com/nodejs/node/tree/840a2ea8e3b44b31443264935c1b83b8516f69ac
ofrobotshttps://github.com/nodejs/node/commits?author=ofrobots
MylesBorinshttps://github.com/nodejs/node/commits?author=MylesBorins
#18632https://github.com/nodejs/node/pull/18632
#18810https://github.com/nodejs/node/pull/18810
#18632https://github.com/nodejs/node/pull/18632
eb9d0bahttps://github.com/nodejs/node/commit/eb9d0bacb8866533444fcf8c874ff4e2f20c63e5
binding.cchttps://github.com/nodejs/node/commit/840a2ea8e3#diff-b73c9e2af3edaab0f15de47b50b3bb6cb25b794f5e8cabd26407b327b9e0d407
binding.cchttps://github.com/nodejs/node/commit/840a2ea8e3#diff-6d920a51c7a993ce139c8ed22dc90ce55d641ed0e89ea2bb568d53604582be20
binding.cchttps://github.com/nodejs/node/commit/840a2ea8e3#diff-a924184ae13dc1d712eb05ab652e64e46a52b42035e534aceb72036ad03bc131
binding.cchttps://github.com/nodejs/node/commit/840a2ea8e3#diff-fff177186d9ff39eccee65756dee7664fd110f4430a564bcd8d6b62840696891
binding.cchttps://github.com/nodejs/node/commit/840a2ea8e3#diff-e525a8cf9061164e8ef0c13447bf040198418e3a8070e0dda750ad947dfa5de4
‎test/addons/async-hello-world/binding.cc‎https://github.com/nodejs/node/commit/840a2ea8e3#diff-b73c9e2af3edaab0f15de47b50b3bb6cb25b794f5e8cabd26407b327b9e0d407
‎test/addons/callback-scope/binding.cc‎https://github.com/nodejs/node/commit/840a2ea8e3#diff-6d920a51c7a993ce139c8ed22dc90ce55d641ed0e89ea2bb568d53604582be20
‎test/addons/make-callback-recurse/binding.cc‎https://github.com/nodejs/node/commit/840a2ea8e3#diff-a924184ae13dc1d712eb05ab652e64e46a52b42035e534aceb72036ad03bc131
‎test/addons/make-callback/binding.cc‎https://github.com/nodejs/node/commit/840a2ea8e3#diff-fff177186d9ff39eccee65756dee7664fd110f4430a564bcd8d6b62840696891
‎test/addons/repl-domain-abort/binding.cc‎https://github.com/nodejs/node/commit/840a2ea8e3#diff-e525a8cf9061164e8ef0c13447bf040198418e3a8070e0dda750ad947dfa5de4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.