René's URL Explorer Experiment


Title: stream: don't push null from closed promise #42694 · nodejs/node@1655532 · GitHub

Open Graph Title: stream: don't push null from closed promise #42694 · nodejs/node@1655532

X Title: stream: don't push null from closed promise #42694 · nodejs/node@1655532

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: closed promise is subscribed to first so will be resolved first, before any read promise. This causes data after EOF error to be thrown. Remove the push null from the closed promise handler. The ...

X Description: closed promise is subscribed to first so will be resolved first, before any read promise. This causes data after EOF error to be thrown. Remove the push null from the closed promise handler. The ...

Opengraph URL: /nodejs/node/commit/1655532fd2af74d930643b44963975632203aabf

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/commit/:name(/*path)
route-controllercommit
route-actionshow
fetch-noncev2:e36a9d7c-6199-5c23-56a5-c1be97cfef7a
current-catalog-service-hashf3abb0cc802f3d7b95fc8762b94bdcb13bf39634c40c357301c4aa1d67a256fb
request-idC522:356387:7D14B:A1027:696AFBE2
html-safe-noncec52207de86664add326d3c11e4c6c8447bcb12f37a393feac775ac5c289a3ff4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTIyOjM1NjM4Nzo3RDE0QjpBMTAyNzo2OTZBRkJFMiIsInZpc2l0b3JfaWQiOiI2MTY5MjYxOTc4ODc5MTk2MTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaca4676179ef6be3aa6b3dca967df519e7c3186595abc965bd56f71e90f3e0ef
hovercard-subject-tagrepository:27193779
github-keyboard-shortcutsrepository,commits,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///commit/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/commit/1655532fd2
twitter:imagehttps://opengraph.githubassets.com/f03d928a64ab8d337563e6dc8c21a1f942521e76b86b537e3485c12eac37b99a/nodejs/node/commit/1655532fd2af74d930643b44963975632203aabf
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f03d928a64ab8d337563e6dc8c21a1f942521e76b86b537e3485c12eac37b99a/nodejs/node/commit/1655532fd2af74d930643b44963975632203aabf
og:image:altclosed promise is subscribed to first so will be resolved first, before any read promise. This causes data after EOF error to be thrown. Remove the push null from the closed promise handler. The ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:updated_time1668084178
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/commit/1655532fd2#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2F1655532fd2
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2F1655532fd2
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fcommit%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/commit/1655532fd2
Reloadhttps://github.com/nodejs/node/commit/1655532fd2
Reloadhttps://github.com/nodejs/node/commit/1655532fd2
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/commit/1655532fd2
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/commit/1655532fd2
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Browse fileshttps://github.com/nodejs/node/tree/1655532fd2af74d930643b44963975632203aabf
https://github.com/nodejs/node/tree/1655532fd2af74d930643b44963975632203aabf
davedoesdevhttps://github.com/nodejs/node/commits?author=davedoesdev
RafaelGSShttps://github.com/nodejs/node/commits?author=RafaelGSS
#42694https://github.com/nodejs/node/issues/42694
#45026https://github.com/nodejs/node/pull/45026
#42694https://github.com/nodejs/node/issues/42694
809e8dchttps://github.com/nodejs/node/commit/809e8dcbd221ff639990c8398439795b0b5c0855
adapters.jshttps://github.com/nodejs/node/commit/1655532fd2#diff-43e358c7bb606a04e17d203d22de7c9d318786c44b34a98523514cce0691c265
test-readable-from-web-enqueue-then-close.jshttps://github.com/nodejs/node/commit/1655532fd2#diff-5d3c4ddd7d070c49285ab1c5c086e87978e5edf01f98a0787d63948d74d48974
‎lib/internal/webstreams/adapters.js‎https://github.com/nodejs/node/commit/1655532fd2#diff-43e358c7bb606a04e17d203d22de7c9d318786c44b34a98523514cce0691c265
‎test/parallel/test-readable-from-web-enqueue-then-close.js‎https://github.com/nodejs/node/commit/1655532fd2#diff-5d3c4ddd7d070c49285ab1c5c086e87978e5edf01f98a0787d63948d74d48974
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.