René's URL Explorer Experiment


Title: fix: use proper return value check for EVP_CIPHER_CTX_ctrl() by ndossche · Pull Request #36 · nodejs/ncrypto · GitHub

Open Graph Title: fix: use proper return value check for EVP_CIPHER_CTX_ctrl() by ndossche · Pull Request #36 · nodejs/ncrypto

X Title: fix: use proper return value check for EVP_CIPHER_CTX_ctrl() by ndossche · Pull Request #36 · nodejs/ncrypto

Description: Library supporting OpenSSL and crypto functions for node:crypto - fix: use proper return value check for EVP_CIPHER_CTX_ctrl() by ndossche · Pull Request #36 · nodejs/ncrypto

Open Graph Description: This function can theoretically return -1, which would then be converted to a truthy value. If this happens, then this can cause issues at the use sites. E.g. for the test-crypto-cipheriv-decipheri...

X Description: This function can theoretically return -1, which would then be converted to a truthy value. If this happens, then this can cause issues at the use sites. E.g. for the test-crypto-cipheriv-decipheri...

Opengraph URL: https://github.com/nodejs/ncrypto/pull/36

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d5ad9f28-3819-3e9c-8552-987451b340f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3B4:2630A2:2DC08DE:40CB678:6A4D008A
html-safe-nonceb0b0ddb7f45839f4b326d2b7a04e162791468d5dc9a8c86f90887c523007cc56
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0I0OjI2MzBBMjoyREMwOERFOjQwQ0I2Nzg6NkE0RDAwOEEiLCJ2aXNpdG9yX2lkIjoiODY4NDI5NzEwODMzNTY4OTg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a6befe3cf3c1cb594d6c92f186451ed5861117a45048fca5cfc3691d1d98c24
hovercard-subject-tagpull_request:3289843298
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/ncrypto/36/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/40d42a99aea4bc90676b4b9d5d2f1e3900d2ea56d8bcef5329277b58a663370a/nodejs/ncrypto/pull/36
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/40d42a99aea4bc90676b4b9d5d2f1e3900d2ea56d8bcef5329277b58a663370a/nodejs/ncrypto/pull/36
og:image:altThis function can theoretically return -1, which would then be converted to a truthy value. If this happens, then this can cause issues at the use sites. E.g. for the test-crypto-cipheriv-decipheri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamendossche
hostnamegithub.com
expected-hostnamegithub.com
None31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5
turbo-cache-controlno-cache
go-importgithub.com/nodejs/ncrypto git https://github.com/nodejs/ncrypto.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id920773897
octolytics-dimension-repository_nwonodejs/ncrypto
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id920773897
octolytics-dimension-repository_network_root_nwonodejs/ncrypto
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/ncrypto/pull/36#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fncrypto%2Fpull%2F36
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fncrypto%2Fpull%2F36
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fncrypto
Reloadhttps://github.com/nodejs/ncrypto/pull/36
Reloadhttps://github.com/nodejs/ncrypto/pull/36
Reloadhttps://github.com/nodejs/ncrypto/pull/36
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
nodejs https://github.com/nodejs
ncryptohttps://github.com/nodejs/ncrypto
Notifications https://github.com/login?return_to=%2Fnodejs%2Fncrypto
Fork 12 https://github.com/login?return_to=%2Fnodejs%2Fncrypto
Star 21 https://github.com/login?return_to=%2Fnodejs%2Fncrypto
Code https://github.com/nodejs/ncrypto
Issues 1 https://github.com/nodejs/ncrypto/issues
Pull requests 1 https://github.com/nodejs/ncrypto/pulls
Actions https://github.com/nodejs/ncrypto/actions
Security and quality 0 https://github.com/nodejs/ncrypto/security
Insights https://github.com/nodejs/ncrypto/pulse
Code https://github.com/nodejs/ncrypto
Issues https://github.com/nodejs/ncrypto/issues
Pull requests https://github.com/nodejs/ncrypto/pulls
Actions https://github.com/nodejs/ncrypto/actions
Security and quality https://github.com/nodejs/ncrypto/security
Insights https://github.com/nodejs/ncrypto/pulse
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/ncrypto/tree/main
ndossche:clesss-2https://github.com/ndossche/ncrypto/tree/clesss-2
Conversationhttps://github.com/nodejs/ncrypto/pull/36
Commits1 (1)https://github.com/nodejs/ncrypto/pull/36/commits
Checkshttps://github.com/nodejs/ncrypto/pull/36/checks
Files changedhttps://github.com/nodejs/ncrypto/pull/36/files
fix: use proper return value check for EVP_CIPHER_CTX_ctrl()https://github.com/nodejs/ncrypto/pull/36#top
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/ncrypto/tree/main
ndossche:clesss-2https://github.com/ndossche/ncrypto/tree/clesss-2
https://github.com/ndossche
ndosschehttps://github.com/ndossche
Feb 16, 2026https://github.com/nodejs/ncrypto/pull/36#issue-3947592325
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 23, 2026 https://github.com/nodejs/ncrypto/pull/36#pullrequestreview-3991591836
View reviewed changes https://github.com/nodejs/ncrypto/pull/36/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/ncrypto/pull/36#pullrequestreview-3991591836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/ndossche
ndosschehttps://github.com/ndossche
Mar 23, 2026https://github.com/nodejs/ncrypto/pull/36#issuecomment-4113110995
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 23, 2026https://github.com/nodejs/ncrypto/pull/36#issuecomment-4113269980
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/ndossche
ndosschehttps://github.com/ndossche
force-pushedhttps://github.com/nodejs/ncrypto/compare/9a303b57d060e86e85e362e75a2125f8abc265e3..9837d3f58585f61ccdb29997960af26377045777
9a303b5https://github.com/nodejs/ncrypto/commit/9a303b57d060e86e85e362e75a2125f8abc265e3
9837d3fhttps://github.com/nodejs/ncrypto/commit/9837d3f58585f61ccdb29997960af26377045777
Compare https://github.com/nodejs/ncrypto/compare/9a303b57d060e86e85e362e75a2125f8abc265e3..9837d3f58585f61ccdb29997960af26377045777
March 23, 2026 20:13https://github.com/nodejs/ncrypto/pull/36#event-23827542170
https://github.com/ndossche
fix: use proper return value check for EVP_CIPHER_CTX_ctrl()https://github.com/nodejs/ncrypto/pull/36/commits/0bea17548c121f7094290a9edd7c12dc129f8e57
0bea175https://github.com/nodejs/ncrypto/pull/36/commits/0bea17548c121f7094290a9edd7c12dc129f8e57
nodejs#1https://github.com/nodejs/ncrypto/pull/1
nodejs#2https://github.com/nodejs/ncrypto/pull/2
nodejs#3https://github.com/nodejs/ncrypto/pull/3
nodejs#4https://github.com/nodejs/ncrypto/pull/4
nodejs#5https://github.com/nodejs/ncrypto/pull/5
nodejs#6https://github.com/nodejs/ncrypto/pull/6
nodejs#7https://github.com/nodejs/ncrypto/issues/7
nodejs#8https://github.com/nodejs/ncrypto/pull/8
nodejs#9https://github.com/nodejs/ncrypto/pull/9
nodejs#10https://github.com/nodejs/ncrypto/pull/10
nodejs#11https://github.com/nodejs/ncrypto/pull/11
https://github.com/ndossche
ndosschehttps://github.com/ndossche
force-pushedhttps://github.com/nodejs/ncrypto/compare/9837d3f58585f61ccdb29997960af26377045777..0bea17548c121f7094290a9edd7c12dc129f8e57
9837d3fhttps://github.com/nodejs/ncrypto/commit/9837d3f58585f61ccdb29997960af26377045777
0bea175https://github.com/nodejs/ncrypto/commit/0bea17548c121f7094290a9edd7c12dc129f8e57
Compare https://github.com/nodejs/ncrypto/compare/9837d3f58585f61ccdb29997960af26377045777..0bea17548c121f7094290a9edd7c12dc129f8e57
March 23, 2026 20:14https://github.com/nodejs/ncrypto/pull/36#event-23827565095
https://github.com/ndossche
ndosschehttps://github.com/ndossche
Mar 23, 2026https://github.com/nodejs/ncrypto/pull/36#issuecomment-4113419959
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/jasnell
jasnellhttps://github.com/jasnell
88555cchttps://github.com/nodejs/ncrypto/commit/88555cc07e8ffcfdbbab779e86cc6225317ee6ae
Mar 28, 2026https://github.com/nodejs/ncrypto/pull/36#event-23998427596
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 28, 2026 https://github.com/nodejs/ncrypto/pull/36#ref-pullrequest-4120732090
chore(main): release 1.1.4 #39 https://github.com/nodejs/ncrypto/pull/39
https://github.com/robobun
robobunhttps://github.com/robobun
Jul 1, 2026 https://github.com/nodejs/ncrypto/pull/36#ref-pullrequest-4788808049
crypto: port upstream ncrypto correctness fixes oven-sh/bun#33202 https://github.com/oven-sh/bun/pull/33202
dylan-conwayhttps://github.com/dylan-conway
Jul 1, 2026 https://github.com/nodejs/ncrypto/pull/36#ref-commit-27009bf
https://github.com/robobun
https://github.com/dylan-conway
crypto: port upstream ncrypto correctness fixes (https://github.com/oven-sh/bun/commit/27009bf0f69a00b2eb58aaa5c0315a75193631c2
#33202https://github.com/oven-sh/bun/pull/33202
)https://github.com/oven-sh/bun/commit/27009bf0f69a00b2eb58aaa5c0315a75193631c2
27009bfhttps://github.com/oven-sh/bun/commit/27009bf0f69a00b2eb58aaa5c0315a75193631c2
nodejs/ncrypto@134ac40https://github.com/nodejs/ncrypto/commit/134ac40
nodejs/ncrypto@134ac40https://github.com/nodejs/ncrypto/commit/134ac4073148b16cee564eb7a883b72f6d699a0d
nodejs/ncrypto#37https://github.com/nodejs/ncrypto/pull/37
nodejs/ncrypto#37https://github.com/nodejs/ncrypto/pull/37
nodejs/ncrypto#36https://github.com/nodejs/ncrypto/pull/36
nodejs/ncrypto#36https://github.com/nodejs/ncrypto/pull/36
nodejs/node#63895https://github.com/nodejs/node/pull/63895
nodejs/node#63895https://github.com/nodejs/node/pull/63895
nodejs/node#61788https://github.com/nodejs/node/pull/61788
nodejs/node#61788https://github.com/nodejs/node/pull/61788
nodejs/node#59471https://github.com/nodejs/node/pull/59471
nodejs/node#59471https://github.com/nodejs/node/pull/59471
nodejs/node#60609https://github.com/nodejs/node/pull/60609
nodejs/node#60609https://github.com/nodejs/node/pull/60609
nodejs/node#57803https://github.com/nodejs/node/pull/57803
nodejs/node#57803https://github.com/nodejs/node/pull/57803
nodejs/node#62396https://github.com/nodejs/node/pull/62396
nodejs/node#62396https://github.com/nodejs/node/pull/62396
https://github.co/hiddenchars
https://github.com/nodejs/ncrypto/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fncrypto%2Fpull%2F36
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/ncrypto/pull/36/files/9837d3f58585f61ccdb29997960af26377045777
Please reload this pagehttps://github.com/nodejs/ncrypto/pull/36
https://github.com/ndossche
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.