Title: Missed needed breaking change for 12.x · Issue #320 · nodejs/modules · GitHub
Open Graph Title: Missed needed breaking change for 12.x · Issue #320 · nodejs/modules
X Title: Missed needed breaking change for 12.x · Issue #320 · nodejs/modules
Description: In a call with @weswigham today it became apparent that we likely should have unflagged throwing on require('./path.mjs'), as it is arguably a breaking change to require. I've opened a PR to get the behavior change landed ASAP as Semver-...
Open Graph Description: In a call with @weswigham today it became apparent that we likely should have unflagged throwing on require('./path.mjs'), as it is arguably a breaking change to require. I've opened a PR to get th...
X Description: In a call with @weswigham today it became apparent that we likely should have unflagged throwing on require('./path.mjs'), as it is arguably a breaking change to require. I've opened a ...
Opengraph URL: https://github.com/nodejs/modules/issues/320
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Missed needed breaking change for 12.x","articleBody":"In a call with @weswigham today it became apparent that we likely should have unflagged throwing on `require('./path.mjs')`, as it is arguably a breaking change to require. I've opened a PR to get the behavior change landed ASAP as Semver-Patch... under the guise that this should have landed in 12.x... it is a stretch, but we should have this conversation\r\n\r\nhttps://github.com/nodejs/node/pull/27417","author":{"url":"https://github.com/MylesBorins","@type":"Person","name":"MylesBorins"},"datePublished":"2019-04-25T21:36:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":12},"url":"https://github.com/320/modules/issues/320"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0de67c35-ea77-abd4-c861-2cadf091d247 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 85E0:3F0C56:13590AD:1C2388A:6A4E43AC |
| html-safe-nonce | c1e43caf25d819f2b98183821d262a31d3940318a1a7f150127844e5015ddf14 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUUwOjNGMEM1NjoxMzU5MEFEOjFDMjM4OEE6NkE0RTQzQUMiLCJ2aXNpdG9yX2lkIjoiNTI4OTg1NzMzNjE1OTkxMjg3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a822b8bb0f75ac11d59f816df56d4993e14331345607dba4258364cc755c4085 |
| hovercard-subject-tag | issue:437408378 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/modules/320/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b463182ab4d444b0222f9c150962c93a321a24dbd04a9db6a50e52b56e32fa16/nodejs/modules/issues/320 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b463182ab4d444b0222f9c150962c93a321a24dbd04a9db6a50e52b56e32fa16/nodejs/modules/issues/320 |
| og:image:alt | In a call with @weswigham today it became apparent that we likely should have unflagged throwing on require('./path.mjs'), as it is arguably a breaking change to require. I've opened a PR to get th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/modules git https://github.com/nodejs/modules.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 119901830 |
| octolytics-dimension-repository_nwo | nodejs/modules |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 119901830 |
| octolytics-dimension-repository_network_root_nwo | nodejs/modules |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9fabff9b8b127e686a3ec86f91422e818056ca2c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width