Title: llnode warnings during compilation process · Issue #245 · nodejs/llnode · GitHub
Open Graph Title: llnode warnings during compilation process · Issue #245 · nodejs/llnode
X Title: llnode warnings during compilation process · Issue #245 · nodejs/llnode
Description: Current compilation process throws some warnings. Wouldn't it be a good approach to prevent merge of PRs that introduce new warnings? Or maybe add it to the test pipeline? Current warnings are as follow: llv8.h:395:17: warning: inline fu...
Open Graph Description: Current compilation process throws some warnings. Wouldn't it be a good approach to prevent merge of PRs that introduce new warnings? Or maybe add it to the test pipeline? Current warnings are as f...
X Description: Current compilation process throws some warnings. Wouldn't it be a good approach to prevent merge of PRs that introduce new warnings? Or maybe add it to the test pipeline? Current warnings are ...
Opengraph URL: https://github.com/nodejs/llnode/issues/245
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"llnode warnings during compilation process","articleBody":"Current compilation process throws some warnings. Wouldn't it be a good approach to prevent merge of PRs that introduce new warnings? Or maybe add it to the test pipeline?\r\n\r\nCurrent warnings are as follow:\r\n```\r\nllv8.h:395:17: warning: inline function ‘llnode::v8::String llnode::v8::ScopeInfo::ContextLocalName(int, int, int, llnode::Error\u0026)’ used\r\n but never defined\r\n```\r\n\r\n```\r\nllv8.h:410:16: warning: inline function ‘llnode::v8::Value llnode::v8::Context::ContextSlot(int, llnode::Error\u0026)’ used but never defined\r\n```\r\n\r\n```\r\nllv8.cc:107:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]\r\n return *reinterpret_cast\u003cdouble*\u003e(\u0026value);\r\n```\r\n\r\n```\r\nllv8.cc:1969:14: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]\r\n```\r\n\r\n```\r\nllscan.cc:1468:8: warning: variable ‘done’ set but not used [-Wunused-but-set-variable]\r\n```\r\n\r\n```\r\nllscan.cc:528:36: warning: ‘scanner’ may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n```\r\n\r\n```\r\n","author":{"url":"https://github.com/Drieger","@type":"Person","name":"Drieger"},"datePublished":"2018-10-25T17:07:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/245/llnode/issues/245"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c166ac74-9cae-2ed8-a96c-98a891b1a180 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 89D0:2F0FC4:10191F8:1632988:6A4CA299 |
| html-safe-nonce | f06b564edd1036342c8804118cc32b776ec6f4b3b6f4f3cfe3a99a8c67b75d8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUQwOjJGMEZDNDoxMDE5MUY4OjE2MzI5ODg6NkE0Q0EyOTkiLCJ2aXNpdG9yX2lkIjoiMjE2NDY4MTA0NjcyODk0MjIzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e0d1d9e023ab445991e9577da23f017e7154f4f7bc621a23b1fd119e891337ac |
| hovercard-subject-tag | issue:374045283 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/llnode/245/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3a1da387452b1c3ed7d778838d3d3e4fc28af4adf66dea929a3757c56d122971/nodejs/llnode/issues/245 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a1da387452b1c3ed7d778838d3d3e4fc28af4adf66dea929a3757c56d122971/nodejs/llnode/issues/245 |
| og:image:alt | Current compilation process throws some warnings. Wouldn't it be a good approach to prevent merge of PRs that introduce new warnings? Or maybe add it to the test pipeline? Current warnings are as f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Drieger |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/llnode git https://github.com/nodejs/llnode.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 45659211 |
| octolytics-dimension-repository_nwo | nodejs/llnode |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45659211 |
| octolytics-dimension-repository_network_root_nwo | nodejs/llnode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ae90d426644ca15e89bacceb72e51f4e9dbf85f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width