Title: Handle URLs with a colon after host but no port · Issue #501 · nodejs/http-parser · GitHub
Open Graph Title: Handle URLs with a colon after host but no port · Issue #501 · nodejs/http-parser
X Title: Handle URLs with a colon after host but no port · Issue #501 · nodejs/http-parser
Description: Hello! According to this issue on libgit2, RFC 3986 says: URI producers and normalizers should omit the port component and its ":" delimiter if port is empty or if its value would be the same as that of the scheme's default. They are pat...
Open Graph Description: Hello! According to this issue on libgit2, RFC 3986 says: URI producers and normalizers should omit the port component and its ":" delimiter if port is empty or if its value would be the same as th...
X Description: Hello! According to this issue on libgit2, RFC 3986 says: URI producers and normalizers should omit the port component and its ":" delimiter if port is empty or if its value would be the ...
Opengraph URL: https://github.com/nodejs/http-parser/issues/501
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Handle URLs with a colon after host but no port","articleBody":"Hello!\r\n\r\nAccording to [this issue](https://github.com/libgit2/libgit2/pull/5108) on libgit2,\r\nRFC 3986 says:\r\n\r\n URI producers and normalizers should omit the port component and its\r\n \":\" delimiter if port is empty or if its value would be the same as\r\n that of the scheme's default.\r\n\r\nThey are patching [http-parser](https://github.com/libgit2/libgit2/pull/5108/files) in order to support it. A similar patch (deleting `case s_http_host_port_start:` around line 2394) works fine also on latest http-parser release (v2.9.3), but a test is broken\r\n *** http_parser_parse_url(\"http://hostname:/\") \"proxy empty port\" test failed, unexpected rv 0 ***\r\n\r\nMerging something similar on the main repo would prevent maintainers from varios distros to [apply the patch by themeselves](https://github.com/libgit2/libgit2/issues/5436#issuecomment-593773122).\r\n\r\nCan something similar be merged here?\r\n\r\nThanks,\r\nNicolò\r\n\r\n","author":{"url":"https://github.com/nico202","@type":"Person","name":"nico202"},"datePublished":"2020-03-17T13:35:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/501/http-parser/issues/501"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:34987d1d-e14d-a602-7173-3e9676afbb7d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C1CC:3C3DDE:4BD6AF4:6539A7A:6A5DAED8 |
| html-safe-nonce | ab59a0ff4729d2a04747c812a14542c9e831de0601d773b476fb8f1f47f518ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUNDOjNDM0RERTo0QkQ2QUY0OjY1MzlBN0E6NkE1REFFRDgiLCJ2aXNpdG9yX2lkIjoiNTIxODQ2MTIxNzUwNzAzODMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7826f3430e6b2e3a3452d248b45cac003db71440a4b3b7339916e1b8b1ffdb2c |
| hovercard-subject-tag | issue:583017995 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/http-parser/501/issue_layout |
| twitter:image | https://opengraph.githubassets.com/da3f6483cb4cb7b421250623d893efe72cbe01a8758961a54fea31d89af78531/nodejs/http-parser/issues/501 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/da3f6483cb4cb7b421250623d893efe72cbe01a8758961a54fea31d89af78531/nodejs/http-parser/issues/501 |
| og:image:alt | Hello! According to this issue on libgit2, RFC 3986 says: URI producers and normalizers should omit the port component and its ":" delimiter if port is empty or if its value would be the same as th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nico202 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/http-parser git https://github.com/nodejs/http-parser.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 186749 |
| octolytics-dimension-repository_nwo | nodejs/http-parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 186749 |
| octolytics-dimension-repository_network_root_nwo | nodejs/http-parser |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width