René's URL Explorer Experiment


Title: feat: update bot comment when Jenkins finishes by mmarchini · Pull Request #259 · nodejs/github-bot · GitHub

Open Graph Title: feat: update bot comment when Jenkins finishes by mmarchini · Pull Request #259 · nodejs/github-bot

X Title: feat: update bot comment when Jenkins finishes by mmarchini · Pull Request #259 · nodejs/github-bot

Description: Note: this is a rough draft of a implementation of the "Edit Comment" feature described in #251. I haven't set up my machine to test the bot yet, so this code is completely untested at this point, but it reflects what I'm thinking. I'm looking for comments on the flow instead of the code (since the code wasn't tested yet). The flow is as follow: When a Jenkins job starts, the bot will leave a comment on the respective PR The comment will have two placeholders created using html comments One placeholder next to the CI url, for the build status One placeholder below the CI url, for a summary of failures when the build fails The placeholders will hold the build ID so that the bot can identify the respective comment later When a Jenkins job finishes, the bot will: Fetch all comments for the respective PR Find the respective comment (if it can't find, skip the next steps) Replace the first placeholder with the build status If the build failed: Run ncu-ci to get a summary of changes, in markdown format Wrap the output with

tag. Replace the second placeholder with the wrapped output The bot updates the comment using GitHub API The result from this workflow will have minimum visual impact on Pull Requests while also adding a rich summary of failures, and will allow us to search for flaky tests easier (if a test failed on multiple PRs and we search for that test on the PRs tab, all PRs where the test failed will show up, making it easier to determine if a test is flaky or not). There are some requirements for this workflow to work. We need to change our post-build-status-update on Jenkins to publish the build number as well. We also need to ensure ncu-ci can consume the credentials via environment variables (I don't think it can today). As a bonus, if ncu-ci could expose an API to get the markdown results of ncu-ci that'd be great, as we wouldn't need to spawn another process to do that, but I don't think it'll be possible in the near future. Update the bot comment on a PR when the corresponding Jenkins build finishes. The updated comment will have the build status, and if the build failed, it will have a summary of failures. To identify a comment corresponding to a PR, we leave placeholders on the comment as HTML commnets, so those placeholders can be replaced later. Signed-off-by: Matheus Marchini mmarchini@netflix.com

Open Graph Description: Note: this is a rough draft of a implementation of the "Edit Comment" feature described in #251. I haven't set up my machine to test the bot yet, so this code is completely untested a...

X Description: Note: this is a rough draft of a implementation of the "Edit Comment" feature described in #251. I haven't set up my machine to test the bot yet, so this code is completel...

Opengraph URL: https://github.com/nodejs/github-bot/pull/259

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a854c009-4886-07b9-2cc4-f24765a94f4c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC9E:5105D:1EC17A7:2A59161:6A4ECBE6
html-safe-noncedd3585c9ed64b88409e8a32a930eff33a1d8689190669d4c7b64750838c85212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzlFOjUxMDVEOjFFQzE3QTc6MkE1OTE2MTo2QTRFQ0JFNiIsInZpc2l0b3JfaWQiOiIyMjg0ODE3OTA5MTMyNzQxNjA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac52bcbaaa4f6259e3c1cd7194c121a2e641e29d059b14cb972623154242a7b721
hovercard-subject-tagpull_request:404840657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/github-bot/pull/259/files
twitter:imagehttps://avatars.githubusercontent.com/u/4048656?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4048656?s=400&v=4
og:image:altNote: this is a rough draft of a implementation of the "Edit Comment" feature described in #251. I haven't set up my machine to test the bot yet, so this code is completely untested a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/github-bot git https://github.com/nodejs/github-bot.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id55435270
octolytics-dimension-repository_nwonodejs/github-bot
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id55435270
octolytics-dimension-repository_network_root_nwonodejs/github-bot
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/github-bot/pull/259/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fgithub-bot%2Fpull%2F259%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fgithub-bot%2Fpull%2F259%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fgithub-bot
Reloadhttps://github.com/nodejs/github-bot/pull/259/files
Reloadhttps://github.com/nodejs/github-bot/pull/259/files
Reloadhttps://github.com/nodejs/github-bot/pull/259/files
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
nodejs https://github.com/nodejs
github-bothttps://github.com/nodejs/github-bot
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fgithub-bot
Fork 138 https://github.com/login?return_to=%2Fnodejs%2Fgithub-bot
Star 300 https://github.com/login?return_to=%2Fnodejs%2Fgithub-bot
Code https://github.com/nodejs/github-bot
Issues 18 https://github.com/nodejs/github-bot/issues
Pull requests 2 https://github.com/nodejs/github-bot/pulls
Actions https://github.com/nodejs/github-bot/actions
Projects https://github.com/nodejs/github-bot/projects
Security and quality 0 https://github.com/nodejs/github-bot/security
Insights https://github.com/nodejs/github-bot/pulse
Code https://github.com/nodejs/github-bot
Issues https://github.com/nodejs/github-bot/issues
Pull requests https://github.com/nodejs/github-bot/pulls
Actions https://github.com/nodejs/github-bot/actions
Projects https://github.com/nodejs/github-bot/projects
Security and quality https://github.com/nodejs/github-bot/security
Insights https://github.com/nodejs/github-bot/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fgithub-bot%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fgithub-bot%2Fissues%2Fnew%2Fchoose
mmarchinihttps://github.com/mmarchini
nodejs:mainhttps://github.com/nodejs/github-bot/tree/main
mmarchini:update-bot-commenthttps://github.com/mmarchini/github-bot/tree/update-bot-comment
Conversation 6 https://github.com/nodejs/github-bot/pull/259
Commits 1 https://github.com/nodejs/github-bot/pull/259/commits
Checks 0 https://github.com/nodejs/github-bot/pull/259/checks
Files changed https://github.com/nodejs/github-bot/pull/259/files
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
feat: update bot comment when Jenkins finishes https://github.com/nodejs/github-bot/pull/259/files#top
Show all changes 1 commit https://github.com/nodejs/github-bot/pull/259/files
186f79b feat: update bot comment when Jenkins finishes mmarchini Apr 14, 2020 https://github.com/nodejs/github-bot/pull/259/commits/186f79b86da349c3d11f6c681c93b45c35c44873
Clear filters https://github.com/nodejs/github-bot/pull/259/files
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
push-jenkins-update.js https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
package-lock.json https://github.com/nodejs/github-bot/pull/259/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/nodejs/github-bot/pull/259/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/nodejs/github-bot/blob/main/.github/CODEOWNERS#L8
lib/push-jenkins-update.jshttps://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
View file https://github.com/mmarchini/github-bot/blob/186f79b86da349c3d11f6c681c93b45c35c44873/lib/push-jenkins-update.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/github-bot/pull/259/{{ revealButtonHref }}
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
https://github.com/nodejs/github-bot/pull/259/files#diff-89a8938ab0f675dd233a0b10b972330fabe5201dd7954328e64fa9b73851efb4
Please reload this pagehttps://github.com/nodejs/github-bot/pull/259/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.