René's URL Explorer Experiment


Title: CI fixes for latest commits and reland #45 by guybedford · Pull Request #49 · nodejs/ecmascript-modules · GitHub

Open Graph Title: CI fixes for latest commits and reland #45 by guybedford · Pull Request #49 · nodejs/ecmascript-modules

X Title: CI fixes for latest commits and reland #45 by guybedford · Pull Request #49 · nodejs/ecmascript-modules

Description: A fork of Node.js to hash out ideas related to ESModules - CI fixes for latest commits and reland #45 by guybedford · Pull Request #49 · nodejs/ecmascript-modules

Open Graph Description: This fixes up some linting issues that crept in on the last merges.

X Description: This fixes up some linting issues that crept in on the last merges.

Opengraph URL: https://github.com/nodejs/ecmascript-modules/pull/49

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d2cb3ed4-6249-274e-e818-fe3e9e028fd1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA1C:3EE845:72FFA11:A14C4CB:6A4FDE29
html-safe-noncedf9b87a15267eff1aff7172b108b62d2ac7521694c0a26be6a072a839f48e84e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTFDOjNFRTg0NTo3MkZGQTExOkExNEM0Q0I6NkE0RkRFMjkiLCJ2aXNpdG9yX2lkIjoiMzgyNDAxMzkyNzgwNzYyNjY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3e921ca172166412a3eb497d80ec11e9dad2d70cfb4ffc63daad4cef6ec16561
hovercard-subject-tagpull_request:258259857
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/ecmascript-modules/49/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4b7252177c994fd41fa0a442da45242b4b42fcfd1782af94e82c3e80de2ea5f0/nodejs/ecmascript-modules/pull/49
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b7252177c994fd41fa0a442da45242b4b42fcfd1782af94e82c3e80de2ea5f0/nodejs/ecmascript-modules/pull/49
og:image:altThis fixes up some linting issues that crept in on the last merges.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/ecmascript-modules git https://github.com/nodejs/ecmascript-modules.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id145752541
octolytics-dimension-repository_nwonodejs/ecmascript-modules
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145752541
octolytics-dimension-repository_network_root_nwonodejs/ecmascript-modules
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/ecmascript-modules/pull/49#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fecmascript-modules%2Fpull%2F49
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fecmascript-modules%2Fpull%2F49
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fecmascript-modules
Reloadhttps://github.com/nodejs/ecmascript-modules/pull/49
Reloadhttps://github.com/nodejs/ecmascript-modules/pull/49
Reloadhttps://github.com/nodejs/ecmascript-modules/pull/49
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
nodejs https://github.com/nodejs
ecmascript-moduleshttps://github.com/nodejs/ecmascript-modules
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
Notifications https://github.com/login?return_to=%2Fnodejs%2Fecmascript-modules
Fork 18 https://github.com/login?return_to=%2Fnodejs%2Fecmascript-modules
Star 72 https://github.com/login?return_to=%2Fnodejs%2Fecmascript-modules
Code https://github.com/nodejs/ecmascript-modules
Issues 0 https://github.com/nodejs/ecmascript-modules/issues
Pull requests 0 https://github.com/nodejs/ecmascript-modules/pulls
Actions https://github.com/nodejs/ecmascript-modules/actions
Security and quality 0 https://github.com/nodejs/ecmascript-modules/security
Insights https://github.com/nodejs/ecmascript-modules/pulse
Code https://github.com/nodejs/ecmascript-modules
Issues https://github.com/nodejs/ecmascript-modules/issues
Pull requests https://github.com/nodejs/ecmascript-modules/pulls
Actions https://github.com/nodejs/ecmascript-modules/actions
Security and quality https://github.com/nodejs/ecmascript-modules/security
Insights https://github.com/nodejs/ecmascript-modules/pulse
MylesBorinshttps://github.com/MylesBorins
nodejs:modules-lkgrhttps://github.com/nodejs/ecmascript-modules/tree/modules-lkgr
guybedford:ci-fixeshttps://github.com/guybedford/ecmascript-modules/tree/ci-fixes
Conversationhttps://github.com/nodejs/ecmascript-modules/pull/49
Commits15 (15)https://github.com/nodejs/ecmascript-modules/pull/49/commits
Checkshttps://github.com/nodejs/ecmascript-modules/pull/49/checks
Files changedhttps://github.com/nodejs/ecmascript-modules/pull/49/files
CI fixes for latest commits and reland #45https://github.com/nodejs/ecmascript-modules/pull/49#top
MylesBorinshttps://github.com/MylesBorins
nodejs:modules-lkgrhttps://github.com/nodejs/ecmascript-modules/tree/modules-lkgr
guybedford:ci-fixeshttps://github.com/guybedford/ecmascript-modules/tree/ci-fixes
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issue-417215909
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
guybedfordhttps://github.com/guybedford
March 5, 2019 09:07https://github.com/nodejs/ecmascript-modules/pull/49#commits-pushed-8c6da40
https://github.com/guybedford
https://github.com/nodejs-ci
esm: top-level --type, -m flags, spec updateshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/8c6da403df4f57dab41176dd5600c50ad6aac7c9
8c6da40https://github.com/nodejs/ecmascript-modules/pull/49/commits/8c6da403df4f57dab41176dd5600c50ad6aac7c9
https://github.com/guybedford
https://github.com/nodejs-ci
esm: implement top-level --type flag, type:esm -> type:modulehttps://github.com/nodejs/ecmascript-modules/pull/49/commits/4ea0c658142b4aed2cd6587e655b6d4ec4819384
4ea0c65https://github.com/nodejs/ecmascript-modules/pull/49/commits/4ea0c658142b4aed2cd6587e655b6d4ec4819384
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: check for mismatch between --type and input file extensionhttps://github.com/nodejs/ecmascript-modules/pull/49/commits/1c9ea84ce326376faae604b9e34f794ee4631363
1c9ea84https://github.com/nodejs/ecmascript-modules/pull/49/commits/1c9ea84ce326376faae604b9e34f794ee4631363
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: rename internal module type strings to match public api for --typehttps://github.com/nodejs/ecmascript-modules/pull/49/commits/a7ed33239bcadba49faa8c742a1f6eaf32c181a3
a7ed332https://github.com/nodejs/ecmascript-modules/pull/49/commits/a7ed33239bcadba49faa8c742a1f6eaf32c181a3
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: --type no longer overrides package.json; throw on conflicthttps://github.com/nodejs/ecmascript-modules/pull/49/commits/52cac1adf9b672c1991367d1c8ab6e61514857bd
52cac1ahttps://github.com/nodejs/ecmascript-modules/pull/49/commits/52cac1adf9b672c1991367d1c8ab6e61514857bd
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: add -m alias for --type=modulehttps://github.com/nodejs/ecmascript-modules/pull/49/commits/c38acbb0a08cec6c5c45e7a9e5912e6d9eb6ed12
c38acbbhttps://github.com/nodejs/ecmascript-modules/pull/49/commits/c38acbb0a08cec6c5c45e7a9e5912e6d9eb6ed12
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: tests for --type error caseshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/09935176dd4b4578a87bd11b6eeb07692c4a0e4b
0993517https://github.com/nodejs/ecmascript-modules/pull/49/commits/09935176dd4b4578a87bd11b6eeb07692c4a0e4b
https://github.com/guybedford
https://github.com/nodejs-ci
esm: include format mismatch errors in spechttps://github.com/nodejs/ecmascript-modules/pull/49/commits/666b9783ae40103597cbacf6fd6be5ba84682ba8
666b978https://github.com/nodejs/ecmascript-modules/pull/49/commits/666b9783ae40103597cbacf6fd6be5ba84682ba8
https://github.com/guybedford
https://github.com/nodejs-ci
esm: implement symlink handling in package scopehttps://github.com/nodejs/ecmascript-modules/pull/49/commits/76cfb4b1889d7842406342ec5b9efcaf51a72194
76cfb4bhttps://github.com/nodejs/ecmascript-modules/pull/49/commits/76cfb4b1889d7842406342ec5b9efcaf51a72194
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: merge both 'type mismatch' errors into onehttps://github.com/nodejs/ecmascript-modules/pull/49/commits/2b2c025ed904eb77f1e349b8a095463269cfdb47
2b2c025https://github.com/nodejs/ecmascript-modules/pull/49/commits/2b2c025ed904eb77f1e349b8a095463269cfdb47
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: tests for correctly detecting module types of symlinkshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/c1ee7ac4e5036a43f038d3ecf5aafe559605efca
c1ee7achttps://github.com/nodejs/ecmascript-modules/pull/49/commits/c1ee7ac4e5036a43f038d3ecf5aafe559605efca
https://github.com/guybedford
https://github.com/nodejs-ci
esm: unify type mismatch errorshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/021ad71a2c29d32d6d548ff5d38532b50b9022cf
021ad71https://github.com/nodejs/ecmascript-modules/pull/49/commits/021ad71a2c29d32d6d548ff5d38532b50b9022cf
https://github.com/GeoffreyBooth
https://github.com/nodejs-ci
esm: fix errors for --type / "type" mismatcheshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/6f7bb4be58f07712c031141558390ccfddff68e0
6f7bb4bhttps://github.com/nodejs/ecmascript-modules/pull/49/commits/6f7bb4be58f07712c031141558390ccfddff68e0
https://github.com/MylesBorins
https://github.com/nodejs-ci
test: add additional fixtures and tests for irphttps://github.com/nodejs/ecmascript-modules/pull/49/commits/15daf0ae8aeecf38af8aebc66e622bd750f51522
15daf0ahttps://github.com/nodejs/ecmascript-modules/pull/49/commits/15daf0ae8aeecf38af8aebc66e622bd750f51522
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issuecomment-469620655
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://ci.nodejs.org/job/node-test-pull-request/21213/https://ci.nodejs.org/job/node-test-pull-request/21213/
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/guybedford
misc: ci fixes for latest commitshttps://github.com/nodejs/ecmascript-modules/pull/49/commits/49a38bbaf15aa1edbb12b81d00619b7659a26514
49a38bbhttps://github.com/nodejs/ecmascript-modules/pull/49/commits/49a38bbaf15aa1edbb12b81d00619b7659a26514
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/ecmascript-modules/compare/805e11a687c736965a1b16f529d8eaa623abd618..49a38bbaf15aa1edbb12b81d00619b7659a26514
805e11ahttps://github.com/nodejs/ecmascript-modules/commit/805e11a687c736965a1b16f529d8eaa623abd618
49a38bbhttps://github.com/nodejs/ecmascript-modules/commit/49a38bbaf15aa1edbb12b81d00619b7659a26514
Compare https://github.com/nodejs/ecmascript-modules/compare/805e11a687c736965a1b16f529d8eaa623abd618..49a38bbaf15aa1edbb12b81d00619b7659a26514
March 5, 2019 10:11https://github.com/nodejs/ecmascript-modules/pull/49#event-2180491242
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issuecomment-469714656
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Mar 5, 2019 https://github.com/nodejs/ecmascript-modules/pull/49#pullrequestreview-210775969
View reviewed changes https://github.com/nodejs/ecmascript-modules/pull/49/files/49a38bbaf15aa1edbb12b81d00619b7659a26514
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/ecmascript-modules/compare/15daf0ae8aeecf38af8aebc66e622bd750f51522..03fb3b16db707d1679138fce84013caa4c38a54f
15daf0ahttps://github.com/nodejs/ecmascript-modules/commit/15daf0ae8aeecf38af8aebc66e622bd750f51522
03fb3b1https://github.com/nodejs/ecmascript-modules/commit/03fb3b16db707d1679138fce84013caa4c38a54f
Compare https://github.com/nodejs/ecmascript-modules/compare/15daf0ae8aeecf38af8aebc66e622bd750f51522..03fb3b16db707d1679138fce84013caa4c38a54f
March 5, 2019 18:43https://github.com/nodejs/ecmascript-modules/pull/49#event-2181866144
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019 https://github.com/nodejs/ecmascript-modules/pull/49#ref-pullrequest-414895434
-m alias; determine type based for symlinks based on targets; error on mismatched type flag and package scope #45 https://github.com/nodejs/ecmascript-modules/pull/45
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#event-2181871402
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issuecomment-469807566
#45https://github.com/nodejs/ecmascript-modules/pull/45
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issuecomment-469815935
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://ci.nodejs.org/job/node-test-commit/26377/https://ci.nodejs.org/job/node-test-commit/26377/
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#issuecomment-469834380
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
49a38bbhttps://github.com/nodejs/ecmascript-modules/commit/49a38bbaf15aa1edbb12b81d00619b7659a26514
Mar 5, 2019https://github.com/nodejs/ecmascript-modules/pull/49#event-2182137987
https://github.co/hiddenchars
https://github.com/nodejs/ecmascript-modules/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fecmascript-modules%2Fpull%2F49
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/ecmascript-modules/pull/49/files/49a38bbaf15aa1edbb12b81d00619b7659a26514
Please reload this pagehttps://github.com/nodejs/ecmascript-modules/pull/49
https://github.com/guybedford
https://github.com/MylesBorins
https://github.com/GeoffreyBooth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.