Title: Accept revert commit titles that are elongated by git · Issue #97 · nodejs/core-validate-commit · GitHub
Open Graph Title: Accept revert commit titles that are elongated by git · Issue #97 · nodejs/core-validate-commit
X Title: Accept revert commit titles that are elongated by git · Issue #97 · nodejs/core-validate-commit
Description: In nodejs/node#42934, I was trying to revert nodejs/node#27371, so git revert automatically created this commit title for me: Revert "bootstrap: delay the instantiation of maps in per-context scripts" which has 74 characters. Since it ex...
Open Graph Description: In nodejs/node#42934, I was trying to revert nodejs/node#27371, so git revert automatically created this commit title for me: Revert "bootstrap: delay the instantiation of maps in per-context scrip...
X Description: In nodejs/node#42934, I was trying to revert nodejs/node#27371, so git revert automatically created this commit title for me: Revert "bootstrap: delay the instantiation of maps in per-context ...
Opengraph URL: https://github.com/nodejs/core-validate-commit/issues/97
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Accept revert commit titles that are elongated by git","articleBody":"In https://github.com/nodejs/node/pull/42934, I was trying to revert https://github.com/nodejs/node/pull/27371, so `git revert` automatically created this commit title for me:\r\n```git\r\nRevert \"bootstrap: delay the instantiation of maps in per-context scripts\"\r\n```\r\nwhich has 74 characters. Since it exceeds our maximum limit of 72 characters, the commit message linter failed on CI - https://github.com/nodejs/node/runs/6248053065?check_suite_focus=true#step:6:15\r\n\r\n\u003cdetails\u003e\r\n\r\n```\r\nRun echo \"::add-matcher::.github/workflows/commit-lint-problem-matcher.json\"\r\nnpm WARN exec The following package was not found and will be installed: core-validate-commit\r\n# b04fe688d5859f707cf1a5e0206967268118bf7a\r\nok 1 co-authored-by-is-trailer: no Co-authored-by metadata\r\nok 2 fixes-url: skipping fixes-url # SKIP\r\nok 3 line-after-title: blank line after title\r\nok 4 line-length: line-lengths are valid\r\nok 5 subsystem: valid subsystems [bootstrap]\r\nok 6 title-format: Title is formatted correctly.\r\nError: not ok 7 title-length: Title must be \u003c= 72 columns.\r\n ---\r\n {\r\n found: 74,\r\n compare: '\u003c=',\r\n wanted: 72,\r\n at: {\r\n line: 0,\r\n column: 72,\r\n body: 'Revert \"bootstrap: delay the instantiation of maps in per-context scripts\"'\r\n }\r\n }\r\n ...\r\n\r\n0..7\r\n# tests 7\r\n# pass 5\r\n# fail 1\r\n# Please review the commit message guidelines:\r\n# https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines\r\n```\r\n\r\n\u003c/details\u003e\r\n\r\nAs a workaround, I had to change the commit title to\r\n```\r\nbootstrap: stop delaying instantiation of maps in per-context scripts\r\n```\r\nwhich has 69 characters (\u003c 72) but it isn't satisfying anymore. :/\r\n\r\nInstead of failing, IMO the linter should accept standard revert commit titles regardless of the size.","author":{"url":"https://github.com/RaisinTen","@type":"Person","name":"RaisinTen"},"datePublished":"2022-05-02T13:23:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/97/core-validate-commit/issues/97"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0829ab02-7037-3ab2-81de-2ff19f789478 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AD38:13657F:483A9A:69652F:6A4E08EB |
| html-safe-nonce | bd777364ec5b2462c89d2874d9cbc80a4bd939c8ea5cd4182e5b62cf89f40052 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDM4OjEzNjU3Rjo0ODNBOUE6Njk2NTJGOjZBNEUwOEVCIiwidmlzaXRvcl9pZCI6IjgxOTU3NTY3NjMyMzc5NzYyOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 30de067c9c57264c59926a76c90244dc5974a2c65ba0788ece151afabe958431 |
| hovercard-subject-tag | issue:1222885071 |
| github-keyboard-shortcuts | repository,issues,commits,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/core-validate-commit/97/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bbc21535ddd0e36a17d37d74a6ac0aef8c51db0412ef48bb9c7081f356bc24ce/nodejs/core-validate-commit/issues/97 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bbc21535ddd0e36a17d37d74a6ac0aef8c51db0412ef48bb9c7081f356bc24ce/nodejs/core-validate-commit/issues/97 |
| og:image:alt | In nodejs/node#42934, I was trying to revert nodejs/node#27371, so git revert automatically created this commit title for me: Revert "bootstrap: delay the instantiation of maps in per-context scrip... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | RaisinTen |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/core-validate-commit git https://github.com/nodejs/core-validate-commit.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 56778056 |
| octolytics-dimension-repository_nwo | nodejs/core-validate-commit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 56778056 |
| octolytics-dimension-repository_network_root_nwo | nodejs/core-validate-commit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 52bde38e24398476f8eb1e0760c81346c6a00812 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width