Title: Refactor some cmd.js logic out into its own file for easier tests · Issue #71 · nodejs/core-validate-commit · GitHub
Open Graph Title: Refactor some cmd.js logic out into its own file for easier tests · Issue #71 · nodejs/core-validate-commit
X Title: Refactor some cmd.js logic out into its own file for easier tests · Issue #71 · nodejs/core-validate-commit
Description: While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in cmd.js is broken out into its own file, so it ...
Open Graph Description: While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in cmd.js...
X Description: While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in cmd.js...
Opengraph URL: https://github.com/nodejs/core-validate-commit/issues/71
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor some cmd.js logic out into its own file for easier tests","articleBody":"While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in `cmd.js` is broken out into its own file, so it would be easier to test if a particular flag was specified, and not necessarily test what that flag actually does. That could be done in its own separate test, where it would be easier to mock certain functions.\r\n\r\n@richardlau @Trott thoughts?\r\n\r\nI can send a PR so we can talk about it also","author":{"url":"https://github.com/lholmquist","@type":"Person","name":"lholmquist"},"datePublished":"2019-07-18T15:12:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/71/core-validate-commit/issues/71"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b8befd5f-543d-be1e-8270-d4f33cf4544e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9E68:8D142:1AFA213:23AF75E:696AF10B |
| html-safe-nonce | f7144ecf10acb107af0a4feccb3b3e2bf6037764415b9dae9b28ec3f0010a151 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTY4OjhEMTQyOjFBRkEyMTM6MjNBRjc1RTo2OTZBRjEwQiIsInZpc2l0b3JfaWQiOiI5MjYwNjM4MTE5OTY4NzI5NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 02e48fe600f865a30066f9d79de1cb4dab6c5a5f1365d393c5fdba1b8933114b |
| hovercard-subject-tag | issue:469828570 |
| github-keyboard-shortcuts | repository,issues,commits,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/core-validate-commit/71/issue_layout |
| twitter:image | https://opengraph.githubassets.com/af8254eea34f442d18975519bd05fffc443dce89fb2dcdd4bd3d8c12f399da41/nodejs/core-validate-commit/issues/71 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/af8254eea34f442d18975519bd05fffc443dce89fb2dcdd4bd3d8c12f399da41/nodejs/core-validate-commit/issues/71 |
| og:image:alt | While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in cmd.js... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lholmquist |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/core-validate-commit git https://github.com/nodejs/core-validate-commit.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 56778056 |
| octolytics-dimension-repository_nwo | nodejs/core-validate-commit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 56778056 |
| octolytics-dimension-repository_network_root_nwo | nodejs/core-validate-commit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width