Title: fails with es6 class member functions · Issue #26 · nodegit/promisify-node · GitHub
Open Graph Title: fails with es6 class member functions · Issue #26 · nodegit/promisify-node
X Title: fails with es6 class member functions · Issue #26 · nodegit/promisify-node
Description: version 0.4.0 node v6.9.1 When I enter this code in the node REPL: var promisify = require("promisify-node"); class C { constructor() { this.promisified_connect = promisify(this.connect); } connect(done) { if (done) { done(); } else { re...
Open Graph Description: version 0.4.0 node v6.9.1 When I enter this code in the node REPL: var promisify = require("promisify-node"); class C { constructor() { this.promisified_connect = promisify(this.connect); } connect...
X Description: version 0.4.0 node v6.9.1 When I enter this code in the node REPL: var promisify = require("promisify-node"); class C { constructor() { this.promisified_connect = promisify(this.connect);...
Opengraph URL: https://github.com/nodegit/promisify-node/issues/26
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fails with es6 class member functions","articleBody":"version 0.4.0\r\nnode v6.9.1\r\n\r\nWhen I enter this code in the node REPL:\r\n```\r\nvar promisify = require(\"promisify-node\");\r\nclass C {\r\n constructor() {\r\n this.promisified_connect = promisify(this.connect);\r\n }\r\n connect(done) {\r\n if (done) {\r\n done();\r\n } else {\r\n return this.promisified_connect();\r\n }\r\n }\r\n}\r\nvar c = new C()\r\n```\r\n\r\npromisify-node throws this error:\r\n```\r\nTypeError: Cannot read property '1' of null\r\n at module.exports (./node_modules/promisify-node/utils/args.js:9:63)\r\n at processExports (./node_modules/promisify-node/index.js:61:29)\r\n at module.exports (./node_modules/promisify-node/index.js:164:10)\r\n```\r\n\r\nso I updated the RegExp in https://github.com/nodegit/promisify-node/blob/master/utils/args.js#L9 from: \r\n```\r\n/function\\s.*?\\(([^)]*)\\)/\r\n```\r\nto:\r\n```\r\n/\\(([^)]*)\\)/\r\n```\r\n\r\nThen re-running the above test code produced another error:\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at processExports (./node_modules/promisify-node/index.js:86:16)\r\n at module.exports (./node_modules/promisify-node/index.js:164:10)\r\n at new C (repl:3:28)\r\n```\r\n\r\nI was able to get past this by modifying https://github.com/nodegit/promisify-node/blob/master/index.js#L86 to guard the checking of the keys of the prototype to:\r\n```\r\n if (exports.prototype) {\r\n if (Object.keys(exports.prototype).length) {\r\n```\r\n\r\nI believe there are likely other changes required.\r\n\r\n","author":{"url":"https://github.com/psnider","@type":"Person","name":"psnider"},"datePublished":"2016-11-28T15:29:47Z","url":"https://github.com/nodegit/promisify-node/issues/26"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:075189b8-0d0d-9af9-0081-cca6bf4a7723 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EC2C:245687:455966:61B2CE:6AFDB8E1 |
| html-safe-nonce | 5e32e603c17f984847b016f803666c4f0888d1682dd223101fa7b97f9df1f5a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzJDOjI0NTY4Nzo0NTU5NjY6NjFCMkNFOjZBRkRCOEUxIiwidmlzaXRvcl9pZCI6IjgyNDg2MDE0NzgyMTg3NTgzNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ba7d0a21eb89f0d2e5bb22b3117386720dbadb6ef7eeed965c928cc12347b50c |
| hovercard-subject-tag | issue:192035339 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/promisify-node/26/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c130153c49cd703e3dee1188190bd4a7615c508d11eb54eedf88d81562e1d59d/nodegit/promisify-node/issues/26 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c130153c49cd703e3dee1188190bd4a7615c508d11eb54eedf88d81562e1d59d/nodegit/promisify-node/issues/26 |
| og:image:alt | version 0.4.0 node v6.9.1 When I enter this code in the node REPL: var promisify = require("promisify-node"); class C { constructor() { this.promisified_connect = promisify(this.connect); } connect... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | psnider |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8309f07eb60a4237a657068c83d0bb57be4c7e02937f5e9933126f4bd596aac4 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/promisify-node git https://github.com/nodegit/promisify-node.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 18692565 |
| octolytics-dimension-repository_nwo | nodegit/promisify-node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 18692565 |
| octolytics-dimension-repository_network_root_nwo | nodegit/promisify-node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2f7154d847f1ddc5baa83b109a3e1d924605e2a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width