René's URL Explorer Experiment


Title: Reference leak fix by srajko · Pull Request #977 · nodegit/nodegit · GitHub

Open Graph Title: Reference leak fix by srajko · Pull Request #977 · nodegit/nodegit

X Title: Reference leak fix by srajko · Pull Request #977 · nodegit/nodegit

Description: Frees references on wrapper GC, and duplicates returned oids so they are not freed with the reference. iterator / foreach handling would need additional support, but we currently ignore all those methods.

Open Graph Description: Frees references on wrapper GC, and duplicates returned oids so they are not freed with the reference. iterator / foreach handling would need additional support, but we currently ignore all those m...

X Description: Frees references on wrapper GC, and duplicates returned oids so they are not freed with the reference. iterator / foreach handling would need additional support, but we currently ignore all those m...

Opengraph URL: https://github.com/nodegit/nodegit/pull/977

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:43526703-d4d6-3dbd-1563-0258a941c553
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91BE:3AE731:1ED5B50:2B1476B:6A5F47D9
html-safe-nonce1a2cd7530569d50c78f7bb83cb7fea4986410086589abd1e963eda07f63c78e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUJFOjNBRTczMToxRUQ1QjUwOjJCMTQ3NkI6NkE1RjQ3RDkiLCJ2aXNpdG9yX2lkIjoiNzM5NDAyODA2NDM0MTk2ODg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb2ecfb916b82ee64dfa6ef7355d7ddbb8e6e103910f7b403be49c3e4c94c0bdb
hovercard-subject-tagpull_request:64531360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/977/files
twitter:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
og:image:altFrees references on wrapper GC, and duplicates returned oids so they are not freed with the reference. iterator / foreach handling would need additional support, but we currently ignore all those m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab2497d9345a59709926b385d88458fa5932c82ec066288448eb68b34cbcbbda
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba0ac57287507693938b0a2de45402a22cda0785
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/977/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F977%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F977%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/977/files
Reloadhttps://github.com/nodegit/nodegit/pull/977/files
Reloadhttps://github.com/nodegit/nodegit/pull/977/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/977/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
srajko:reference-leak-fixhttps://github.com/srajko/nodegit/tree/reference-leak-fix
Conversation 1 https://github.com/nodegit/nodegit/pull/977
Commits 6 https://github.com/nodegit/nodegit/pull/977/commits
Checks 0 https://github.com/nodegit/nodegit/pull/977/checks
Files changed https://github.com/nodegit/nodegit/pull/977/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/977/files
Reference leak fix https://github.com/nodegit/nodegit/pull/977/files#top
Show all changes 6 commits https://github.com/nodegit/nodegit/pull/977/files
ec97dbc Add support for git_repository__cleanup srajko Mar 28, 2016 https://github.com/nodegit/nodegit/pull/977/commits/ec97dbce629fdb4c035504eba5c3c60a6328e690
045ec0e Add support for thread safety on async actions only srajko Mar 24, 2016 https://github.com/nodegit/nodegit/pull/977/commits/045ec0e5f22fbf429d1cd6984486fac35a077ae4
efbd8e1 Merge pull request #968 from srajko/thread-safety-async-only johnhaley81 Mar 29, 2016 https://github.com/nodegit/nodegit/pull/977/commits/efbd8e15e0b99ea750e33fb4bbea4985fee5dbfc
1a3610d Merge pull request #975 from srajko/repository-cleanup johnhaley81 Mar 29, 2016 https://github.com/nodegit/nodegit/pull/977/commits/1a3610d7a89da223adc46694c2696d6a2cf8b2c8
86f3c6d Mark references as self-freeing srajko Mar 29, 2016 https://github.com/nodegit/nodegit/pull/977/commits/86f3c6dd8a8f5c912d11ce3c216e3359a5444010
a0d546c Duplicate returned oids srajko Mar 29, 2016 https://github.com/nodegit/nodegit/pull/977/commits/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017
Clear filters https://github.com/nodegit/nodegit/pull/977/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/977/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/977/files
descriptor.json https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
lock_master.h https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
lock_master.cc https://github.com/nodegit/nodegit/pull/977/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
async_function.cc https://github.com/nodegit/nodegit/pull/977/files#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
sync_function.cc https://github.com/nodegit/nodegit/pull/977/files#diff-7e46711f90e3a938b09d4bcdae2249b1b8811f3511280569536d86aa8ee250c6
nodegit.cc https://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
runner.js https://github.com/nodegit/nodegit/pull/977/files#diff-2bc5c0e9cd0b0a21bfb20936a87acac24c440036f4733702f1a262923d02e5cf
index.js https://github.com/nodegit/nodegit/pull/977/files#diff-96573bdf80e231a9f89bbf0461eb41f9f3efb144eaae1c0ca05a62335844106b
repository.js https://github.com/nodegit/nodegit/pull/977/files#diff-feb15c59eac6e4328b32814141af56c3951c219675a40cf471e60007cfd0d54d
thread_safety.js https://github.com/nodegit/nodegit/pull/977/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
generate/input/descriptor.jsonhttps://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/input/descriptor.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/977/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
generate/templates/manual/include/lock_master.hhttps://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/templates/manual/include/lock_master.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
https://github.com/nodegit/nodegit/pull/977/files#diff-edcd1b645f23e06e8b52e0ac0dcce34a71a4a7366da15d6f028ce732075fdce2
generate/templates/manual/src/lock_master.cchttps://github.com/nodegit/nodegit/pull/977/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/templates/manual/src/lock_master.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/977/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/977/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
generate/templates/partials/async_function.cchttps://github.com/nodegit/nodegit/pull/977/files#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/templates/partials/async_function.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
https://github.com/nodegit/nodegit/pull/977/files#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
generate/templates/partials/sync_function.cchttps://github.com/nodegit/nodegit/pull/977/files#diff-7e46711f90e3a938b09d4bcdae2249b1b8811f3511280569536d86aa8ee250c6
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/templates/partials/sync_function.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-7e46711f90e3a938b09d4bcdae2249b1b8811f3511280569536d86aa8ee250c6
https://github.com/nodegit/nodegit/pull/977/files#diff-7e46711f90e3a938b09d4bcdae2249b1b8811f3511280569536d86aa8ee250c6
generate/templates/templates/nodegit.cchttps://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/generate/templates/templates/nodegit.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
https://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
https://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
https://github.com/nodegit/nodegit/pull/977/files#diff-ff2801d101275eadff8392f42e01554dab68f651d82524b1840170daa6499696
test/runner.jshttps://github.com/nodegit/nodegit/pull/977/files#diff-2bc5c0e9cd0b0a21bfb20936a87acac24c440036f4733702f1a262923d02e5cf
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/test/runner.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-2bc5c0e9cd0b0a21bfb20936a87acac24c440036f4733702f1a262923d02e5cf
https://github.com/nodegit/nodegit/pull/977/files#diff-2bc5c0e9cd0b0a21bfb20936a87acac24c440036f4733702f1a262923d02e5cf
test/tests/index.jshttps://github.com/nodegit/nodegit/pull/977/files#diff-96573bdf80e231a9f89bbf0461eb41f9f3efb144eaae1c0ca05a62335844106b
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/test/tests/index.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-96573bdf80e231a9f89bbf0461eb41f9f3efb144eaae1c0ca05a62335844106b
https://github.com/nodegit/nodegit/pull/977/files#diff-96573bdf80e231a9f89bbf0461eb41f9f3efb144eaae1c0ca05a62335844106b
test/tests/repository.jshttps://github.com/nodegit/nodegit/pull/977/files#diff-feb15c59eac6e4328b32814141af56c3951c219675a40cf471e60007cfd0d54d
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/test/tests/repository.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-feb15c59eac6e4328b32814141af56c3951c219675a40cf471e60007cfd0d54d
https://github.com/nodegit/nodegit/pull/977/files#diff-feb15c59eac6e4328b32814141af56c3951c219675a40cf471e60007cfd0d54d
test/tests/thread_safety.jshttps://github.com/nodegit/nodegit/pull/977/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
View file https://github.com/srajko/nodegit/blob/a0d546cec3cd7b56d5d28e25b57d5fa4fd9b2017/test/tests/thread_safety.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/977/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/977/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.