René's URL Explorer Experiment


Title: Make Ignore.pathIsIgnored async by joshaber · Pull Request #970 · nodegit/nodegit · GitHub

Open Graph Title: Make Ignore.pathIsIgnored async by joshaber · Pull Request #970 · nodegit/nodegit

X Title: Make Ignore.pathIsIgnored async by joshaber · Pull Request #970 · nodegit/nodegit

Description: Since it’s potentially doing IO and touching global state, it should be async.

Open Graph Description: Since it’s potentially doing IO and touching global state, it should be async.

X Description: Since it’s potentially doing IO and touching global state, it should be async.

Opengraph URL: https://github.com/nodegit/nodegit/pull/970

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35fe7f4b-453b-1650-9a45-850a1459b2e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB60:3D6499:152FBB:1B28AF:69741FCA
html-safe-nonce74b8712ea715dbf2a2f31062cc319bce2d8645fb638a3c16e150a3ca91e65281
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjYwOjNENjQ5OToxNTJGQkI6MUIyOEFGOjY5NzQxRkNBIiwidmlzaXRvcl9pZCI6IjIyODIxNzEzNzYwNDA0MTkyNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc19219a80a88abb92a6e1b5409a2a1f2bc9b628b21e044792ece3b9bc70b07fd
hovercard-subject-tagpull_request:64174317
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/970/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b79ad16376bc6b0c9d8905790c3a789ab4eafbedc8b83c5f21d0b1a19a7a288a/nodegit/nodegit/pull/970
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b79ad16376bc6b0c9d8905790c3a789ab4eafbedc8b83c5f21d0b1a19a7a288a/nodegit/nodegit/pull/970
og:image:altSince it’s potentially doing IO and touching global state, it should be async.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoshaber
hostnamegithub.com
expected-hostnamegithub.com
None447dc9917c3d68d647a01abfdefe55ec7ee1785922136c1d8395dbb3ab6d57b9
turbo-cache-controlno-preview
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8dad7bdfecbe3eaa97ac4e632d6b47e2b23e81d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/970#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F970
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F970
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/970
Reloadhttps://github.com/nodegit/nodegit/pull/970
Reloadhttps://github.com/nodegit/nodegit/pull/970
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 697 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 19 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects 0 https://github.com/nodegit/nodegit/projects
Security 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodegit/nodegit/pull/970#issue-comment-box
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
async-path-is-ignoredhttps://github.com/nodegit/nodegit/tree/async-path-is-ignored
Make Ignore.pathIsIgnored async https://github.com/nodegit/nodegit/pull/970#top
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
async-path-is-ignoredhttps://github.com/nodegit/nodegit/tree/async-path-is-ignored
Conversation 8 https://github.com/nodegit/nodegit/pull/970
Commits 2 https://github.com/nodegit/nodegit/pull/970/commits
Checks 0 https://github.com/nodegit/nodegit/pull/970/checks
Files changed https://github.com/nodegit/nodegit/pull/970/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#issue-143525781
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
joshaberhttps://github.com/joshaber
March 25, 2016 11:34https://github.com/nodegit/nodegit/pull/970#commits-pushed-1ad0ef2
https://github.com/joshaber
#Async4Lyfehttps://github.com/nodegit/nodegit/pull/970/commits/1ad0ef25bb5aa12f362abbcd744129cc4f087153
1ad0ef2https://github.com/nodegit/nodegit/pull/970/commits/1ad0ef25bb5aa12f362abbcd744129cc4f087153
https://github.com/joshaber
Update the test.https://github.com/nodegit/nodegit/pull/970/commits/ffec49b3dcdb564547946d6e17bff3d766e002bb
ffec49bhttps://github.com/nodegit/nodegit/pull/970/commits/ffec49b3dcdb564547946d6e17bff3d766e002bb
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
in progress https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#event-603133825
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 25, 2016 https://github.com/nodegit/nodegit/pull/970#ref-pullrequest-143518696
Less disk IO atom/atom#11277 https://github.com/atom/atom/pull/11277
nathansobohttps://github.com/nathansobo
Mar 25, 2016 https://github.com/nodegit/nodegit/pull/970#discussion-diff-57462869
View reviewed changes https://github.com/nodegit/nodegit/pull/970/files/ffec49b3dcdb564547946d6e17bff3d766e002bb#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
generate/input/descriptor.jsonhttps://github.com/nodegit/nodegit/pull/970/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
nathansobohttps://github.com/nathansobo
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#discussion_r57462869
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
joshaberhttps://github.com/joshaber
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#discussion_r57463622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
nathansobohttps://github.com/nathansobo
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#discussion_r57465629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
tbranyenhttps://github.com/tbranyen
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#discussion_r57483251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.com/joshaber
joshaberhttps://github.com/joshaber
ready https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3Aready
in progress https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#event-603318738
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 25, 2016https://github.com/nodegit/nodegit/pull/970#issuecomment-201525140
https://cloud.githubusercontent.com/assets/867780/14054577/88a02982-f297-11e5-96c4-700f1bd0b6a2.png
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 28, 2016https://github.com/nodegit/nodegit/pull/970#issuecomment-202502708
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 28, 2016https://github.com/nodegit/nodegit/pull/970#issuecomment-202504048
@joshaberhttps://github.com/joshaber
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
a32265chttps://github.com/nodegit/nodegit/commit/a32265ce4437b69de107b40050a925dd34c7da7c
Mar 28, 2016https://github.com/nodegit/nodegit/pull/970#event-605515734
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
March 28, 2016 17:48https://github.com/nodegit/nodegit/pull/970#event-605515783
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
ready https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3Aready
Mar 28, 2016https://github.com/nodegit/nodegit/pull/970#event-605515851
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 28, 2016https://github.com/nodegit/nodegit/pull/970#issuecomment-202505957
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F970
Please reload this pagehttps://github.com/nodegit/nodegit/pull/970
https://github.com/joshaber
https://github.com/johnhaley81
https://github.com/nathansobo
https://github.com/tbranyen
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.