René's URL Explorer Experiment


Title: Switch from strdup to memcpy to faithfully copy all bytes and prevent a crash in some cases. by tylerchurch · Pull Request #966 · nodegit/nodegit · GitHub

Open Graph Title: Switch from strdup to memcpy to faithfully copy all bytes and prevent a crash in some cases. by tylerchurch · Pull Request #966 · nodegit/nodegit

X Title: Switch from strdup to memcpy to faithfully copy all bytes and prevent a crash in some cases. by tylerchurch · Pull Request #966 · nodegit/nodegit

Description: This is a pull request to fix the issue I created over here: #965 To summarize over here why I'm making these changes: strdup expects a C-style null-terminated string, but sometimes we're using no...

Open Graph Description: This is a pull request to fix the issue I created over here: #965 To summarize over here why I'm making these changes: strdup expects a C-style null-terminated string, but sometimes we're ...

X Description: This is a pull request to fix the issue I created over here: #965 To summarize over here why I'm making these changes: strdup expects a C-style null-terminated string, but sometimes we&...

Opengraph URL: https://github.com/nodegit/nodegit/pull/966

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:32d86cd9-180d-0a8e-8ed2-eb171b7cfb98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD83A:3CECC8:51E1D4A:6B5CB67:6974C209
html-safe-nonced8a67f515e5815eb03acd227e5ab801c76d942778c4fea7d882d40bd4fcef984
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODNBOjNDRUNDODo1MUUxRDRBOjZCNUNCNjc6Njk3NEMyMDkiLCJ2aXNpdG9yX2lkIjoiNTA1MDQzNDUzMDI1OTAyNjQ0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd2365044841f8998f65d53a79f76929fec4fbaa7a5720ca645a39d977ce5c17
hovercard-subject-tagpull_request:63982652
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/966/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7dd30f19d134f80160525b36ee241c357f232dedca2a8059c5fc559e60502116/nodegit/nodegit/pull/966
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7dd30f19d134f80160525b36ee241c357f232dedca2a8059c5fc559e60502116/nodegit/nodegit/pull/966
og:image:altThis is a pull request to fix the issue I created over here: #965 To summarize over here why I'm making these changes: strdup expects a C-style null-terminated string, but sometimes we're ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametylerchurch
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/966#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F966
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F966
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/966
Reloadhttps://github.com/nodegit/nodegit/pull/966
Reloadhttps://github.com/nodegit/nodegit/pull/966
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 697 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 19 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects 0 https://github.com/nodegit/nodegit/projects
Security 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodegit/nodegit/pull/966#issue-comment-box
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tylerchurch:fix-strdup-crashhttps://github.com/tylerchurch/nodegit/tree/fix-strdup-crash
Switch from strdup to memcpy to faithfully copy all bytes and prevent a crash in some cases. https://github.com/nodegit/nodegit/pull/966#top
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tylerchurch:fix-strdup-crashhttps://github.com/tylerchurch/nodegit/tree/fix-strdup-crash
Conversation 4 https://github.com/nodegit/nodegit/pull/966
Commits 2 https://github.com/nodegit/nodegit/pull/966/commits
Checks 0 https://github.com/nodegit/nodegit/pull/966/checks
Files changed https://github.com/nodegit/nodegit/pull/966/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
https://github.com/tylerchurch
tylerchurchhttps://github.com/tylerchurch
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#issue-143131569
#965https://github.com/nodegit/nodegit/issues/965
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/tylerc
Switch from strdup to memcpy to faithfully copy all bytes and prevent…https://github.com/nodegit/nodegit/pull/966/commits/74e85a5c7bf7b2b4c9098481f6c6a042e3d8826d
74e85a5https://github.com/nodegit/nodegit/pull/966/commits/74e85a5c7bf7b2b4c9098481f6c6a042e3d8826d
https://github.com/tylerchurch
tylerchurchhttps://github.com/tylerchurch
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#issuecomment-200632784
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#issuecomment-200657170
@tylerchurchhttps://github.com/tylerchurch
#958https://github.com/nodegit/nodegit/pull/958
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#issuecomment-200663266
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/tylerc
Add some comments explaining the switch between strdup and malloc/mem…https://github.com/nodegit/nodegit/pull/966/commits/c866391086889e5b4cdfdec745ecf808ea1b64e6
c866391https://github.com/nodegit/nodegit/pull/966/commits/c866391086889e5b4cdfdec745ecf808ea1b64e6
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#issuecomment-200902314
@tylerchurchhttps://github.com/tylerchurch
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
033e684https://github.com/nodegit/nodegit/commit/033e684b271e8da3b0924ebfc713d273e7e0e5a5
Mar 24, 2016https://github.com/nodegit/nodegit/pull/966#event-601953613
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 24, 2016 https://github.com/nodegit/nodegit/pull/966#ref-issue-143129662
Diff.blobToBuffer crashes the node process if given a file that contains null characters #965 https://github.com/nodegit/nodegit/issues/965
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F966
Please reload this pagehttps://github.com/nodegit/nodegit/pull/966
https://github.com/tylerchurch
https://github.com/johnhaley81
https://github.com/tylerc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.