René's URL Explorer Experiment


Title: diff.blobToBuffer: Fix passing in Buffers instead of strings. by tylerchurch · Pull Request #964 · nodegit/nodegit · GitHub

Open Graph Title: diff.blobToBuffer: Fix passing in Buffers instead of strings. by tylerchurch · Pull Request #964 · nodegit/nodegit

X Title: diff.blobToBuffer: Fix passing in Buffers instead of strings. by tylerchurch · Pull Request #964 · nodegit/nodegit

Description: Been seeing some strageness with blobToBuffer (see the issue I created over here, for example: #963 ) This pull requests fixes the fact that if you pass in an object of type Buffer, it is turned into a string, but then that string is never used (and because of the way the C bindings are written, because the object isn't of type string, it gets turned into a null, and you get a diff that looks like there's no content in the file.)

Open Graph Description: Been seeing some strageness with blobToBuffer (see the issue I created over here, for example: #963 ) This pull requests fixes the fact that if you pass in an object of type Buffer, it is turned in...

X Description: Been seeing some strageness with blobToBuffer (see the issue I created over here, for example: #963 ) This pull requests fixes the fact that if you pass in an object of type Buffer, it is turned in...

Opengraph URL: https://github.com/nodegit/nodegit/pull/964

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f1db9600-770a-b252-58e4-c9edcc6b5634
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DB2:31363C:4A29C1:60939E:69757573
html-safe-nonce2f3fef4414e00d656cbeea7483ee03d04f66520fe142b2ec51f69b44c8ac2792
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REIyOjMxMzYzQzo0QTI5QzE6NjA5MzlFOjY5NzU3NTczIiwidmlzaXRvcl9pZCI6IjE3OTU1NzYxNjE1MDE1NDE3NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e1ba792cc5b07217bfd410da21ce4a862777a31790005f9856383b032575483
hovercard-subject-tagpull_request:63968168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/964/files
twitter:imagehttps://avatars.githubusercontent.com/u/2380817?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2380817?s=400&v=4
og:image:altBeen seeing some strageness with blobToBuffer (see the issue I created over here, for example: #963 ) This pull requests fixes the fact that if you pass in an object of type Buffer, it is turned in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/964/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F964%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F964%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/964/files
Reloadhttps://github.com/nodegit/nodegit/pull/964/files
Reloadhttps://github.com/nodegit/nodegit/pull/964/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 697 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 19 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects 0 https://github.com/nodegit/nodegit/projects
Security 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tylerchurch:patch-2https://github.com/tylerchurch/nodegit/tree/patch-2
Conversation 1 https://github.com/nodegit/nodegit/pull/964
Commits 2 https://github.com/nodegit/nodegit/pull/964/commits
Checks 0 https://github.com/nodegit/nodegit/pull/964/checks
Files changed https://github.com/nodegit/nodegit/pull/964/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/964/files
diff.blobToBuffer: Fix passing in Buffers instead of strings. https://github.com/nodegit/nodegit/pull/964/files#top
Show all changes 2 commits https://github.com/nodegit/nodegit/pull/964/files
da71a29 diff.blobToBuffer: Fix passing in Buffers instead of strings. tylerchurch Mar 23, 2016 https://github.com/nodegit/nodegit/pull/964/commits/da71a29de2e37d222c2559090deb66725fcb0a7a
a87b573 Diff.blobToBuffer: consistently use Buffer.byteLength tylerchurch Mar 24, 2016 https://github.com/nodegit/nodegit/pull/964/commits/a87b573f00b97842737abc41d8360bbc76a86f53
Clear filters https://github.com/nodegit/nodegit/pull/964/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/964/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/964/files
lib/diff.jshttps://github.com/nodegit/nodegit/pull/964/files#diff-255fa475ce6fc94faaeeb38631fca99ba9b9ca9a5ce31eb0c7f321d0a668e332
View file https://github.com/tylerchurch/nodegit/blob/a87b573f00b97842737abc41d8360bbc76a86f53/lib/diff.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/964/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/964/files#diff-255fa475ce6fc94faaeeb38631fca99ba9b9ca9a5ce31eb0c7f321d0a668e332
https://github.com/nodegit/nodegit/pull/964/files#diff-255fa475ce6fc94faaeeb38631fca99ba9b9ca9a5ce31eb0c7f321d0a668e332
https://github.com/nodegit/nodegit/pull/964/files#diff-255fa475ce6fc94faaeeb38631fca99ba9b9ca9a5ce31eb0c7f321d0a668e332
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.