Title: Use type safe pointer instead of void * for New by srajko · Pull Request #957 · nodegit/nodegit · GitHub
Open Graph Title: Use type safe pointer instead of void * for New by srajko · Pull Request #957 · nodegit/nodegit
X Title: Use type safe pointer instead of void * for New by srajko · Pull Request #957 · nodegit/nodegit
Description: Ran into this as part of #955. Changing the raw pointer from void * to const {{ cType }} * to add type safety. The change actually caught a problem in struct_content.cc where we were sometimes taking the address of a pointer and passing that in instead of the pointer (for git_checkout_options.baseline, we were sending in a git_tree ** instead of a git_tree * to New).
Open Graph Description: Ran into this as part of #955. Changing the raw pointer from void * to const {{ cType }} * to add type safety. The change actually caught a problem in struct_content.cc where we were sometimes tak...
X Description: Ran into this as part of #955. Changing the raw pointer from void * to const {{ cType }} * to add type safety. The change actually caught a problem in struct_content.cc where we were sometimes tak...
Opengraph URL: https://github.com/nodegit/nodegit/pull/957
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:47895ccc-7836-ed3b-eec5-a4f820aef8d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E006:1BDD2D:16C50EC:1D0C120:69756827 |
| html-safe-nonce | c614fd9b2d3e946024b3d03749957e180890dbd7a765d00333ec233119e26a36 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDA2OjFCREQyRDoxNkM1MEVDOjFEMEMxMjA6Njk3NTY4MjciLCJ2aXNpdG9yX2lkIjoiNjkwOTY5Mjk0MzE4MzIxMDUzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c2f4e9de9383ed256e7f08f4c7152b9f5e9808113f145242738fbb7277dadf5d |
| hovercard-subject-tag | pull_request:63409716 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/957/files |
| twitter:image | https://avatars.githubusercontent.com/u/291007?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/291007?s=400&v=4 |
| og:image:alt | Ran into this as part of #955. Changing the raw pointer from void * to const {{ cType }} * to add type safety. The change actually caught a problem in struct_content.cc where we were sometimes tak... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width