René's URL Explorer Experiment


Title: Fix patch crash by joshaber · Pull Request #945 · nodegit/nodegit · GitHub

Open Graph Title: Fix patch crash by joshaber · Pull Request #945 · nodegit/nodegit

X Title: Fix patch crash by joshaber · Pull Request #945 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: Libgit2 documents that content isn’t NUL-terminated, so we can’t call strlen on it. If we do, we’ll probably crash.

X Description: Libgit2 documents that content isn’t NUL-terminated, so we can’t call strlen on it. If we do, we’ll probably crash.

Opengraph URL: https://github.com/nodegit/nodegit/pull/945

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43db7745-e053-8bb6-de8a-75d3b435b4a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4D6:246CE:68972C7:8A224EA:6A5DE1EC
html-safe-nonce7223488d14ab0606f7564c3ba4cee8674af6111cbd338f8fbb71414577859741
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEQ2OjI0NkNFOjY4OTcyQzc6OEEyMjRFQTo2QTVERTFFQyIsInZpc2l0b3JfaWQiOiIzNDI4ODM3MTQ5MTI2ODEyMTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac73479c74c9f1df1ee597de7325cfd209b1e54714e2e634ca463dbd3bbdda316c
hovercard-subject-tagpull_request:62247453
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/945/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7d7ac4301c1613c8147d5378feb2a7b0152bb0233822e609e286b37c80b139a1/nodegit/nodegit/pull/945
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d7ac4301c1613c8147d5378feb2a7b0152bb0233822e609e286b37c80b139a1/nodegit/nodegit/pull/945
og:image:altLibgit2 documents that content isn’t NUL-terminated, so we can’t call strlen on it. If we do, we’ll probably crash.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoshaber
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/945#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F945
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F945
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/945
Reloadhttps://github.com/nodegit/nodegit/pull/945
Reloadhttps://github.com/nodegit/nodegit/pull/945
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
implausiblehttps://github.com/implausible
masterhttps://github.com/nodegit/nodegit/tree/master
fix-patch-crashhttps://github.com/nodegit/nodegit/tree/fix-patch-crash
Conversationhttps://github.com/nodegit/nodegit/pull/945
Commits3 (3)https://github.com/nodegit/nodegit/pull/945/commits
Checkshttps://github.com/nodegit/nodegit/pull/945/checks
Files changedhttps://github.com/nodegit/nodegit/pull/945/files
Fix patch crashhttps://github.com/nodegit/nodegit/pull/945#top
implausiblehttps://github.com/implausible
masterhttps://github.com/nodegit/nodegit/tree/master
fix-patch-crashhttps://github.com/nodegit/nodegit/tree/fix-patch-crash
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issue-139612151
Libgit2 documentshttps://github.com/libgit2/libgit2/blob/d8f721592817cb300339c827579bc545844b276f/include/git2/diff.h#L555
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
joshaberhttps://github.com/joshaber
March 9, 2016 10:39https://github.com/nodegit/nodegit/pull/945#commits-pushed-3b5e9fb
https://github.com/joshaber
Bail if there's an error.https://github.com/nodegit/nodegit/pull/945/commits/3b5e9fb3c92d2533fccf387badf87e75b2ce4c7b
3b5e9fbhttps://github.com/nodegit/nodegit/pull/945/commits/3b5e9fb3c92d2533fccf387badf87e75b2ce4c7b
https://github.com/joshaber
Use the content length libgit2 gives us.https://github.com/nodegit/nodegit/pull/945/commits/049b5013d1a2fdc917c4ac0087bd2c655e062eec
049b501https://github.com/nodegit/nodegit/pull/945/commits/049b5013d1a2fdc917c4ac0087bd2c655e062eec
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
in progress https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#event-583460788
joshaberhttps://github.com/joshaber
Mar 9, 2016 https://github.com/nodegit/nodegit/pull/945#discussion-diff-55537130
View reviewed changes https://github.com/nodegit/nodegit/pull/945/files/049b5013d1a2fdc917c4ac0087bd2c655e062eec#diff-86847be507a9a918431f04c09595e3c558ebe3dcdb186a50f4f2965836a055d2
generate/templates/manual/src/convenient_patch.cchttps://github.com/nodegit/nodegit/pull/945/files#diff-86847be507a9a918431f04c09595e3c558ebe3dcdb186a50f4f2965836a055d2
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55537130
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55546580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55548119
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55548355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55549481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55551434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#discussion_r55551537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194354379
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/joshaber
*sigh* Windows.https://github.com/nodegit/nodegit/pull/945/commits/a98ae5cc8148e32db84478b79ae4b8050e78f2d2
a98ae5chttps://github.com/nodegit/nodegit/pull/945/commits/a98ae5cc8148e32db84478b79ae4b8050e78f2d2
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194380533
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194384250
@implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/implausible
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194403390
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
implausiblehttps://github.com/implausible
Mar 9, 2016 https://github.com/nodegit/nodegit/pull/945#ref-commit-bb9d785
https://github.com/implausible
Merge pull requesthttps://github.com/nodegit/nodegit/commit/bb9d78504b92ee296836ddeddf9284cd7f4ca41d
#945https://github.com/nodegit/nodegit/pull/945
from nodegit/fix-patch-crashhttps://github.com/nodegit/nodegit/commit/bb9d78504b92ee296836ddeddf9284cd7f4ca41d
bb9d785https://github.com/nodegit/nodegit/commit/bb9d78504b92ee296836ddeddf9284cd7f4ca41d
https://github.com/implausible
implausiblehttps://github.com/implausible
bb9d785https://github.com/nodegit/nodegit/commit/bb9d78504b92ee296836ddeddf9284cd7f4ca41d
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#event-583610092
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
in progress https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#event-583610157
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
March 9, 2016 17:12https://github.com/nodegit/nodegit/pull/945#event-583613273
https://github.com/implausible
implausiblehttps://github.com/implausible
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194408186
@joshaberhttps://github.com/joshaber
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 9, 2016https://github.com/nodegit/nodegit/pull/945#issuecomment-194418913
@implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Mar 9, 2016 https://github.com/nodegit/nodegit/pull/945#ref-pullrequest-139650797
Update nodegit atom/atom#11115 https://github.com/atom/atom/pull/11115
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F945
Please reload this pagehttps://github.com/nodegit/nodegit/pull/945
https://github.com/joshaber
https://github.com/johnhaley81
https://github.com/implausible
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.