Title: Throttle callbacks (again) + crash fix by srajko · Pull Request #944 · nodegit/nodegit · GitHub
Open Graph Title: Throttle callbacks (again) + crash fix by srajko · Pull Request #944 · nodegit/nodegit
X Title: Throttle callbacks (again) + crash fix by srajko · Pull Request #944 · nodegit/nodegit
Description: This reverts the removal of throttling, and adds two changes that seem to resolve the crash. The likely fix is 1e585ea, which restores some logic I omitted in the refactoring, thinking it should not make a difference... but it looks like it did. I am a little worried about the state of the raw object making a difference after its wrapper has been destroyed, but maybe I'm just missing the big picture of what's happening here. In any case, the logic matches what we were doing before, and no crash is better than crash.
Open Graph Description: This reverts the removal of throttling, and adds two changes that seem to resolve the crash. The likely fix is 1e585ea, which restores some logic I omitted in the refactoring, thinking it should n...
X Description: This reverts the removal of throttling, and adds two changes that seem to resolve the crash. The likely fix is 1e585ea, which restores some logic I omitted in the refactoring, thinking it should n...
Opengraph URL: https://github.com/nodegit/nodegit/pull/944
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b47021d5-3002-cea6-91de-0b6e8b71bb39 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A766:378B91:65EC99:89F9E5:6A5FCFDC |
| html-safe-nonce | 044aefae74e28480c9118d4450557aa318251581ef0d2c0258d0d916dde2e34d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzY2OjM3OEI5MTo2NUVDOTk6ODlGOUU1OjZBNUZDRkRDIiwidmlzaXRvcl9pZCI6IjkxMjkzMDk2MDQ4NjIyMTgyMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7adc87c73cb5616373d25e74a5b4443c1eff1b71c590b2867e22318f7a637ccd |
| hovercard-subject-tag | pull_request:62163078 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/944/files |
| twitter:image | https://avatars.githubusercontent.com/u/291007?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/291007?s=400&v=4 |
| og:image:alt | This reverts the removal of throttling, and adds two changes that seem to resolve the crash. The likely fix is 1e585ea, which restores some logic I omitted in the refactoring, thinking it should n... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 53a28a7799cbf673993ab89fc44869fea4c4a6545a861a4d1445e83e8d03aabd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dc08399f879d576f0edbb8c52a0a1a30d498b203 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width