Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit · GitHub
Open Graph Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit
X Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit
Description: Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries => ...))
Open Graph Description: Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ...
X Description: Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ...
Opengraph URL: https://github.com/nodegit/nodegit/pull/929
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:70354de5-1353-fa02-b262-0e8673ab3835 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 935A:20C071:85A6C8:B149CF:6A5FD752 |
| html-safe-nonce | 0e8678a2670dfeef940159c8ea76cb880da9835e5691d7045e4e93b635e48e33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzVBOjIwQzA3MTo4NUE2Qzg6QjE0OUNGOjZBNUZENzUyIiwidmlzaXRvcl9pZCI6IjgwMjA5ODUxODk1MjYxMzI1NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b3caf0595d71deb78d5a27f39586dad0c171083a93227fbc6b5ac213d32da6e8 |
| hovercard-subject-tag | pull_request:61129443 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/929/files |
| twitter:image | https://avatars.githubusercontent.com/u/899916?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/899916?s=400&v=4 |
| og:image:alt | Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2a1904016bf220ad1311da188567b50f2c83d69b89a554fd8b017417589fbe29 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f83c469daaa92993df0b1f479d525995ec8cc172 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width