René's URL Explorer Experiment


Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit · GitHub

Open Graph Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit

X Title: Fix tree.walk() and add test by jdgarcia · Pull Request #929 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ...

X Description: Fix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ...

Opengraph URL: https://github.com/nodegit/nodegit/pull/929

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f305c899-7556-a467-0c23-c84f9743cb88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5EC:296588:594F4B1:7B9DC14:6A5E5FD4
html-safe-nonce0f67e7c226915f9e80d5fa2a29da2746fb16c5c61b7e195e9a296749bda46ab2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUVDOjI5NjU4ODo1OTRGNEIxOjdCOURDMTQ6NkE1RTVGRDQiLCJ2aXNpdG9yX2lkIjoiNjI2NzQwOTUyNzg2NjI4NjAzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac943e0711a6e010e7b0003404e7184513af5078b70183833abe42b79a1b765b2a
hovercard-subject-tagpull_request:61129443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/929/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8ef0f5a9b1a65e4035d52ef9b2daa341fe982dbcf4a908ecb1f3e307a3f69828/nodegit/nodegit/pull/929
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ef0f5a9b1a65e4035d52ef9b2daa341fe982dbcf4a908ecb1f3e307a3f69828/nodegit/nodegit/pull/929
og:image:altFix for #928 This is the non-api breaking change. How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejdgarcia
hostnamegithub.com
expected-hostnamegithub.com
None5684292e6b02f9c72a31f9bc29d1fa47afbeda5424e76fb5f0b7c08766757177
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released151d247da13e8abadf6fd7f5a5f8659dae9a8d0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/929#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F929
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F929
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/929
Reloadhttps://github.com/nodegit/nodegit/pull/929
Reloadhttps://github.com/nodegit/nodegit/pull/929
Please reload this pagehttps://github.com/nodegit/nodegit/pull/929
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
tree-walk-fixhttps://github.com/nodegit/nodegit/tree/tree-walk-fix
Conversationhttps://github.com/nodegit/nodegit/pull/929
Commits6 (6)https://github.com/nodegit/nodegit/pull/929/commits
Checkshttps://github.com/nodegit/nodegit/pull/929/checks
Files changedhttps://github.com/nodegit/nodegit/pull/929/files
Fix tree.walk() and add testhttps://github.com/nodegit/nodegit/pull/929#top
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
tree-walk-fixhttps://github.com/nodegit/nodegit/tree/tree-walk-fix
https://github.com/jdgarcia
jdgarciahttps://github.com/jdgarcia
Feb 29, 2016https://github.com/nodegit/nodegit/pull/929#issue-137345707
#928https://github.com/nodegit/nodegit/issues/928
Please reload this pagehttps://github.com/nodegit/nodegit/pull/929
https://github.com/jdgarcia
jdgarciahttps://github.com/jdgarcia
force-pushedhttps://github.com/nodegit/nodegit/compare/2aa8218356f9baeffb2ff7d4d32210354ef26979..927d1f496d56456a63e903ffad28ee8dbcc73134
2aa8218https://github.com/nodegit/nodegit/commit/2aa8218356f9baeffb2ff7d4d32210354ef26979
927d1f4https://github.com/nodegit/nodegit/commit/927d1f496d56456a63e903ffad28ee8dbcc73134
Compare https://github.com/nodegit/nodegit/compare/2aa8218356f9baeffb2ff7d4d32210354ef26979..927d1f496d56456a63e903ffad28ee8dbcc73134
February 29, 2016 22:55https://github.com/nodegit/nodegit/pull/929#event-572032141
jdgarciahttps://github.com/jdgarcia
February 29, 2016 15:55https://github.com/nodegit/nodegit/pull/929#commits-pushed-3d60252
https://github.com/jdgarcia
fix tree.walk() and add testhttps://github.com/nodegit/nodegit/pull/929/commits/3d6025281ebac4022a9237da1a5ecda51fc1e693
3d60252https://github.com/nodegit/nodegit/pull/929/commits/3d6025281ebac4022a9237da1a5ecda51fc1e693
https://github.com/jdgarcia
make sure both entry event and end event entries are what we expecthttps://github.com/nodegit/nodegit/pull/929/commits/123e2db21e2a7c6247c09966fd4b936692a930bd
123e2dbhttps://github.com/nodegit/nodegit/pull/929/commits/123e2db21e2a7c6247c09966fd4b936692a930bd
https://github.com/jdgarcia
make sure test file name is correct on all OSshttps://github.com/nodegit/nodegit/pull/929/commits/952b6b21098676fe4e8d43ba662e6ab24c24d7f0
952b6b2https://github.com/nodegit/nodegit/pull/929/commits/952b6b21098676fe4e8d43ba662e6ab24c24d7f0
https://github.com/jdgarcia
jdgarciahttps://github.com/jdgarcia
force-pushedhttps://github.com/nodegit/nodegit/compare/927d1f496d56456a63e903ffad28ee8dbcc73134..952b6b21098676fe4e8d43ba662e6ab24c24d7f0
927d1f4https://github.com/nodegit/nodegit/commit/927d1f496d56456a63e903ffad28ee8dbcc73134
952b6b2https://github.com/nodegit/nodegit/commit/952b6b21098676fe4e8d43ba662e6ab24c24d7f0
Compare https://github.com/nodegit/nodegit/compare/927d1f496d56456a63e903ffad28ee8dbcc73134..952b6b21098676fe4e8d43ba662e6ab24c24d7f0
February 29, 2016 22:55https://github.com/nodegit/nodegit/pull/929#event-572032425
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Mar 1, 2016 https://github.com/nodegit/nodegit/pull/929#ref-issue-137345339
Tree.walk() does not return the correct entries on "end" #928 https://github.com/nodegit/nodegit/issues/928
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
ready https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3Aready
Mar 1, 2016https://github.com/nodegit/nodegit/pull/929#event-573094000
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
jdgarciahttps://github.com/jdgarcia
Mar 1, 2016https://github.com/nodegit/nodegit/pull/929#event-573094480
March 1, 2016 09:57https://github.com/nodegit/nodegit/pull/929#commits-pushed-99149c8
Use Set in Tree#walk for storing entrieshttps://github.com/nodegit/nodegit/pull/929/commits/99149c8ce2eefacdd521253f39edc1735ad1c406
99149c8https://github.com/nodegit/nodegit/pull/929/commits/99149c8ce2eefacdd521253f39edc1735ad1c406
Fix linterhttps://github.com/nodegit/nodegit/pull/929/commits/14b2c601e390fbd587dfd4aa69fafec610fae4bf
14b2c60https://github.com/nodegit/nodegit/pull/929/commits/14b2c601e390fbd587dfd4aa69fafec610fae4bf
Fix testshttps://github.com/nodegit/nodegit/pull/929/commits/0e64add66055f7510a0b0e428abbe4fb4f8919d4
0e64addhttps://github.com/nodegit/nodegit/pull/929/commits/0e64add66055f7510a0b0e428abbe4fb4f8919d4
johnhaley81https://github.com/johnhaley81
Mar 1, 2016 https://github.com/nodegit/nodegit/pull/929#ref-commit-2caee3c
https://github.com/johnhaley81
Merge pull requesthttps://github.com/nodegit/nodegit/commit/2caee3cefb64ce693de92b16d0281c508921f470
#929https://github.com/nodegit/nodegit/pull/929
from nodegit/tree-walk-fixhttps://github.com/nodegit/nodegit/commit/2caee3cefb64ce693de92b16d0281c508921f470
2caee3chttps://github.com/nodegit/nodegit/commit/2caee3cefb64ce693de92b16d0281c508921f470
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
2caee3chttps://github.com/nodegit/nodegit/commit/2caee3cefb64ce693de92b16d0281c508921f470
Mar 1, 2016https://github.com/nodegit/nodegit/pull/929#event-573461845
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
ready https://github.com/nodegit/nodegit/issues?q=state%3Aopen%20label%3Aready
Mar 1, 2016https://github.com/nodegit/nodegit/pull/929#event-573461922
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
March 1, 2016 18:32https://github.com/nodegit/nodegit/pull/929#event-573461943
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F929
https://github.com/jdgarcia
jdgarcia https://github.com/jdgarcia
Please reload this pagehttps://github.com/nodegit/nodegit/pull/929
https://github.com/jdgarcia
https://github.com/johnhaley81
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.