Title: Fix callback out values in callbacks from C++ by johnhaley81 · Pull Request #921 · nodegit/nodegit · GitHub
Open Graph Title: Fix callback out values in callbacks from C++ by johnhaley81 · Pull Request #921 · nodegit/nodegit
X Title: Fix callback out values in callbacks from C++ by johnhaley81 · Pull Request #921 · nodegit/nodegit
Description: We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly. http://i.imgur.com/rB4Hux7.gif
Open Graph Description: We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly. http://i.im...
X Description: We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly. http://i.im...
Opengraph URL: https://github.com/nodegit/nodegit/pull/921
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d3f8ab11-6432-cbfd-baad-b26be704432a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F42:335C1A:789D4F:A38059:6A5FD7FF |
| html-safe-nonce | 7d8ceafc36c86cdc997ff90d946122fbefb90f3734806ab3d8196cbb96351a7c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjQyOjMzNUMxQTo3ODlENEY6QTM4MDU5OjZBNUZEN0ZGIiwidmlzaXRvcl9pZCI6Ijc0MTc4Nzg4NjM4NDUyNTEwNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ae287e13181ce87e4977cf0d1fc4b96a76addd773ee74f838c38e00fe9b9c1d1 |
| hovercard-subject-tag | pull_request:60585260 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/921/files |
| twitter:image | https://avatars.githubusercontent.com/u/867780?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/867780?s=400&v=4 |
| og:image:alt | We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly. http://i.im... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2a1904016bf220ad1311da188567b50f2c83d69b89a554fd8b017417589fbe29 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f83c469daaa92993df0b1f479d525995ec8cc172 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width