René's URL Explorer Experiment


Title: Clean mutexes as part of garbage collection cycle instead of uv_async by srajko · Pull Request #880 · nodegit/nodegit · GitHub

Open Graph Title: Clean mutexes as part of garbage collection cycle instead of uv_async by srajko · Pull Request #880 · nodegit/nodegit

X Title: Clean mutexes as part of garbage collection cycle instead of uv_async by srajko · Pull Request #880 · nodegit/nodegit

Description: Leaving the uv_async handle open was causing the node process to hang on exit. Cleaning up mutexes on garbage collection achieves the same goal (mutexes will get cleaned up at some point, when they are no longer needed), and avoids the issue. Using the GC is probably better performance-wise with thread safety enabled (mutex cleanup should be less frequent). With thread-safety disabled, the mutex cleanup gets skipped (though for simplicity, the GC callback is configured throughout - I imagine this has minimal performance impact). Fixes #866.

Open Graph Description: Leaving the uv_async handle open was causing the node process to hang on exit. Cleaning up mutexes on garbage collection achieves the same goal (mutexes will get cleaned up at some point, when the...

X Description: Leaving the uv_async handle open was causing the node process to hang on exit. Cleaning up mutexes on garbage collection achieves the same goal (mutexes will get cleaned up at some point, when the...

Opengraph URL: https://github.com/nodegit/nodegit/pull/880

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:33cb8c3f-4584-f425-cf9e-b9474facacd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94AC:1B9505:9A21AE1:CFA4845:6A5E7EF4
html-safe-nonce1a257cc031fccb4b118e5516cddbd87f2df82cfe08c0f1fda1ad41fb9f18f7d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEFDOjFCOTUwNTo5QTIxQUUxOkNGQTQ4NDU6NkE1RTdFRjQiLCJ2aXNpdG9yX2lkIjoiMzc1NjcxMDg5NDE0MTE3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca7ffe60df8c79edeac486bda4d149a165f0a1cdcef048ae8b83c20bdf8c54df3
hovercard-subject-tagpull_request:57306480
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/880/files
twitter:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
og:image:altLeaving the uv_async handle open was causing the node process to hang on exit. Cleaning up mutexes on garbage collection achieves the same goal (mutexes will get cleaned up at some point, when the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None71950bbe6bf7e15662b868c102fed9d1682c29a05970d9b2daa2e4dd3522c52e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7514606601325843bc1c464d2d8bf5fe9af2c154
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/880/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F880%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F880%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/880/files
Reloadhttps://github.com/nodegit/nodegit/pull/880/files
Reloadhttps://github.com/nodegit/nodegit/pull/880/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/880/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
srajko:thread-safety-gchttps://github.com/srajko/nodegit/tree/thread-safety-gc
Conversation 1 https://github.com/nodegit/nodegit/pull/880
Commits 1 https://github.com/nodegit/nodegit/pull/880/commits
Checks 0 https://github.com/nodegit/nodegit/pull/880/checks
Files changed https://github.com/nodegit/nodegit/pull/880/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/880/files
Clean mutexes as part of garbage collection cycle instead of uv_async https://github.com/nodegit/nodegit/pull/880/files#top
Show all changes 1 commit https://github.com/nodegit/nodegit/pull/880/files
80371a1 Clean mutexes as part of garbage collection cycle instead of uv_async srajko Jan 27, 2016 https://github.com/nodegit/nodegit/pull/880/commits/80371a1c26c772b227cce0a1a64ce4fb5e57b9fb
Clear filters https://github.com/nodegit/nodegit/pull/880/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/880/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/880/files
lock_master.cc https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
thread_safety.js https://github.com/nodegit/nodegit/pull/880/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
generate/templates/manual/src/lock_master.cchttps://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
View file https://github.com/srajko/nodegit/blob/80371a1c26c772b227cce0a1a64ce4fb5e57b9fb/generate/templates/manual/src/lock_master.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/880/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
https://github.com/nodegit/nodegit/pull/880/files#diff-99343f9984cbb0cd51cbc0eacd0f7a50b7b5912ab860fc63ecf5dd285ab42960
test/tests/thread_safety.jshttps://github.com/nodegit/nodegit/pull/880/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
View file https://github.com/srajko/nodegit/blob/80371a1c26c772b227cce0a1a64ce4fb5e57b9fb/test/tests/thread_safety.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/880/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/880/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
https://github.com/nodegit/nodegit/pull/880/files#diff-cd92dc68de5f578cb118e2d6bd2cda98a8012dac93e0c37c797bcf6ccf197259
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.