René's URL Explorer Experiment


Title: Remove `Index#addAll` hack by johnhaley81 · Pull Request #875 · nodegit/nodegit · GitHub

Open Graph Title: Remove `Index#addAll` hack by johnhaley81 · Pull Request #875 · nodegit/nodegit

X Title: Remove `Index#addAll` hack by johnhaley81 · Pull Request #875 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: Now that libgit2/libgit2#2687 has landed we don't need our hack to speed up Index#addAll anymore. This fixes #751

X Description: Now that libgit2/libgit2#2687 has landed we don't need our hack to speed up Index#addAll anymore. This fixes #751

Opengraph URL: https://github.com/nodegit/nodegit/pull/875

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:59691164-444e-1296-1229-6db10a2beff9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA0A:3A2E8:2422F73:2F97290:6A5CB801
html-safe-nonce673fc5804fa86a3292037e1cb1b4b74a97b92ddd4489e057389ad925c6b41026
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTBBOjNBMkU4OjI0MjJGNzM6MkY5NzI5MDo2QTVDQjgwMSIsInZpc2l0b3JfaWQiOiIxMzU1ODMyNTUwNDgxNTA4MzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb2e75189d3ef2ef7c0348f25264f1f84396ea7c31e06f87c63c382bdfb1129a8
hovercard-subject-tagpull_request:56711033
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/875/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67c6394ed4248c240a021d1eb229bce4ef36d267866e9a3ba2815beeb89d8d82/nodegit/nodegit/pull/875
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67c6394ed4248c240a021d1eb229bce4ef36d267866e9a3ba2815beeb89d8d82/nodegit/nodegit/pull/875
og:image:altNow that libgit2/libgit2#2687 has landed we don't need our hack to speed up Index#addAll anymore. This fixes #751
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnhaley81
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/875#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F875
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F875
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/875
Reloadhttps://github.com/nodegit/nodegit/pull/875
Reloadhttps://github.com/nodegit/nodegit/pull/875
Please reload this pagehttps://github.com/nodegit/nodegit/pull/875
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
remove-index-add-all-hackhttps://github.com/nodegit/nodegit/tree/remove-index-add-all-hack
Conversationhttps://github.com/nodegit/nodegit/pull/875
Commits2 (2)https://github.com/nodegit/nodegit/pull/875/commits
Checkshttps://github.com/nodegit/nodegit/pull/875/checks
Files changedhttps://github.com/nodegit/nodegit/pull/875/files
Remove Index#addAll hackhttps://github.com/nodegit/nodegit/pull/875#top
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
remove-index-add-all-hackhttps://github.com/nodegit/nodegit/tree/remove-index-add-all-hack
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 21, 2016https://github.com/nodegit/nodegit/pull/875#issue-127857963
libgit2/libgit2#2687https://github.com/libgit2/libgit2/issues/2687
#751https://github.com/nodegit/nodegit/issues/751
Please reload this pagehttps://github.com/nodegit/nodegit/pull/875
January 20, 2016 23:43https://github.com/nodegit/nodegit/pull/875#commits-pushed-0c73e01
Remove Index#addAll hackhttps://github.com/nodegit/nodegit/pull/875/commits/0c73e01185295554a317f5a6fd873b6d19e3a6a7
0c73e01https://github.com/nodegit/nodegit/pull/875/commits/0c73e01185295554a317f5a6fd873b6d19e3a6a7
libgit2/libgit2#2687https://github.com/libgit2/libgit2/issues/2687
#751https://github.com/nodegit/nodegit/issues/751
Fix linterhttps://github.com/nodegit/nodegit/pull/875/commits/5dd890962f19e3bfd379bc90900481b7f32ba879
5dd8909https://github.com/nodegit/nodegit/pull/875/commits/5dd890962f19e3bfd379bc90900481b7f32ba879
johnhaley81https://github.com/johnhaley81
Jan 21, 2016 https://github.com/nodegit/nodegit/pull/875#ref-commit-af384b4
https://github.com/johnhaley81
Merge pull requesthttps://github.com/nodegit/nodegit/commit/af384b4e41a9fe221679ed656fffea23b7902f28
#875https://github.com/nodegit/nodegit/pull/875
from nodegit/remove-index-add-all-hackhttps://github.com/nodegit/nodegit/commit/af384b4e41a9fe221679ed656fffea23b7902f28
af384b4https://github.com/nodegit/nodegit/commit/af384b4e41a9fe221679ed656fffea23b7902f28
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
af384b4https://github.com/nodegit/nodegit/commit/af384b4e41a9fe221679ed656fffea23b7902f28
Jan 21, 2016https://github.com/nodegit/nodegit/pull/875#event-522248558
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
January 21, 2016 21:55https://github.com/nodegit/nodegit/pull/875#event-522248596
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F875
libgit2 bug with workaround in index.addAll() is now fixed, we should update index.js https://github.com/nodegit/nodegit/issues/751
Please reload this pagehttps://github.com/nodegit/nodegit/pull/875
https://github.com/johnhaley81
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.