René's URL Explorer Experiment


Title: Eliminate promise polling by srajko · Pull Request #854 · nodegit/nodegit · GitHub

Open Graph Title: Eliminate promise polling by srajko · Pull Request #854 · nodegit/nodegit

X Title: Eliminate promise polling by srajko · Pull Request #854 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: Eliminates the polling of promises when executing javascript callbacks from within async libgit2 calls. Replaces with a system that forwards the promise result / rejection reason to the native laye...

X Description: Eliminates the polling of promises when executing javascript callbacks from within async libgit2 calls. Replaces with a system that forwards the promise result / rejection reason to the native laye...

Opengraph URL: https://github.com/nodegit/nodegit/pull/854

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2aedd8a0-2b34-2a6c-5684-d2b8b6fb5718
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC34:26C182:9EE5984:D6FE17F:6A5E9AD8
html-safe-noncef53f29b018def5d5ffb6284461cc216077948a2495753095b9c3a2ef9c54420a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzM0OjI2QzE4Mjo5RUU1OTg0OkQ2RkUxN0Y6NkE1RTlBRDgiLCJ2aXNpdG9yX2lkIjoiMTgzOTg3MDAxNzUwNjU0ODQ0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc142beea482591d30fcb79e57c983944e8f30077acef243f9172031b7bcf8f2b
hovercard-subject-tagpull_request:55256721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/854/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/935b4d30eb993100505cea2f0305cce0d3cade18020a3248baae600a1e7bb1fa/nodegit/nodegit/pull/854
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/935b4d30eb993100505cea2f0305cce0d3cade18020a3248baae600a1e7bb1fa/nodegit/nodegit/pull/854
og:image:altEliminates the polling of promises when executing javascript callbacks from within async libgit2 calls. Replaces with a system that forwards the promise result / rejection reason to the native laye...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrajko
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/854#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F854
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F854
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/854
Reloadhttps://github.com/nodegit/nodegit/pull/854
Reloadhttps://github.com/nodegit/nodegit/pull/854
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
srajko:eliminate-promise-pollinghttps://github.com/srajko/nodegit/tree/eliminate-promise-polling
Conversationhttps://github.com/nodegit/nodegit/pull/854
Commits4 (4)https://github.com/nodegit/nodegit/pull/854/commits
Checkshttps://github.com/nodegit/nodegit/pull/854/checks
Files changedhttps://github.com/nodegit/nodegit/pull/854/files
Eliminate promise pollinghttps://github.com/nodegit/nodegit/pull/854#top
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
srajko:eliminate-promise-pollinghttps://github.com/srajko/nodegit/tree/eliminate-promise-polling
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 6, 2016https://github.com/nodegit/nodegit/pull/854#issue-125250441
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 6, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169451457
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/tbranyen
tbranyenhttps://github.com/tbranyen
Jan 6, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169452430
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/maxkorp
maxkorphttps://github.com/maxkorp
Jan 6, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169453737
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
force-pushedhttps://github.com/nodegit/nodegit/compare/b1fb458e97f971ba6766a866c4c392259551d194..3865ab296a55ed2a3eabb9bee1bbc32f409d40f8
b1fb458https://github.com/nodegit/nodegit/commit/b1fb458e97f971ba6766a866c4c392259551d194
3865ab2https://github.com/nodegit/nodegit/commit/3865ab296a55ed2a3eabb9bee1bbc32f409d40f8
Compare https://github.com/nodegit/nodegit/compare/b1fb458e97f971ba6766a866c4c392259551d194..3865ab296a55ed2a3eabb9bee1bbc32f409d40f8
January 7, 2016 14:15https://github.com/nodegit/nodegit/pull/854#event-508271348
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169678656
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169680257
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169686851
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169690241
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
force-pushedhttps://github.com/nodegit/nodegit/compare/334f8b6408a96485af2d81a44bb55739df8c9b38..1849693ac0c8229a938d7f7ef33512d4c96bda62
334f8b6https://github.com/nodegit/nodegit/commit/334f8b6408a96485af2d81a44bb55739df8c9b38
1849693https://github.com/nodegit/nodegit/commit/1849693ac0c8229a938d7f7ef33512d4c96bda62
Compare https://github.com/nodegit/nodegit/compare/334f8b6408a96485af2d81a44bb55739df8c9b38..1849693ac0c8229a938d7f7ef33512d4c96bda62
January 7, 2016 21:47https://github.com/nodegit/nodegit/pull/854#event-508769200
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-169816736
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
srajkohttps://github.com/srajko
Jan 7, 2016https://github.com/nodegit/nodegit/pull/854#event-508785906
https://github.com/srajko
srajkohttps://github.com/srajko
force-pushedhttps://github.com/nodegit/nodegit/compare/966222b76603e6ac375ad39661a1984dca72caeb..25a9ba254aef9b9126e476638588e2b7ea345e93
966222bhttps://github.com/nodegit/nodegit/commit/966222b76603e6ac375ad39661a1984dca72caeb
25a9ba2https://github.com/nodegit/nodegit/commit/25a9ba254aef9b9126e476638588e2b7ea345e93
Compare https://github.com/nodegit/nodegit/compare/966222b76603e6ac375ad39661a1984dca72caeb..25a9ba254aef9b9126e476638588e2b7ea345e93
January 8, 2016 20:05https://github.com/nodegit/nodegit/pull/854#event-509815048
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 12, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-171018626
@srajkohttps://github.com/srajko
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
srajkohttps://github.com/srajko
January 12, 2016 19:40https://github.com/nodegit/nodegit/pull/854#commits-pushed-5965fe0
https://github.com/srajko
Factor out AsyncBaton base class for async Batonshttps://github.com/nodegit/nodegit/pull/854/commits/5965fe08ea09931334548eecd482e023e5f8e4d3
5965fe0https://github.com/nodegit/nodegit/pull/854/commits/5965fe08ea09931334548eecd482e023e5f8e4d3
https://github.com/srajko
Add PromiseCompletion class to replace promise pollinghttps://github.com/nodegit/nodegit/pull/854/commits/52d78abf697461032b2da03e9510d0d9c87b9d7b
52d78abhttps://github.com/nodegit/nodegit/pull/854/commits/52d78abf697461032b2da03e9510d0d9c87b9d7b
https://github.com/srajko
Add tests for callbacks passed directly as parametershttps://github.com/nodegit/nodegit/pull/854/commits/1e11d71f855546a4281fab9ef3750c1d650ae2ac
1e11d71https://github.com/nodegit/nodegit/pull/854/commits/1e11d71f855546a4281fab9ef3750c1d650ae2ac
https://github.com/srajko
Remove nodegit-promisehttps://github.com/nodegit/nodegit/pull/854/commits/8dae154aa00b5c23f482b746ba4efcfb524a812d
8dae154https://github.com/nodegit/nodegit/pull/854/commits/8dae154aa00b5c23f482b746ba4efcfb524a812d
https://github.com/srajko
srajkohttps://github.com/srajko
force-pushedhttps://github.com/nodegit/nodegit/compare/93bd8d22d963a0ccd822fbfa390ffa74ab91b887..8dae154aa00b5c23f482b746ba4efcfb524a812d
93bd8d2https://github.com/nodegit/nodegit/commit/93bd8d22d963a0ccd822fbfa390ffa74ab91b887
8dae154https://github.com/nodegit/nodegit/commit/8dae154aa00b5c23f482b746ba4efcfb524a812d
Compare https://github.com/nodegit/nodegit/compare/93bd8d22d963a0ccd822fbfa390ffa74ab91b887..8dae154aa00b5c23f482b746ba4efcfb524a812d
January 13, 2016 03:18https://github.com/nodegit/nodegit/pull/854#event-513238577
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 13, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-171352166
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
johnhaley81https://github.com/johnhaley81
Jan 13, 2016 https://github.com/nodegit/nodegit/pull/854#discussion-diff-49623812
View reviewed changes https://github.com/nodegit/nodegit/pull/854/files/8dae154aa00b5c23f482b746ba4efcfb524a812d#diff-a1a3a083a6cb4e9b7ac607d3764cae1f4c25ecf758e250b722786480b6707005
generate/templates/manual/src/promise_completion.cchttps://github.com/nodegit/nodegit/pull/854/files#diff-a1a3a083a6cb4e9b7ac607d3764cae1f4c25ecf758e250b722786480b6707005
johnhaley81https://github.com/johnhaley81
Jan 13, 2016https://github.com/nodegit/nodegit/pull/854#discussion_r49623812
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
srajkohttps://github.com/srajko
Jan 14, 2016https://github.com/nodegit/nodegit/pull/854#discussion_r49672657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L13-L14https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L13-L14
https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L97-L103https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L97-L103
https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L92-L94https://github.com/srajko/nodegit/blob/8dae154aa00b5c23f482b746ba4efcfb524a812d/generate/templates/manual/src/promise_completion.cc#L92-L94
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
johnhaley81https://github.com/johnhaley81
Jan 15, 2016https://github.com/nodegit/nodegit/pull/854#discussion_r49894375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 13, 2016https://github.com/nodegit/nodegit/pull/854#issuecomment-171377026
https://github.com/nodegit/nodegit/pull/854/files#r49623812https://github.com/nodegit/nodegit/pull/854/files#r49623812
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
johnhaley81https://github.com/johnhaley81
Jan 15, 2016 https://github.com/nodegit/nodegit/pull/854#ref-commit-57a34e2
https://github.com/johnhaley81
Merge pull requesthttps://github.com/nodegit/nodegit/commit/57a34e26021a24411477a4f6af20c8ae9174f293
#854https://github.com/nodegit/nodegit/pull/854
from srajko/eliminate-promise-pollinghttps://github.com/nodegit/nodegit/commit/57a34e26021a24411477a4f6af20c8ae9174f293
57a34e2https://github.com/nodegit/nodegit/commit/57a34e26021a24411477a4f6af20c8ae9174f293
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
57a34e2https://github.com/nodegit/nodegit/commit/57a34e26021a24411477a4f6af20c8ae9174f293
Jan 15, 2016https://github.com/nodegit/nodegit/pull/854#event-516526609
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Jan 26, 2016 https://github.com/nodegit/nodegit/pull/854#ref-issue-127242214
Process not exiting by default #866 https://github.com/nodegit/nodegit/issues/866
https://github.com/srajko
srajkohttps://github.com/srajko
May 9, 2016 22:17https://github.com/nodegit/nodegit/pull/854#event-655036926
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
May 25, 2016 https://github.com/nodegit/nodegit/pull/854#ref-pullrequest-47094004
Added ability for callbacks to poll promises for fulfillment value #260 https://github.com/nodegit/nodegit/pull/260
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F854
Please reload this pagehttps://github.com/nodegit/nodegit/pull/854
https://github.com/srajko
https://github.com/johnhaley81
https://github.com/tbranyen
https://github.com/maxkorp
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.