Title: fix config.getString by jdgarcia · Pull Request #676 · nodegit/nodegit · GitHub
Open Graph Title: fix config.getString by jdgarcia · Pull Request #676 · nodegit/nodegit
X Title: fix config.getString by jdgarcia · Pull Request #676 · nodegit/nodegit
Description: getStringBuf is a method on Config's prototype, so the getString convenience method did not work. Fixed it to be on the prototype. We were getting false positives on the config tests because we were catching all errors with the finallyFn. Updated the tests the rethrow errors after the finallyFn is done.
Open Graph Description: getStringBuf is a method on Config's prototype, so the getString convenience method did not work. Fixed it to be on the prototype. We were getting false positives on the config tests because we...
X Description: getStringBuf is a method on Config's prototype, so the getString convenience method did not work. Fixed it to be on the prototype. We were getting false positives on the config tests becaus...
Opengraph URL: https://github.com/nodegit/nodegit/pull/676
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1def9a09-6964-2c75-89b5-7c7b2c402c47 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A0A:12D7DC:127C1CD:17D0A85:6A5C4318 |
| html-safe-nonce | a779bd34f77e969a9229471c0e88ff71f469bfe0fec3727ada96efd50ec02198 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTBBOjEyRDdEQzoxMjdDMUNEOjE3RDBBODU6NkE1QzQzMTgiLCJ2aXNpdG9yX2lkIjoiNjI3MTU3MDUxMzY1NzM0ODg4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 013e94997c0079ea01bd82cf91a44be054d4b935307a3a2fc4bb21b92594ba6d |
| hovercard-subject-tag | pull_request:42383946 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/676/files |
| twitter:image | https://avatars.githubusercontent.com/u/899916?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/899916?s=400&v=4 |
| og:image:alt | getStringBuf is a method on Config's prototype, so the getString convenience method did not work. Fixed it to be on the prototype. We were getting false positives on the config tests because we... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width