Title: StrArray memory fix by mattyclarkson · Pull Request #454 · nodegit/nodegit · GitHub
Open Graph Title: StrArray memory fix by mattyclarkson · Pull Request #454 · nodegit/nodegit
X Title: StrArray memory fix by mattyclarkson · Pull Request #454 · nodegit/nodegit
Description: We were only allocating enough memory for a git_strarray memory pointer rather than the structure. 1a74a2d fixes that. 7c81612 changes the code to allocate the memory for the structure and the string pointers all in one go to reduce fragmentation. Complete micro-optimisation, happy for it to not get merged but thought I'd do it anyway.
Open Graph Description: We were only allocating enough memory for a git_strarray memory pointer rather than the structure. 1a74a2d fixes that. 7c81612 changes the code to allocate the memory for the structure and the str...
X Description: We were only allocating enough memory for a git_strarray memory pointer rather than the structure. 1a74a2d fixes that. 7c81612 changes the code to allocate the memory for the structure and the str...
Opengraph URL: https://github.com/nodegit/nodegit/pull/454
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9cc81598-1b1a-3f22-94b1-b45d3f0f003c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9600:51308:28FC4E9:3975E79:6A5F6309 |
| html-safe-nonce | c790d567042dc52ad672a033a542df7afd354b7680be1b728afed1d418ec7e9e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjAwOjUxMzA4OjI4RkM0RTk6Mzk3NUU3OTo2QTVGNjMwOSIsInZpc2l0b3JfaWQiOiIzNzQxODQ2OTk1NDk1NTEwNzkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6062814c876c1b4c8be2635e4f4a7c5e5b3965cb8451e8711201da5b7548c763 |
| hovercard-subject-tag | pull_request:30369563 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/454/files |
| twitter:image | https://avatars.githubusercontent.com/u/1081113?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1081113?s=400&v=4 |
| og:image:alt | We were only allocating enough memory for a git_strarray memory pointer rather than the structure. 1a74a2d fixes that. 7c81612 changes the code to allocate the memory for the structure and the str... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ab2497d9345a59709926b385d88458fa5932c82ec066288448eb68b34cbcbbda |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ba0ac57287507693938b0a2de45402a22cda0785 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width