Title: Str array converter fix by mattyclarkson · Pull Request #451 · nodegit/nodegit · GitHub
Open Graph Title: Str array converter fix by mattyclarkson · Pull Request #451 · nodegit/nodegit
X Title: Str array converter fix by mattyclarkson · Pull Request #451 · nodegit/nodegit
Description: This fixes up the conversion of string arrays. The problem is that the ConvertArray function was setting the string pointer to the internals of NanUtf8String but the class was being destroyed freeing the memory. I also removed the need to call ConstructStrArray as that just does more string duplications (strdup) that aren't really needed. The commits on this branch provide a clean transistion between the two methods that are more obvious that the complete branch diff.
Open Graph Description: This fixes up the conversion of string arrays. The problem is that the ConvertArray function was setting the string pointer to the internals of NanUtf8String but the class was being destroyed freei...
X Description: This fixes up the conversion of string arrays. The problem is that the ConvertArray function was setting the string pointer to the internals of NanUtf8String but the class was being destroyed freei...
Opengraph URL: https://github.com/nodegit/nodegit/pull/451
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1dcdfba1-58c8-e048-d3a7-6270cec9046f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEF2:437AB:18CFCE2:221F97D:6A5F2BCA |
| html-safe-nonce | 89eaa533f15598dff1ad054b932d944c4c1df0f162a121ad66fa24561dab8f18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUYyOjQzN0FCOjE4Q0ZDRTI6MjIxRjk3RDo2QTVGMkJDQSIsInZpc2l0b3JfaWQiOiIxMjgwMTA4OTc0MjIzMzM4NDQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c0f470b92546a1fb4ed4a4cf536d31e0551f39e3b4584013687d4d70c99598aa |
| hovercard-subject-tag | pull_request:30302725 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/451/files |
| twitter:image | https://avatars.githubusercontent.com/u/1081113?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1081113?s=400&v=4 |
| og:image:alt | This fixes up the conversion of string arrays. The problem is that the ConvertArray function was setting the string pointer to the internals of NanUtf8String but the class was being destroyed freei... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af57322612a2efc3d6fee860947245ffbb465e4e3f9eb5dfefc0f770217aa0ca |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93fabb5edc1b64676979fa226fed14ab56431f54 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width