Title: Fix Load-Order Bug by fatlotus · Pull Request #44 · nodegit/nodegit · GitHub
Open Graph Title: Fix Load-Order Bug by fatlotus · Pull Request #44 · nodegit/nodegit
X Title: Fix Load-Order Bug by fatlotus · Pull Request #44 · nodegit/nodegit
Description: Hey guys- To be honest, I'm not sure if this is a bug or not. I've found it inconvenient behavior in my own use, so I've changed it in my local fork. Currently, when a nested directory is iterated over, the 'end' event is only called when all the root entries have loaded, meaning that it is impossible to know when all sub-entries are complete. This patch requires that all sub-queries load before the root directory is to load. (There's a line in here, "tree.error" that I'm not sure I understand — right now the "end" event will not fire if this the case.)
Open Graph Description: Hey guys- To be honest, I'm not sure if this is a bug or not. I've found it inconvenient behavior in my own use, so I've changed it in my local fork. Currently, when a nested directory ...
X Description: Hey guys- To be honest, I'm not sure if this is a bug or not. I've found it inconvenient behavior in my own use, so I've changed it in my local fork. Currently, when a neste...
Opengraph URL: https://github.com/nodegit/nodegit/pull/44
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:68fc602a-f727-0088-843a-2894a6d9d77f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8060:1209D6:3F4C19:58D4DA:6A5F83F4 |
| html-safe-nonce | af6e3fdd66bedd42d34f35b5f9a6437617aee807a3fbb3743be1bf0183f6e117 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDYwOjEyMDlENjozRjRDMTk6NThENERBOjZBNUY4M0Y0IiwidmlzaXRvcl9pZCI6IjMzNTM0MjA3MDU5Nzk5MjU0OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b4ce096de1f85710fcde41f568b89cf653a41214e13d725b4a3c8915e319b9fe |
| hovercard-subject-tag | pull_request:2775061 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/44/files |
| twitter:image | https://avatars.githubusercontent.com/u/14364?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14364?s=400&v=4 |
| og:image:alt | Hey guys- To be honest, I'm not sure if this is a bug or not. I've found it inconvenient behavior in my own use, so I've changed it in my local fork. Currently, when a nested directory ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 97f2f300269b0002088b1cbd0557a5c7e2cd7179ab6962f24dc5fff865a3ef9b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5eacb64e94d3c0388291748236c995e36b9883e0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width