René's URL Explorer Experiment


Title: Fix callbacks with just return value and single payload by johnhaley81 · Pull Request #416 · nodegit/nodegit · GitHub

Open Graph Title: Fix callbacks with just return value and single payload by johnhaley81 · Pull Request #416 · nodegit/nodegit

X Title: Fix callbacks with just return value and single payload by johnhaley81 · Pull Request #416 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: This will fix #395

X Description: This will fix #395

Opengraph URL: https://github.com/nodegit/nodegit/pull/416

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3035c00e-d175-9027-0882-d1da5026685d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA30:2AF233:246ADD:31013D:6A5CB7F1
html-safe-nonce58e4c07a1347cab8142058eec16f5c44a697e958cf9b7fea4ca5308999d91e4a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTMwOjJBRjIzMzoyNDZBREQ6MzEwMTNEOjZBNUNCN0YxIiwidmlzaXRvcl9pZCI6IjIxNTAyMjc3NTE2MzQ1MTU5NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac80c708c5b955f40cae5aff9bfc3b8c68a0bb5a7838a0f0c7eeed53618118e8c2
hovercard-subject-tagpull_request:29666644
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/416/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6e80d4b4836f243292e5996fdb00f66bd91c9220040d38b5604fdb9956744a8/nodegit/nodegit/pull/416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6e80d4b4836f243292e5996fdb00f66bd91c9220040d38b5604fdb9956744a8/nodegit/nodegit/pull/416
og:image:altThis will fix #395
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnhaley81
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/416#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F416
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F416
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/416
Reloadhttps://github.com/nodegit/nodegit/pull/416
Reloadhttps://github.com/nodegit/nodegit/pull/416
Please reload this pagehttps://github.com/nodegit/nodegit/pull/416
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
fix-callbackshttps://github.com/nodegit/nodegit/tree/fix-callbacks
Conversationhttps://github.com/nodegit/nodegit/pull/416
Commits11 (11)https://github.com/nodegit/nodegit/pull/416/commits
Checkshttps://github.com/nodegit/nodegit/pull/416/checks
Files changedhttps://github.com/nodegit/nodegit/pull/416/files
Fix callbacks with just return value and single payloadhttps://github.com/nodegit/nodegit/pull/416#top
johnhaley81https://github.com/johnhaley81
masterhttps://github.com/nodegit/nodegit/tree/master
fix-callbackshttps://github.com/nodegit/nodegit/tree/fix-callbacks
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Feb 20, 2015https://github.com/nodegit/nodegit/pull/416#issue-58298947
#395https://github.com/nodegit/nodegit/issues/395
Please reload this pagehttps://github.com/nodegit/nodegit/pull/416
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Feb 20, 2015https://github.com/nodegit/nodegit/pull/416#event-238921862
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
force-pushedhttps://github.com/nodegit/nodegit/compare/95e1c5dc98a6211e3d6593fa159f7d7e7f2d1fe1..413d7e93afff7383bec40f8a679104b108d6b11b
95e1c5dhttps://github.com/nodegit/nodegit/commit/95e1c5dc98a6211e3d6593fa159f7d7e7f2d1fe1
413d7e9https://github.com/nodegit/nodegit/commit/413d7e93afff7383bec40f8a679104b108d6b11b
Compare https://github.com/nodegit/nodegit/compare/95e1c5dc98a6211e3d6593fa159f7d7e7f2d1fe1..413d7e93afff7383bec40f8a679104b108d6b11b
February 23, 2015 23:18https://github.com/nodegit/nodegit/pull/416#event-240551657
https://github.com/tbranyen
tbranyenhttps://github.com/tbranyen
force-pushedhttps://github.com/nodegit/nodegit/compare/413d7e93afff7383bec40f8a679104b108d6b11b..ab1595d8cc237cc80a96a9cfe799a8bf1e85cdeb
413d7e9https://github.com/nodegit/nodegit/commit/413d7e93afff7383bec40f8a679104b108d6b11b
ab1595dhttps://github.com/nodegit/nodegit/commit/ab1595d8cc237cc80a96a9cfe799a8bf1e85cdeb
Compare https://github.com/nodegit/nodegit/compare/413d7e93afff7383bec40f8a679104b108d6b11b..ab1595d8cc237cc80a96a9cfe799a8bf1e85cdeb
February 24, 2015 01:35https://github.com/nodegit/nodegit/pull/416#event-240620781
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Feb 24, 2015 https://github.com/nodegit/nodegit/pull/416#ref-pullrequest-58764107
Allow for saving of props to an object #421 https://github.com/nodegit/nodegit/pull/421
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
force-pushedhttps://github.com/nodegit/nodegit/compare/e0e6bfaf2381cd453b8c37476cbda60347ce2188..6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c
e0e6bfahttps://github.com/nodegit/nodegit/commit/e0e6bfaf2381cd453b8c37476cbda60347ce2188
6de7e3bhttps://github.com/nodegit/nodegit/commit/6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c
Compare https://github.com/nodegit/nodegit/compare/e0e6bfaf2381cd453b8c37476cbda60347ce2188..6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c
February 24, 2015 18:47https://github.com/nodegit/nodegit/pull/416#event-241144315
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
Feb 24, 2015 https://github.com/nodegit/nodegit/pull/416#ref-pullrequest-58673219
Fixes segfault issue recorded in #406 #419 https://github.com/nodegit/nodegit/pull/419
February 24, 2015 12:35https://github.com/nodegit/nodegit/pull/416#commits-pushed-2aff3c0
Fix callbacks with just return valuehttps://github.com/nodegit/nodegit/pull/416/commits/2aff3c0dbcd04c232a7ceb522760fa232157c285
2aff3c0https://github.com/nodegit/nodegit/pull/416/commits/2aff3c0dbcd04c232a7ceb522760fa232157c285
Normalize returns for callbackshttps://github.com/nodegit/nodegit/pull/416/commits/deeb885db85d13ee0249fea32f9916435a3f420e
deeb885https://github.com/nodegit/nodegit/pull/416/commits/deeb885db85d13ee0249fea32f9916435a3f420e
Force functions with callbacks to be asynchttps://github.com/nodegit/nodegit/pull/416/commits/0a7ac52d10583f245bfd0979a2a43fe1799a988f
0a7ac52https://github.com/nodegit/nodegit/pull/416/commits/0a7ac52d10583f245bfd0979a2a43fe1799a988f
Handle global payloads in functionshttps://github.com/nodegit/nodegit/pull/416/commits/530290dcc1b498f5dbb5f14e298619cad1bcace1
530290dhttps://github.com/nodegit/nodegit/pull/416/commits/530290dcc1b498f5dbb5f14e298619cad1bcace1
Fix promises not being returned in index testhttps://github.com/nodegit/nodegit/pull/416/commits/e954ae57b105dc6849607d7e01980d1b6441c735
e954ae5https://github.com/nodegit/nodegit/pull/416/commits/e954ae57b105dc6849607d7e01980d1b6441c735
Fix git_strarray when an actual array is passed inhttps://github.com/nodegit/nodegit/pull/416/commits/67c6eb2832d3286d5d21017e04ff443a8937a606
67c6eb2https://github.com/nodegit/nodegit/pull/416/commits/67c6eb2832d3286d5d21017e04ff443a8937a606
Cleanup memory from global payloadshttps://github.com/nodegit/nodegit/pull/416/commits/07443200e2ee200577e1d31cf63f3f975ede5d50
0744320https://github.com/nodegit/nodegit/pull/416/commits/07443200e2ee200577e1d31cf63f3f975ede5d50
Promisify writeFile by hand in index testshttps://github.com/nodegit/nodegit/pull/416/commits/d40d7919f6f3427778749c3236cc11ab678146da
d40d791https://github.com/nodegit/nodegit/pull/416/commits/d40d7919f6f3427778749c3236cc11ab678146da
Fix linter errorshttps://github.com/nodegit/nodegit/pull/416/commits/99f9fdaa7904fc6159e08db9b65779698db59d36
99f9fdahttps://github.com/nodegit/nodegit/pull/416/commits/99f9fdaa7904fc6159e08db9b65779698db59d36
Clean up creation/deletion of global payloadshttps://github.com/nodegit/nodegit/pull/416/commits/3b9b63725843da58932b4d65b11a292848bf12fd
3b9b637https://github.com/nodegit/nodegit/pull/416/commits/3b9b63725843da58932b4d65b11a292848bf12fd
Clean up callbacks in structshttps://github.com/nodegit/nodegit/pull/416/commits/dece787539ac204b3756017c9f50ccfeac2890d2
dece787https://github.com/nodegit/nodegit/pull/416/commits/dece787539ac204b3756017c9f50ccfeac2890d2
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
force-pushedhttps://github.com/nodegit/nodegit/compare/6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c..dece787539ac204b3756017c9f50ccfeac2890d2
6de7e3bhttps://github.com/nodegit/nodegit/commit/6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c
dece787https://github.com/nodegit/nodegit/commit/dece787539ac204b3756017c9f50ccfeac2890d2
Compare https://github.com/nodegit/nodegit/compare/6de7e3b1b9d5716d76de3e0048ef9216d9e7ca2c..dece787539ac204b3756017c9f50ccfeac2890d2
February 24, 2015 19:36https://github.com/nodegit/nodegit/pull/416#event-241184406
johnhaley81https://github.com/johnhaley81
Feb 24, 2015 https://github.com/nodegit/nodegit/pull/416#ref-commit-0458b53
https://github.com/johnhaley81
Merge pull requesthttps://github.com/nodegit/nodegit/commit/0458b53717c2b9ffc796b730924eb8ebd4da0864
#416https://github.com/nodegit/nodegit/pull/416
from nodegit/fix-callbackshttps://github.com/nodegit/nodegit/commit/0458b53717c2b9ffc796b730924eb8ebd4da0864
0458b53https://github.com/nodegit/nodegit/commit/0458b53717c2b9ffc796b730924eb8ebd4da0864
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
0458b53https://github.com/nodegit/nodegit/commit/0458b53717c2b9ffc796b730924eb8ebd4da0864
Feb 24, 2015https://github.com/nodegit/nodegit/pull/416#event-241211573
https://github.com/johnhaley81
johnhaley81https://github.com/johnhaley81
February 24, 2015 20:13https://github.com/nodegit/nodegit/pull/416#event-241211603
https://github.com/tbranyen
tbranyenhttps://github.com/tbranyen
0.3.0https://github.com/nodegit/nodegit/milestone/9
Mar 2, 2015https://github.com/nodegit/nodegit/pull/416#event-244694210
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F416
0.3.0 https://github.com/nodegit/nodegit/milestone/9
Callbacks need to handle more use-cases https://github.com/nodegit/nodegit/issues/395
Please reload this pagehttps://github.com/nodegit/nodegit/pull/416
https://github.com/johnhaley81
https://github.com/tbranyen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.