Title: Commit.getParents working with merge commits by bjornarg · Pull Request #357 · nodegit/nodegit · GitHub
Open Graph Title: Commit.getParents working with merge commits by bjornarg · Pull Request #357 · nodegit/nodegit
X Title: Commit.getParents working with merge commits by bjornarg · Pull Request #357 · nodegit/nodegit
Description: getParents failed when more than one commit was present, since it attempted to get the second parent of commit's parent instead of it's own second parent. The promise for the second parent was also pushed onto the array for Promise.all() too late to actually have an effect. Limit was not working properly as a limit, since it attempted to retrieve the set limit regardless of how many parents a commit had, failing if the limit was set to more than Commit.parentcount().
Open Graph Description: getParents failed when more than one commit was present, since it attempted to get the second parent of commit's parent instead of it's own second parent. The promise for the second parent ...
X Description: getParents failed when more than one commit was present, since it attempted to get the second parent of commit's parent instead of it's own second parent. The promise for the second...
Opengraph URL: https://github.com/nodegit/nodegit/pull/357
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ab4a8861-f385-c38c-d872-ebe966f52663 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEA6:2F1608:4841A8:61FBD0:6A5ED650 |
| html-safe-nonce | c1b954622266fe25dbaa3899d7f56d85aafe94b48ffb984e36b7cddbb078a02b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjJGMTYwODo0ODQxQTg6NjFGQkQwOjZBNUVENjUwIiwidmlzaXRvcl9pZCI6IjEyMzUzMDkwODUxODY3NzQ2MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 019fff31050530c6849f46c8b8f7a3d988d420e7c08ee61dcea571cfd9b5445f |
| hovercard-subject-tag | pull_request:27578683 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/357/files |
| twitter:image | https://avatars.githubusercontent.com/u/275651?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/275651?s=400&v=4 |
| og:image:alt | getParents failed when more than one commit was present, since it attempted to get the second parent of commit's parent instead of it's own second parent. The promise for the second parent ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 82d0004a35927bdb00c652a57f456c55aa0eda4ade1bc7956d7510fdea6e454b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d2d913dd727d2d7ac189fb4d05b10bc34ecd03ee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width