Title: voidcheck string pointers and reenable attr test by maxkorp · Pull Request #266 · nodegit/nodegit · GitHub
Open Graph Title: voidcheck string pointers and reenable attr test by maxkorp · Pull Request #266 · nodegit/nodegit
X Title: voidcheck string pointers and reenable attr test by maxkorp · Pull Request #266 · nodegit/nodegit
Description: The attr test was failing (and being skipped) because of a segfault. Some libgit2 functions that output to char** just don't even allocate the inner string if they have no output, so we need to voidcheck the inner pointer. Combined with a tweak to make git_attr_get async and to make the templates recognize its return, the test passes.
Open Graph Description: The attr test was failing (and being skipped) because of a segfault. Some libgit2 functions that output to char** just don't even allocate the inner string if they have no output, so we need to...
X Description: The attr test was failing (and being skipped) because of a segfault. Some libgit2 functions that output to char** just don't even allocate the inner string if they have no output, so we nee...
Opengraph URL: https://github.com/nodegit/nodegit/pull/266
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:848d5c7a-67af-7aae-57dd-5cec0d42ad64 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E452:197DBD:70AB919:9970122:6A5E37EC |
| html-safe-nonce | 040702dca11ab229930275856e42012789e3264540b9dca846f4a07c318de5a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDUyOjE5N0RCRDo3MEFCOTE5Ojk5NzAxMjI6NkE1RTM3RUMiLCJ2aXNpdG9yX2lkIjoiNjQ0NzMyNDM0NjM5MTA4Mjk4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6389110f812d78ffcbbf32687daed9e7b01df6ef215a5369048981f33e736316 |
| hovercard-subject-tag | pull_request:24234206 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/266/files |
| twitter:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| og:image:alt | The attr test was failing (and being skipped) because of a segfault. Some libgit2 functions that output to char** just don't even allocate the inner string if they have no output, so we need to... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e4b946991e2bd4b122ac7bb3d405be22af15feed82daaafcd1fe0a1231d54061 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a421a3a9fbeebe1ed5ba7c8e5b803b098d65a30e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width