| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e438ccc6-df25-02c9-6fcb-f02a7d327de5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9846:3EE21F:28B4D77:34F2645:6A5CB7DD |
| html-safe-nonce | 6f0f02ecacc46a78b1282796e8f7e0e34d1bab5c3ac7bb3383091a8236ad56be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODQ2OjNFRTIxRjoyOEI0RDc3OjM0RjI2NDU6NkE1Q0I3REQiLCJ2aXNpdG9yX2lkIjoiODM5NTAyODMwMzU4MjExNTgwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | daff47e4ab6bc8cca8286577e6e17ef8712cb9db921a80fe27a2d4ec67786ca1 |
| hovercard-subject-tag | pull_request:23498404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/260/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e6a32afe2addb826f1359bd9cb2937e02ad2347bfee50ac7559dcd9a0fecb3c/nodegit/nodegit/pull/260 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e6a32afe2addb826f1359bd9cb2937e02ad2347bfee50ac7559dcd9a0fecb3c/nodegit/nodegit/pull/260 |
| og:image:alt | This will allow a callback native to libgit2 to actually have a promise value be returned in the callback eventually. We'll be able to not pause the JS thread while we wait for authentication o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | johnhaley81 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodegit/nodegit/pull/260#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F260 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F260 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit |
| Reload | https://github.com/nodegit/nodegit/pull/260 |
| Reload | https://github.com/nodegit/nodegit/pull/260 |
| Reload | https://github.com/nodegit/nodegit/pull/260 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
|
nodegit
| https://github.com/nodegit |
| nodegit | https://github.com/nodegit/nodegit |
|
Notifications
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Fork
698
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Star
5.8k
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Code
| https://github.com/nodegit/nodegit |
|
Issues
343
| https://github.com/nodegit/nodegit/issues |
|
Pull requests
20
| https://github.com/nodegit/nodegit/pulls |
|
Actions
| https://github.com/nodegit/nodegit/actions |
|
Projects
| https://github.com/nodegit/nodegit/projects |
|
Security and quality
0
| https://github.com/nodegit/nodegit/security |
|
Insights
| https://github.com/nodegit/nodegit/pulse |
|
Code
| https://github.com/nodegit/nodegit |
|
Issues
| https://github.com/nodegit/nodegit/issues |
|
Pull requests
| https://github.com/nodegit/nodegit/pulls |
|
Actions
| https://github.com/nodegit/nodegit/actions |
|
Projects
| https://github.com/nodegit/nodegit/projects |
|
Security and quality
| https://github.com/nodegit/nodegit/security |
|
Insights
| https://github.com/nodegit/nodegit/pulse |
| johnhaley81 | https://github.com/johnhaley81 |
| master | https://github.com/nodegit/nodegit/tree/master |
| callback-promises | https://github.com/nodegit/nodegit/tree/callback-promises |
| Conversation | https://github.com/nodegit/nodegit/pull/260 |
| Commits4 (4) | https://github.com/nodegit/nodegit/pull/260/commits |
| Checks | https://github.com/nodegit/nodegit/pull/260/checks |
| Files changed | https://github.com/nodegit/nodegit/pull/260/files |
| Added ability for callbacks to poll promises for fulfillment value | https://github.com/nodegit/nodegit/pull/260#top |
| johnhaley81 | https://github.com/johnhaley81 |
| master | https://github.com/nodegit/nodegit/tree/master |
| callback-promises | https://github.com/nodegit/nodegit/tree/callback-promises |
|
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Oct 28, 2014 | https://github.com/nodegit/nodegit/pull/260#issue-47094004 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Oct 28, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-60849432 |
| then/promise#58 | https://github.com/then/promise/issues/58 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| tbranyen | https://github.com/tbranyen |
|
Oct 30, 2014
| https://github.com/nodegit/nodegit/pull/260#discussion-diff-19637715 |
| View reviewed changes
| https://github.com/nodegit/nodegit/pull/260/files/6f23643b2c1d9d31f96875ce537f76f2580756e6#diff-a8132119a05ca0ae3b5bf30f1b7b725d19d048290ba71474a5a033ed50d8d243 |
| test/tests/cred.js | https://github.com/nodegit/nodegit/pull/260/files#diff-a8132119a05ca0ae3b5bf30f1b7b725d19d048290ba71474a5a033ed50d8d243 |
| tbranyen | https://github.com/tbranyen |
| Oct 30, 2014 | https://github.com/nodegit/nodegit/pull/260#discussion_r19637715 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/tbranyen |
| tbranyen | https://github.com/tbranyen |
| Nov 8, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62235719 |
| https://github.com/zenparsing/v8-promise | https://github.com/zenparsing/v8-promise |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/maxkorp |
| maxkorp | https://github.com/maxkorp |
|
Nov 10, 2014
| https://github.com/nodegit/nodegit/pull/260#ref-issue-48292894 |
|
We're using too many promise libraries
#264
| https://github.com/nodegit/nodegit/issues/264 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Nov 10, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62447815 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| force-pushed | https://github.com/nodegit/nodegit/compare/6f23643b2c1d9d31f96875ce537f76f2580756e6..a7c91dcd7b4c1a5ea54f528e05b115414b23317a |
| 6f23643 | https://github.com/nodegit/nodegit/commit/6f23643b2c1d9d31f96875ce537f76f2580756e6 |
| a7c91dc | https://github.com/nodegit/nodegit/commit/a7c91dcd7b4c1a5ea54f528e05b115414b23317a |
|
Compare
| https://github.com/nodegit/nodegit/compare/6f23643b2c1d9d31f96875ce537f76f2580756e6..a7c91dcd7b4c1a5ea54f528e05b115414b23317a |
| November 10, 2014 20:45 | https://github.com/nodegit/nodegit/pull/260#event-191026535 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Nov 10, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62453172 |
| Q | https://github.com/kriskowal/q |
| @tbranyen | https://github.com/tbranyen |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| force-pushed | https://github.com/nodegit/nodegit/compare/e3c1df15273b35fa24c8f86f1882f9b3cdddc378..356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc |
| e3c1df1 | https://github.com/nodegit/nodegit/commit/e3c1df15273b35fa24c8f86f1882f9b3cdddc378 |
| 356bccc | https://github.com/nodegit/nodegit/commit/356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc |
|
Compare
| https://github.com/nodegit/nodegit/compare/e3c1df15273b35fa24c8f86f1882f9b3cdddc378..356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc |
| November 11, 2014 21:58 | https://github.com/nodegit/nodegit/pull/260#event-191695705 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Nov 11, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62630368 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/tbranyen |
| tbranyen | https://github.com/tbranyen |
| Nov 11, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62631573 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Nov 11, 2014 | https://github.com/nodegit/nodegit/pull/260#issuecomment-62633735 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| November 11, 2014 15:54 | https://github.com/nodegit/nodegit/pull/260#commits-pushed-b22ba10 |
| Added ability for callbacks to poll promises for fulfillment value | https://github.com/nodegit/nodegit/pull/260/commits/b22ba1030a8dc8458491b81aaf5e2d36fbc06642 |
| b22ba10 | https://github.com/nodegit/nodegit/pull/260/commits/b22ba1030a8dc8458491b81aaf5e2d36fbc06642 |
| Changed the cred methods over to be async promises | https://github.com/nodegit/nodegit/pull/260/commits/769908da77ffb9f8479e0f6d3c52f1ebb94047b4 |
| 769908d | https://github.com/nodegit/nodegit/pull/260/commits/769908da77ffb9f8479e0f6d3c52f1ebb94047b4 |
| Updated the homepage | https://github.com/nodegit/nodegit/pull/260/commits/6ed5c38b4146f684e0bb3f4530871a0eac75bd85 |
| 6ed5c38 | https://github.com/nodegit/nodegit/pull/260/commits/6ed5c38b4146f684e0bb3f4530871a0eac75bd85 |
| Made cred callbacks async again | https://github.com/nodegit/nodegit/pull/260/commits/81c14b7512308b942c88b60c46eb72de40c0bf61 |
| 81c14b7 | https://github.com/nodegit/nodegit/pull/260/commits/81c14b7512308b942c88b60c46eb72de40c0bf61 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| force-pushed | https://github.com/nodegit/nodegit/compare/356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc..81c14b7512308b942c88b60c46eb72de40c0bf61 |
| 356bccc | https://github.com/nodegit/nodegit/commit/356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc |
| 81c14b7 | https://github.com/nodegit/nodegit/commit/81c14b7512308b942c88b60c46eb72de40c0bf61 |
|
Compare
| https://github.com/nodegit/nodegit/compare/356bcccff0b8d9d22dc92755361d6aa3b6ccc9fc..81c14b7512308b942c88b60c46eb72de40c0bf61 |
| November 11, 2014 22:54 | https://github.com/nodegit/nodegit/pull/260#event-191726301 |
| johnhaley81 | https://github.com/johnhaley81 |
|
Nov 11, 2014
| https://github.com/nodegit/nodegit/pull/260#ref-commit-83ee7e0 |
|
| https://github.com/johnhaley81 |
| Merge pull request | https://github.com/nodegit/nodegit/commit/83ee7e02a5af4268e46ef000ab3e0011117720b4 |
| #260 | https://github.com/nodegit/nodegit/pull/260 |
| from nodegit/callback-promises | https://github.com/nodegit/nodegit/commit/83ee7e02a5af4268e46ef000ab3e0011117720b4 |
| 83ee7e0 | https://github.com/nodegit/nodegit/commit/83ee7e02a5af4268e46ef000ab3e0011117720b4 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| 83ee7e0 | https://github.com/nodegit/nodegit/commit/83ee7e02a5af4268e46ef000ab3e0011117720b4 |
| Nov 11, 2014 | https://github.com/nodegit/nodegit/pull/260#event-191737537 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| November 11, 2014 23:20 | https://github.com/nodegit/nodegit/pull/260#event-191737551 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| November 12, 2014 00:54 | https://github.com/nodegit/nodegit/pull/260#event-191776720 |
| https://github.com/maxkoryukov |
| maxkoryukov | https://github.com/maxkoryukov |
| May 25, 2016 | https://github.com/nodegit/nodegit/pull/260#issuecomment-221707554 |
| Bluebird-lib | http://bluebirdjs.com/ |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| May 25, 2016 | https://github.com/nodegit/nodegit/pull/260#issuecomment-221709407 |
| #854 | https://github.com/nodegit/nodegit/pull/854 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
| https://github.co/hiddenchars |
| https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F260 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/260 |
|
| https://github.com/johnhaley81 |
|
| https://github.com/tbranyen |
|
| https://github.com/maxkoryukov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |